Bamboo Piston Fix. #3424
No reviewers
Labels
No Label
#P1 CRITICAL
#P2: HIGH
#P3: elevated
#P4 priority: medium
#P6: low
#Review
annoying
API
bug
code quality
combat
commands
compatibility
configurability
contribution inside
controls
core feature
creative mode
delayed for engine release
documentation
duplicate
enhancement
environment
feature request
gameplay
graphics
ground content conflict
GUI/HUD
help wanted
incomplete feature
invalid / won't fix
items
looking for contributor
mapgen
meta
mineclone2+
Minecraft >= 1.13
Minecraft >= 1.17
missing feature
mobile
mobs
mod support
model needed
multiplayer
Needs adoption
needs discussion
needs engine change
needs more information
needs research
nodes
non-mob entities
performance
player
possible close
redstone
release notes
schematics
Skyblock
sounds
Testing / Retest
tools
translation
unconfirmed
mcl5
mcla
Media missing
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: VoxeLibre/VoxeLibre#3424
Loading…
Reference in New Issue
No description provided.
Delete Branch "Bamboo_Piston_fix"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fix merge / rebase crossing massacre.
[Michieal]
83bc60722d
Begin: make bamboo dig-able by Pistons for Farm Creation.[Michieal]
449cbdb330
Make Bamboo & Bamboo items not sticky for pistons.[Michieal]
a44566f863
hijack the ABM to check for orphaned bamboo nodes.[Michieal]
5dff9e1994
Fixed the ABM situation so that now bamboo "breaks" when pushed by pistons.Probably not the most elegant, but hey. It works.
[Michieal]
76507025d9
Cleaned up the global function to match the current ABM.[Michieal]
a5bdc8a166
fix bamboo mosaic recipe.[Michieal]
14383d6c6f
update mod.conf to use optional depends mesecons_mvps[Michieal]
f81d530912
Update init.lua to register dropper callback.Tell us about your pull request! Reference related issues, if necessary
This pull request is to make Bamboo breakable by pistons, so that farms work properly.
Positive side effect of this is that removing nodes under bamboo plants should cause the bamboo to break on the next grow cycle.
Testing
Put a piston on a block of stone, with a lever or button next to the piston, to where the piston will impact one of the segments of a bamboo stalk. Trigger the piston, and watch the bamboo break.
This pull request fixes #3399
. . .
Fix any issues that git alerts you about.
Only ever force push if you have rebased and you know it's fine. Git has the safety rails on at all times. A force push is you removing the safety rails and saying I know this could be a destructive change, but I know what I am doing. This should only ever be done on a feature branch. :)
Also works as: git push -f origin branch_name
@ -70,0 +70,4 @@
-- For when I learn more about the pistons...
function mcl_bamboo.break_orphaned(pos)
mcl_bamboo.mcl_log("Break_Orphaned called.")
local node_below = minetest.get_node(vector.offset(pos, 0, -1, 0))
Just noticed the indentation here. Can we pull it in line for this block, please?
Fixed.
Looks good and works. Thanks for fixing!
3d1d5faa9d
tof6b77aa458