Fixed weather not clearing after sleep #3414
No reviewers
Labels
No Label
#P1 CRITICAL
#P2: HIGH
#P3: elevated
#P4 priority: medium
#P6: low
#Review
annoying
API
bug
code quality
combat
commands
compatibility
configurability
contribution inside
controls
core feature
creative mode
delayed for engine release
documentation
duplicate
enhancement
environment
gameplay
graphics
ground content conflict
GUI/HUD
help wanted
incomplete feature
invalid / won't fix
items
looking for contributor
mapgen
meta
mineclone2+
Minecraft >= 1.13
Minecraft >= 1.17
missing feature
mobile
mobs
mod support
model needed
multiplayer
Needs adoption
needs discussion
needs engine change
needs more information
needs research
nodes
non-Minecraft feature
non-mob entities
performance
player
possible close
redstone
release notes
schematics
Skyblock
sounds
Testing / Retest
tools
translation
unconfirmed
mcl5
mcla
Media missing
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: VoxeLibre/VoxeLibre#3414
Loading…
Reference in New Issue
No description provided.
Delete Branch "rain_bed_skip"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
When it is raining, the weather doesn't clear after you sleep. Hopefully this fixes it correctly. Yes, it looks strange, but I got funky results from testing it when coded "clean".
Testing
Place a bed, set time to night time, and weather to rain or snow. Sleep. On master, it should still be raining or snowing in the morning. On branch, it should be clear or just clearing up.
Issues Fixed
This PR Fixes #3411.
8a0b58463c
tob1a66d76f7
A side note from master, day rain is pitch black, night rain is light. Any ideas? It's bugging me :).
Looks good and works.
Thanks for picking this up, it was a little annoying :).
b1a66d76f7
to70fb4f8a0d
Honestly, I have no idea. Its something that erked cora's hide too.
Jeez, merge conflict checking has been slow lately.