Playable nether #2836

cora · 2022-10-23T14:35:35+02:00

cora commented

2022-10-23 14:35:35 +02:00

I found out it's possible to simply tweak the v7 mapgen settings for the game allowing for a much more open nether.

This is simply achieved by changing the mgv7_cavern_threshold setting to a lower value ( a corresponding setting exists for the mapgens v5, valleys, carpathian and fractal as well )

It also fixes a couple issues with weird looking patches in nether biomes and adds an initial implementation of structures having "secondary" daughter structures, in this case used for a nether bulwark (mini bastion) with randomly interchangable interior (there's 4 different types like with bastions).

Additional changes:

Fixed some issues with biomes/decorations
Added Nether Bulwarks (mini-bastions)
Added Nether bridge fragments - spawns wither skellys
Removed "wild" nether wart spawning (only in bulwarks and outposts now)
Removed "wild" wither skelly spawning (only on bridges)
Add wither rose
Added a structure mob (re)spawning api - it sets a metadata field in the spawn nodes and uses an abm to respawn mobs on demand
Added strider - ~~bounces way too much on the lava rn to actually ride it~~ fixed this by making it "snap" to the lava surface for now when a player is attached

This PR fixes #2180 (without the need for full lua mg)
This PR fixes #2875
This PR fixes #2834 by respawning the relevant mobs if needed

I found out it's possible to simply tweak the v7 mapgen settings for the game allowing for a much more open nether. This is simply achieved by changing the mgv7_cavern_threshold setting to a lower value ( a corresponding setting exists for the mapgens v5, valleys, carpathian and fractal as well ) It also fixes a couple issues with weird looking patches in nether biomes and adds an initial implementation of structures having "secondary" daughter structures, in this case used for a nether bulwark (mini bastion) with randomly interchangable interior (there's 4 different types like with bastions). Additional changes: - [x] Fixed some issues with biomes/decorations - [x] Added Nether Bulwarks (mini-bastions) - [x] Added Nether bridge fragments - spawns wither skellys - [x] Removed "wild" nether wart spawning (only in bulwarks and outposts now) - [x] Removed "wild" wither skelly spawning (only on bridges) - [x] Add wither rose - [x] Added a structure mob (re)spawning api - it sets a metadata field in the spawn nodes and uses an abm to respawn mobs on demand - [x] Added strider - ~~bounces way too much on the lava rn to actually ride it~~ fixed this by making it "snap" to the lava surface for now when a player is attached This PR fixes #2180 (without the need for full lua mg) This PR fixes #2875 This PR fixes #2834 by respawning the relevant mobs if needed ![](https://mister-muffin.de/p/8qP0.png) ![](https://mister-muffin.de/p/HLlf.png) ![](https://mister-muffin.de/p/F3bf.png)

👍 4 👀 3 ❤️ 1

FossFanatic commented

2022-10-23 18:16:14 +02:00

Thank you very much for this. It has always bothered me that the nether in this game just looked like an ordinary cave that was reskinned slightly.

cora commented

2022-10-23 18:19:17 +02:00

it's a very old much discussed problem and I seem to have solved it with 1 simple command ... i can't believe noone has tried this before ^^

will need a bit of testing but it seems to work very well so far

it's a very old much discussed problem and I seem to have solved it with 1 simple command ... i can't believe noone has tried this before ^^ will need a bit of testing but it seems to work very well so far

FossFanatic commented

2022-10-23 18:21:18 +02:00

These larger caves might also come in handy for when the cave biomes, such as the dripstone caves, get added.

cora force-pushed nether_mg_settings from e19e8eb816 to 6ac83cdb3a

2022-10-23 18:21:24 +02:00

Compare

cora commented

2022-10-23 18:25:44 +02:00

These larger caves might also come in handy for when the cave biomes, such as the dripstone caves, get added.

possibly yes - that one might not be as simple though ... we'll see

> These larger caves might also come in handy for when the cave biomes, such as the dripstone caves, get added. possibly yes - that one might not be as simple though ... we'll see

cora force-pushed nether_mg_settings from 6ac83cdb3a to 27078e23a1

2022-10-23 20:21:05 +02:00

Compare

cora added the

mapgen

gameplay

incomplete feature

labels 2022-10-24 00:31:44 +02:00

cora force-pushed nether_mg_settings from 97230bdda7 to 4e07e9efba

2022-10-24 01:39:25 +02:00

Compare

cora force-pushed nether_mg_settings from b0a4ed964e to 4f8f02d80a

2022-10-25 12:48:22 +02:00

Compare

cora changed title from ~~WIP: Larger nether caves~~ to Larger nether caves

2022-10-26 11:33:20 +02:00

cora force-pushed nether_mg_settings from 4e391ce374 to c47c473319

2022-10-27 02:19:32 +02:00

Compare

cora force-pushed nether_mg_settings from c47c473319 to ce081ffd49

2022-10-27 17:14:56 +02:00

Compare

cora commented

2022-10-27 17:48:36 +02:00

Going to merge this soon. Because of the lava oceans this can cause I have a fixed strider branch prepared to add on top of this.

FossFanatic commented

2022-10-27 18:22:54 +02:00

Is the bedrock roof visible in the new nether? Because they aren't visible at all in MC, and instead have a couple of layers of netherrack covering them.

cora commented

2022-10-27 19:00:01 +02:00

Well i've figured out a hacky hack to fix that but like I still do not understand you people: one of the prob biggest issues in the history of mcl2 gets fixed and all you think about is "this detail isn't EXACTLY LIKE MC" lol

exactly this kind of attitude is why quite a few things i have made before are not in the game (e.g. lush caves, lower bedrock) because after a bunch of work on it the only thing people have to say "it isn't perfectly like mc" .... and other things i'm not even going to try because i know it's going to be impossible to make them EXACTLY LIKE MC...

I have news for you: the whole world generation isnt EXACTLY LIKE MC - if you want to play something that is exactly like mc ... theres an easy way yk ... it's not that expensive.

Well i've figured out a hacky hack to fix that but like I still do not understand you people: one of the prob biggest issues in the history of mcl2 gets fixed and all you think about is "this detail isn't EXACTLY LIKE MC" lol exactly this kind of attitude is why quite a few things i have made before are not in the game (e.g. lush caves, lower bedrock) because after a bunch of work on it the only thing people have to say "it isn't perfectly like mc" .... and other things i'm not even going to try because i know it's going to be impossible to make them EXACTLY LIKE MC... I have news for you: the whole world generation isnt EXACTLY LIKE MC - if you want to play something that is exactly like mc ... theres an easy way yk ... it's not *that* expensive.

👍 2 😆 2

FossFanatic commented

2022-10-27 20:27:41 +02:00

I was just trying to help the development team get as close to the experience as possible. Don't take this personally, for I say these nitpicky kind of things for everyone. I was just suggesting for the netherrack roof to be added. I never said that you have to add it or throw it all away otherwise.

👍 1

cora force-pushed nether_mg_settings from c130c0dc65 to 62463c0c7c

2022-10-28 13:37:38 +02:00

Compare

cora changed title from ~~Larger nether caves~~ to Playable nether

2022-10-28 20:15:12 +02:00

cora force-pushed nether_mg_settings from 0652fd8dc8 to f927687365

2022-10-28 21:51:21 +02:00

Compare

werdanith commented

2022-10-29 01:10:29 +02:00

First-time contributor

Before I contribute my own whining I'd like to thank you for the great work you have done, on mineclone in general and on the nether in particular. Finally walking around in mineclone's nether you get to experience the awe and beauty it should inspire, perhaps only lacking Dead Voxel playing in the background.

But, in order to get a couple of things right since the generation is getting revamped, I'd like to point out that the lava floor should also be mostly covered by netherrack, since right bellow the lava is the statistically best place to mine ancient debris, and with the current generation it would be much harder to find appropriate spots to mine. Apparently in minecraft there are lava caves that reach to bedrock, but they are the exception, not the rule.

Also, I quite like the new structures, but in regards to the bulwark, as much as I like the soul fire aesthetic, and assuming minecraft's rules are adhered to, piglins are actually scared of all forms of soul fire, so they probably wouldn't want to live there by choice.

This work also exposes other concerns, like the uneven distribution of nether biomes, but that might be outside the scope of this already extensive pull request.

Before I contribute my own whining I'd like to thank you for the great work you have done, on mineclone in general and on the nether in particular. Finally walking around in mineclone's nether you get to experience the awe and beauty it should inspire, perhaps only lacking Dead Voxel playing in the background. But, in order to get a couple of things right since the generation is getting revamped, I'd like to point out that the lava floor should also be mostly covered by netherrack, since right bellow the lava is the statistically best place to mine ancient debris, and with the current generation it would be much harder to find appropriate spots to mine. Apparently in minecraft there are lava caves that reach to bedrock, but they are the exception, not the rule. Also, I quite like the new structures, but in regards to the bulwark, as much as I like the soul fire aesthetic, and assuming minecraft's rules are adhered to, piglins are actually scared of all forms of soul fire, so they probably wouldn't want to live there by choice. This work also exposes other concerns, like the uneven distribution of nether biomes, but that might be outside the scope of this already extensive pull request.

cora commented

2022-10-29 01:37:29 +02:00

Nothing is getting revamped, i just changed a cavegen option. The actual new nether generation is literally 1 line (well like 5,one for each mapgen). Maybe someone who actually knows what they're doing with this noise stuff might be able to get better floor coverage but for now this is probably as good as it gets. Now i could cover the floor in netherrack just like the ceiling probably but no ores would generate in it + it's just an uneven layer of 5 nodes or so - you probably wouldn't want to mine in that anyways.

Also, I quite like the new structures, but in regards to the bulwark, as much as I like the soul fire aesthetic, and assuming minecraft's rules are adhered to, piglins are actually scared of all forms of soul fire, so they probably wouldn't want to live there by choice.

That's a good point, well i guess they should be replaced by normal torches or something then - i mean for now i guess it's ok because our piglins aren't afraid of soul stuff (yet) haha

This work also exposes other concerns, like the uneven distribution of nether biomes, but that might be outside the scope of this already extensive pull request.

I don't think they're particularly uneven - they just get kind of large - but yeah that would be nice to change some time but probably quite time consuming cause it's just endless trial and error with numbers if you're like me and have no idea what you're even doing lol

Nothing is getting revamped, i just changed a cavegen option. The actual new nether generation is literally 1 line (well like 5,one for each mapgen). Maybe someone who actually knows what they're doing with this noise stuff might be able to get better floor coverage but for now this is probably as good as it gets. Now i could cover the floor in netherrack just like the ceiling probably but no ores would generate in it + it's just an uneven layer of 5 nodes or so - you probably wouldn't want to mine in that anyways. > Also, I quite like the new structures, but in regards to the bulwark, as much as I like the soul fire aesthetic, and assuming minecraft's rules are adhered to, piglins are actually scared of all forms of soul fire, so they probably wouldn't want to live there by choice. That's a good point, well i guess they should be replaced by normal torches or something then - i mean for now i guess it's ok because our piglins aren't afraid of soul stuff (yet) haha > This work also exposes other concerns, like the uneven distribution of nether biomes, but that might be outside the scope of this already extensive pull request. I don't think they're particularly uneven - they just get kind of large - but yeah that would be nice to change some time but probably quite time consuming cause it's just endless trial and error with numbers if you're like me and have no idea what you're even doing lol

Michieal commented

2022-10-29 01:58:19 +02:00

To help clarify some, this is one of the many steps towards the evenual rewrite of the mapgen code. Cora wanted to make the nether biomes be better and to take a good look at the mapgen process to see what could be done to do that.

Through the process, more entities have been incorporated, and the structures have been made better. And the biggest thing? when you pop down to the new nether, your not in the itty-bitty little portal area with very little space to move around in (for the entirity of the biome zone). Now you pop in, go out some and see expanses of awesomeness with "life" happening in them.

Just adding in some background. Hope it helps :)

To help clarify some, this is one of the many steps towards the evenual rewrite of the mapgen code. Cora wanted to make the nether biomes be better and to take a good look at the mapgen process to see what could be done to do that. Through the process, more entities have been incorporated, and the structures have been made better. And the biggest thing? when you pop down to the new nether, your not in the itty-bitty little portal area with very little space to move around in (for the entirity of the biome zone). Now you pop in, go out some and see expanses of awesomeness with "life" happening in them. Just adding in some background. Hope it helps :)

cora commented

2022-10-29 03:18:45 +02:00

Well we can't actually rewrite the mapgen (unless we'd do it all in lua which will be slow).

The good part about this solution is that it can still use the fast minetest mapgen api.

I found a solution for the bedrock floor anyways - and it even generates ores.

Well we can't actually rewrite the mapgen (unless we'd do it all in lua which will be slow). The good part about this solution is that it can still use the fast minetest mapgen api. I found a solution for the bedrock floor anyways - and it even generates ores.

Michieal commented

2022-10-29 12:11:21 +02:00

" 7fe75512c8 change bulwark to use soulless fire for piggy comfort" lmfao!!!

cora force-pushed nether_mg_settings from b2589ebaa5 to 7ce0f9739f

2022-10-29 12:44:37 +02:00

Compare

Ghost commented

2022-10-29 17:45:56 +02:00

First-time contributor

~~Make our own custom mapgen type for minetest.~~

~~Make our own custom mapgen type for minetest.~~

Ghost commented

2022-10-29 22:01:33 +02:00

First-time contributor

@cora you messed up the damn pillager outpost wall fixer code again.

😆 1

cora commented

2022-10-29 22:07:23 +02:00

@cora you messed up the damn pillager outpost wall fixer code again.

uh i don't think i have touched that.

speaking of which: why is it that fences are so nice and walls suck so much ?

Aren't they kind of the same technically ?

> @cora you messed up the damn pillager outpost wall fixer code again. uh i don't think i have touched that. speaking of which: why is it that fences are so nice and walls suck so much ? Aren't they kind of the same technically ?

Ghost commented

2022-10-29 22:20:09 +02:00

First-time contributor

No idea, I didnt write the code for either one.

cora commented

2022-10-29 22:30:33 +02:00

...i'll fix it when i do the great wall rewrite (tm) ^^

cora commented

2022-10-29 22:33:02 +02:00

i'd say probably walls are just so dumb because thats what some minetest wall mod that was around then did, it was included and has never been touched again^^

i'll try to figure out the pillipost thing though

i'd say probably walls are just so dumb because thats what some minetest wall mod that was around then did, it was included and has never been touched again^^ i'll try to figure out the pillipost thing though

cora force-pushed nether_mg_settings from 38f929b02f to 872e050b31

2022-11-01 00:08:05 +01:00

Compare

cora force-pushed nether_mg_settings from 110a63b35c to 9a2cceed68

2022-11-01 04:27:50 +01:00

Compare

cora force-pushed nether_mg_settings from 9a2cceed68 to dbdac3e850

2022-11-01 04:52:28 +01:00

Compare

cora force-pushed nether_mg_settings from dbdac3e850 to ae9173f7ec

2022-11-02 01:01:48 +01:00

Compare