water mobs #2403

cora · 2022-07-08T02:46:39+02:00

cora commented

2022-07-08 02:46:39 +02:00

This abstracts the variable height spawning to mcl_mobs and adds salmon, cod and dolphin from mcl5 (although some of their api stuff can't be used ofc).

I want to add spawning in groups still which doesn't appear to work quite right yet.

This abstracts the variable height spawning to mcl_mobs and adds salmon, cod and dolphin from mcl5 (although some of their api stuff can't be used ofc). I want to add spawning in groups still which doesn't appear to work quite right yet.

👍 3

cora referenced this pull request

2022-07-08 11:52:47 +02:00

Fish Buckets #2404

cora force-pushed water_mobs from f0a460fe6e to 5a90ae38b7

2022-07-08 12:47:25 +02:00

Compare

cora changed title from ~~WIP: water mobs~~ to water mobs

2022-07-08 12:47:39 +02:00

cora commented

2022-07-08 12:47:50 +02:00

Fixed group spawning.

AFCMS added the

mobs

label 2022-07-08 14:54:51 +02:00

MysticTempest commented

2022-07-08 17:48:24 +02:00

Tested, group_spawning looks great! Found a few schools of fish, and a pod of dolphins.

Textures:

Hrm, the dolphin texture needs changing as it's just a color swap, & like 2 pixel deletion from the eyes; of the MC version.
Salmon & cod textures seem sufficiently original though.

Extra note:

The picking up of fish; feels a bit rough to me.

Fine to merge, but I think we should look into moving it to 'mcl_buckets' later. As the "on_rightclick" call seems to conflict with water_placement making it hard to pickup the fish.

Tested, group_spawning looks great! Found a few schools of fish, and a pod of dolphins. --- **Textures:** Hrm, the dolphin texture needs changing as it's just a color swap, & like 2 pixel deletion from the eyes; of the MC version. Salmon & cod textures seem sufficiently original though. **Extra note:** The picking up of fish; feels a bit rough to me. Fine to merge, but I think we should look into moving it to 'mcl_buckets' later. As the "on_rightclick" call seems to conflict with water_placement making it hard to pickup the fish.

👍 1

cora commented

2022-07-08 17:56:49 +02:00

Yeah I noticed that too - p much just took the mcl5 code for that.

But yeah textures need to be fixed before merge.

Yeah I noticed that too - p much just took the mcl5 code for that. But yeah textures need to be fixed before merge.

👍 1

cora changed title from ~~water mobs~~ to WIP: water mobs

2022-07-08 17:57:08 +02:00

Ghost requested changes 2022-07-09 00:55:00 +02:00

mods/ENTITIES/mobs_mc/cod.lua Outdated

					
				@ -0,0 +23,4 @@

					return rad * 180.0 / math.pi

				end

				local S = minetest.get_translator("extra_mobs")

Ghost commented

2022-07-09 00:54:21 +02:00

First-time contributor

is this supposed to be extra_mobs for any reason, or do the translations need to be updated and this changed to mobs_mc?

cora commented

2022-07-09 02:27:03 +02:00

fair point hehe

Ghost marked this conversation as resolved

mods/ENTITIES/mobs_mc/dolphin.lua Outdated

					
				@ -0,0 +91,4 @@

					end,

				}

				mcl_mobs:register_mob("mobs_mc:dolphin", dolphin)

Ghost commented

2022-07-09 00:54:07 +02:00

First-time contributor

is this supposed to be extra_mobs for any reason, or do the translations need to be updated and this changed to mobs_mc?

Ghost marked this conversation as resolved

mods/ENTITIES/mobs_mc/salmon.lua Outdated

					
				@ -0,0 +3,4 @@

				--made for MC like Survival game

				--License for code WTFPL and otherwise stated in readmes

				local S = minetest.get_translator("extra_mobs")

Ghost commented

2022-07-09 00:53:38 +02:00

First-time contributor

is this supposed to be extra_mobs for any reason, or do the translations need to be updated and this changed to mobs_mc?

Ghost marked this conversation as resolved

cora force-pushed water_mobs from e9a78e30ba to e9b72083b3

2022-07-09 02:31:02 +02:00

Compare

Ghost approved these changes 2022-07-09 04:30:26 +02:00

cora commented

2022-07-09 12:42:13 +02:00

The bucket api does not appear to support entities; just nodes so i suppose it's best to go with the on_rightclick - and i mean i guess it's ok if catching fish with a bucket isn't exactly easy hehe.

cora changed title from ~~WIP: water mobs~~ to water mobs

2022-07-09 12:42:18 +02:00

kneekoo commented

2022-07-09 13:05:35 +02:00

The bucket api does not appear to support entities; just nodes

Does this mean we can't release the caught fish (for acquariums)? I haven't tested this yet.

> The bucket api does not appear to support entities; just nodes Does this mean we can't release the caught fish (for acquariums)? I haven't tested this yet.

cora commented

2022-07-09 14:51:21 +02:00

You can release them it just doesn't use the bucket api

👍 1

MysticTempest approved these changes 2022-07-09 17:26:44 +02:00

MysticTempest commented

2022-07-09 17:28:26 +02:00

The bucket api does not appear to support entities; just nodes so i suppose it's best to go with the on_rightclick - and i mean i guess it's ok if catching fish with a bucket isn't exactly easy hehe.

Ah okay; well thanks for checking. Looks good overall, and nice new texture!

> The bucket api does not appear to support entities; just nodes so i suppose it's best to go with the on_rightclick - and i mean i guess it's ok if catching fish with a bucket isn't exactly easy hehe. Ah okay; well thanks for checking. Looks good overall, and nice new texture!

MrRar commented

2022-07-09 18:28:00 +02:00

@cora Update the translation template for mobs_mc.

cora added 1 commit 2022-07-09 22:18:13 +02:00

4a4636523e Add new mobs to translation template.

cora commented

2022-07-09 22:18:48 +02:00

Well that i am making a toki pona translation now is your fault and your fault alone :P

😆 1

cora merged commit ec6d5628e2 into master

2022-07-10 00:22:18 +02:00

cora referenced this issue from a commit