VoxeLibre/VoxeLibre
VoxeLibre
/
VoxeLibre
60
133
Fork 177
Code Issues 980 Pull Requests 90 Projects 4 Releases Wiki Activity

Glorius Mud #2402

Merged
cora merged 14 commits from TheRandomLegoBrick/MineClone2:mud into master 2022-07-09 02:24:55 +02:00
Conversation 24 Commits 14 Files Changed 13 +171 -68
TheRandomLegoBrick commented 2022-07-06 23:05:19 +02:00
Member
Copy Link

Adds the new 1.19 mud blocks. Since mangrove swamps arn't yet a thing, water bottles and dirt are the only way to obtain all of the mud related blocks.

Todo:

  • Mud
  • Convert dirt/coarse dirt to mud with water bottle
  • Convert dirt/coarse dirt to mud with water bottle from dispenser
  • Packed Mud
  • Move code from mcl_core to new mod: mcl_mud
  • Mud Bricks
    • Mud Brick stairs
    • Mud Brick slabs
    • Mud Brick walls
  • Clean up the redundant water bottle code in mcl_potions
  • Sounds
Adds the new 1.19 mud blocks. Since mangrove swamps arn't yet a thing, water bottles and dirt are the only way to obtain all of the mud related blocks. Todo: - [x] Mud - [x] Convert dirt/coarse dirt to mud with water bottle - [x] Convert dirt/coarse dirt to mud with water bottle from dispenser - [x] Packed Mud - [x] Move code from mcl_core to new mod: mcl_mud - [x] Mud Bricks - [x] Mud Brick stairs - [x] Mud Brick slabs - [x] Mud Brick walls - [x] Clean up the redundant water bottle code in mcl_potions - [x] Sounds
screenshot_20220707_151723.jpg
77 KiB
screenshot_20220708_102703.jpg
87 KiB
screenshot_20220707_151723.jpg screenshot_20220708_102703.jpg
👍 2 ❤️ 2
TheRandomLegoBrick added 4 commits 2022-07-06 23:05:24 +02:00
kneekoo commented 2022-07-06 23:16:28 +02:00
Contributor
Copy Link

This mud looks almost identical to the one in Minecraft. The packed one is fine, although in Minecraft it's closer to the dirt's color.

As for rooted dirt, it's in the making, as mcl_lush_caves:rooted_dirt in the lush_caves branch. Rooted dirt should also turn to mud when using a water bottle on it.

This mud looks almost identical to [the one in Minecraft](https://minecraft.fandom.com/wiki/Mud). The packed one is fine, although [in Minecraft](https://minecraft.fandom.com/wiki/Packed_Mud) it's closer to the dirt's color. As for rooted dirt, it's in the making, as `mcl_lush_caves:rooted_dirt` in the [lush_caves branch](https://git.minetest.land/MineClone2/MineClone2/src/branch/lush_caves). Rooted dirt should also turn to mud when using a water bottle on it.
cora commented 2022-07-06 23:18:30 +02:00
Contributor
Copy Link

Well it's the pixelperfection one in the lush_caves branch - the cave vines were fine i think but not sure about the rdirt

Well it's the pixelperfection one in the lush_caves branch - the cave vines were fine i think but not sure about the rdirt
TheRandomLegoBrick commented 2022-07-06 23:23:33 +02:00
Author
Member
Copy Link

hmm, your right, it does look close. I'll experiment with the textures.

ok, thats good to know.

hmm, your right, it does look close. I'll experiment with the textures. ok, thats good to know.
kneekoo commented 2022-07-06 23:24:23 +02:00
Contributor
Copy Link

not sure about the rdirt

I found it in db3aeec59d.

> not sure about the rdirt I found it in db3aeec59d.
cora commented 2022-07-06 23:54:48 +02:00
Contributor
Copy Link

uh i don't see it in that commit but the texture appears to be fine. Mud is debatable i guess. I mean the pattern does seem to be different but then it is also somewhat similar lol.

uh i don't see it in that commit but the texture appears to be fine. Mud is debatable i guess. I mean the pattern does seem to be different but then it is also somewhat similar lol.
cora commented 2022-07-06 23:55:39 +02:00
Contributor
Copy Link

mud texture sounds p easy to make though

mud texture sounds p easy to make though
kneekoo commented 2022-07-07 00:14:32 +02:00
Contributor
Copy Link

uh i don't see it in that commit but the texture appears to be fine.

function mcl_lush_caves.makeazaela(pos,pr)
.
.
.
minetest.set_node(pos,{name="mcl_lush_caves:rooted_dirt"})
> uh i don't see it in that commit but the texture appears to be fine. ``` function mcl_lush_caves.makeazaela(pos,pr) . . . minetest.set_node(pos,{name="mcl_lush_caves:rooted_dirt"}) ```
cora commented 2022-07-07 03:42:27 +02:00
Contributor
Copy Link

uh ok that's the node definition, not exactly what i was looking for as it doesn't really to help determine if the texture is from minecraft.

uh ok that's the node definition, not exactly what i was looking for as it doesn't really to help determine if the texture is from minecraft.
TheRandomLegoBrick added 1 commit 2022-07-07 05:27:34 +02:00
AFCMS added the
nodes
Minecraft >= 1.13
 labels 2022-07-07 16:45:57 +02:00
AFCMS reviewed 2022-07-07 16:52:50 +02:00
mods/ITEMS/mcl_mud/mod.conf Outdated
@ -0,0 +1,2 @@
author = TheRandomLegoBrick
AFCMS commented 2022-07-07 16:52:50 +02:00
Member
Copy Link

name = mcl_mud should be added

`name = mcl_mud` should be added
TheRandomLegoBrick commented 2022-07-07 17:30:54 +02:00
Author
Member
Copy Link

whoops, forgot about that.

EDIT: fixed in 4f1960d6ef

whoops, forgot about that. EDIT: fixed in 4f1960d6ef
cora commented 2022-07-07 17:53:14 +02:00
Contributor
Copy Link

Most important part hehe u can p much leave out the rest if you want I think

Most important part hehe u can p much leave out the rest if you want I think
AFCMS marked this conversation as resolved
TheRandomLegoBrick added 1 commit 2022-07-07 17:29:44 +02:00
AFCMS approved these changes 2022-07-07 18:49:26 +02:00
TheRandomLegoBrick added 1 commit 2022-07-07 20:54:46 +02:00
TheRandomLegoBrick added 1 commit 2022-07-08 00:16:56 +02:00
TheRandomLegoBrick added 1 commit 2022-07-08 01:51:07 +02:00
AFCMS approved these changes 2022-07-08 14:54:37 +02:00
TheRandomLegoBrick added 1 commit 2022-07-08 18:19:08 +02:00
TheRandomLegoBrick added 1 commit 2022-07-08 19:02:18 +02:00
TheRandomLegoBrick added 1 commit 2022-07-08 19:31:52 +02:00
TheRandomLegoBrick changed title from WIP: Glorius Mud to Glorius Mud 2022-07-08 19:32:59 +02:00
TheRandomLegoBrick added 1 commit 2022-07-08 19:33:17 +02:00
cora commented 2022-07-08 20:39:20 +02:00
Contributor
Copy Link

*allegedly.... I'm not convinced it was actually copied but in some ways it was a bit similar so good you made an original

\*allegedly.... I'm not convinced it was actually copied but in some ways it was a bit similar so good you made an original
TheRandomLegoBrick commented 2022-07-08 20:45:17 +02:00
Author
Member
Copy Link

both texutres were by me, neither were copied.

both texutres were by me, neither were copied.
TheRandomLegoBrick requested review from AFCMS 2022-07-09 00:42:19 +02:00
TheRandomLegoBrick added 1 commit 2022-07-09 00:42:49 +02:00
cora merged commit 6d5e8822dd into master 2022-07-09 02:24:30 +02:00
thunder1035 commented 2022-07-09 07:53:01 +02:00
First-time contributor
Copy Link

Hello there everyone,I want you all to be patient as I am already working on the wild update for mineclone 2.
Please give me some time for fixing some error in my mod.
Currently the mod is WIP, right now I am working on mod into mod pack conversion so please don't start with wild update stuff for mineclone 2, it's a request.

https://github.com/thunder1035/Wild_update

Hello there everyone,I want you all to be patient as I am already working on the wild update for mineclone 2. Please give me some time for fixing some error in my mod. Currently the mod is WIP, right now I am working on mod into mod pack conversion so please don't start with wild update stuff for mineclone 2, it's a request. https://github.com/thunder1035/Wild_update
👍 1
cora commented 2022-07-09 11:12:12 +02:00
Contributor
Copy Link

Please make sure all textures are under a permissive license (pixelperfection has minecraft copies!)

Please make sure all textures are under a permissive license (pixelperfection has minecraft copies!)
cora commented 2022-07-09 11:15:20 +02:00
Contributor
Copy Link

you might want to rebase however seeing as mud exists already now

you might want to rebase however seeing as mud exists already now
cora commented 2022-07-09 11:30:44 +02:00
Contributor
Copy Link

https://github.com/thunder1035/Wild_update

Does not appear to be working right now.

> https://github.com/thunder1035/Wild_update Does not appear to be working right now.
thunder1035 commented 2022-07-09 13:15:26 +02:00
First-time contributor
Copy Link

use mesecon modpack to make it work,mesecon will rewrite the sound error codes in redstone

use mesecon modpack to make it work,mesecon will rewrite the sound error codes in redstone
thunder1035 commented 2022-07-09 17:18:18 +02:00
First-time contributor
Copy Link

The latest Dev build of Wild Update modpack

The latest Dev build of Wild Update modpack
wild update(1.4.4_dev).zip
185 KiB
cora commented 2022-07-09 19:20:43 +02:00
Contributor
Copy Link

use mesecon modpack to make it work,mesecon will rewrite the sound error codes in redstone

That is very messy. Even using mesecons with mcl is likely to cause problems (if not overtly maybe).

> use mesecon modpack to make it work,mesecon will rewrite the sound error codes in redstone That is very messy. Even using mesecons with mcl is likely to cause problems (if not overtly maybe).
Ghost commented 2022-07-09 19:32:29 +02:00
First-time contributor
Copy Link

use mesecon modpack to make it work,mesecon will rewrite the sound error codes in redstone

Probably best to put up with the issues of redstone and incorperate it in your mod.

> use mesecon modpack to make it work,mesecon will rewrite the sound error codes in redstone > Probably best to put up with the issues of redstone and incorperate it in your mod.
cora commented 2022-07-09 20:02:53 +02:00
Contributor
Copy Link

Yeah the problem is that a number of Redstone mods are named mesecons still but its very likely they supply at least in parts a different feature set. So mods expecting mcl Redstone features(MCL mods) will think those are available when there's e.g. mesecons_torch or whatever loaded

Yeah the problem is that a number of Redstone mods are named mesecons still but its very likely they supply at least in parts a different feature set. So mods expecting mcl Redstone features(MCL mods) will think those are available when there's e.g. mesecons_torch or whatever loaded
thunder1035 commented 2022-07-11 16:19:11 +02:00
First-time contributor
Copy Link

Adds the new 1.19 mud blocks. Since mangrove swamps arn't yet a thing, water bottles and dirt are the only way to obtain all of the mud related blocks.

Todo:

  • Mud
  • Convert dirt/coarse dirt to mud with water bottle
  • Convert dirt/coarse dirt to mud with water bottle from dispenser
  • Packed Mud
  • Move code from mcl_core to new mod: mcl_mud
  • Mud Bricks
    • Mud Brick stairs
      • Mud Brick slabs
      • Mud Brick walls
  • Clean up the redundant water bottle code in mcl_potions
  • Sounds

also please make mud plant placeable like (tall grass and sugar cane)
as in mc 1.19 it is placeable,also make the collision box similar to soul sand's.

Just add(grass_block = 1 and soil_sugarcane = 1) in group

> Adds the new 1.19 mud blocks. Since mangrove swamps arn't yet a thing, water bottles and dirt are the only way to obtain all of the mud related blocks. > > Todo: > > - [x] Mud > - [x] Convert dirt/coarse dirt to mud with water bottle > - [x] Convert dirt/coarse dirt to mud with water bottle from dispenser > - [x] Packed Mud > - [x] Move code from mcl_core to new mod: mcl_mud > - [x] Mud Bricks > - [x] Mud Brick stairs > - [x] Mud Brick slabs > - [x] Mud Brick walls > - [x] Clean up the redundant water bottle code in mcl_potions > - [x] Sounds also please make mud plant placeable like (tall grass and sugar cane) as in mc 1.19 it is placeable,also make the collision box similar to soul sand's. Just add(grass_block = 1 and soil_sugarcane = 1) in group
👍 1
TheRandomLegoBrick commented 2022-07-11 17:35:42 +02:00
Author
Member
Copy Link

@thunder1035, Done (MineClone2/MineClone2#2413) :)

@thunder1035, Done (https://git.minetest.land/MineClone2/MineClone2/pulls/2413) :)
👍 1
thunder1035 commented 2022-07-18 16:44:50 +02:00
First-time contributor
Copy Link

hey guys, can someone please tell me how to add my project/mod in mineclone 2

hey guys, can someone please tell me how to add my project/mod in mineclone 2
cora commented 2022-07-18 16:56:29 +02:00
Contributor
Copy Link

hey guys, can someone please tell me how to add my project/mod in mineclone 2

  • fork the repository (click fork on the top right)
  • clone it (git clone REPO URL)
  • make a new branch (git checkout -b my_new_cool_feature)
  • do your changes
  • add new files (git add file1 file2 file3)
  • commit your changes (git commit -p)
  • push your changes (git push)
  • create a pull request
    • go to branches in your repository,
    • click "new pull request"
    • select MineClone2:master for "merge into"
    • select YourRepo:my_new_cool_feature for "Pull From"
  • write down a clear description of what changes your PR introduces and how people can test it.
> hey guys, can someone please tell me how to add my project/mod in mineclone 2 * fork the repository (click fork on the top right) * clone it (git clone REPO URL) * make a new branch (git checkout -b my_new_cool_feature) * do your changes * add new files (git add file1 file2 file3) * commit your changes (git commit -p) * push your changes (git push) * create a pull request * go to branches in your repository, * click "new pull request" * select MineClone2:master for "merge into" * select YourRepo:my_new_cool_feature for "Pull From" * write down a clear description of what changes your PR introduces and how people can test it.
👍 3
thunder1035 commented 2022-07-18 16:57:53 +02:00
First-time contributor
Copy Link

thanks cora

thanks cora
Sign in to join this conversation.
Reviewers
No reviewers
AFCMS
Labels
Clear labels   
#P1 CRITICAL

for crashes, catastrophic bugs, etc.

  
#P2: HIGH

highest priority level

  
#P3: elevated

2nd-highest priority level

  
#P4 priority: medium

for things that aren't elevated but have been prioritised

  
#P6: low

low priority level

  
#Review

Tickets that may improve or fix an issue but will need a review after a short period of time

  
annoying

non-bugs that annoys people

  
API

   
bug

   
code quality

   
combat

   
commands

   
compatibility

Label to cover migration issues from old worlds or mcl5

  
configurability

   
contribution inside

   
controls

   
core feature

   
creative mode

   
delayed for engine release

   
documentation

   
duplicate

   
enhancement

enhancement request/suggestion

  
environment

Issues that affect weather or light

  
feature request

   
gameplay

   
graphics

   
ground content conflict

mapgen gc-specific quirks

  
GUI/HUD

   
help wanted

   
incomplete feature

   
invalid / won't fix

Invalid, or will not fix

  
items

   
looking for contributor

   
mapgen

   
meta

Relating to VoxeLibre on Mesehub and elsewhere

  
mineclone2+

fit for MineClone2-Plus

  
Minecraft >= 1.13

   
Minecraft >= 1.17

   
missing feature

   
mobile

involving Minetest on mobile devices (android)

  
mobs

   
mod support

Issues related to mod support

  
model needed

A model is needed to be created or updated

  
multiplayer

Issues affecting multiplayer

  
Needs adoption

PR needs author action or to be adopted so changes can be implemented to get the PR closer to merge

  
needs discussion

   
needs engine change

   
needs more information

   
needs research

   
nodes

   
non-mob entities

   
performance

   
player

issues related to the player

  
possible close

   
redstone

   
release notes

This ticket will need information adding to release notes

  
schematics

   
Skyblock

   
sounds

   
Testing / Retest

This needs testing or retesting

  
tools

Related to the tools scripts, which aren't run in game

  
translation

   
unconfirmed
  
mcl5

Possibly relevant for MineClone5

  
mcla

Possibly relevant for Mineclonia

  
Media missing

media files for this feature are missing - contributions welcome

No Label
#P1 CRITICAL
#P2: HIGH
#P3: elevated
#P4 priority: medium
#P6: low
#Review
annoying
API
bug
code quality
combat
commands
compatibility
configurability
contribution inside
controls
core feature
creative mode
delayed for engine release
documentation
duplicate
enhancement
environment
feature request
gameplay
graphics
ground content conflict
GUI/HUD
help wanted
incomplete feature
invalid / won't fix
items
looking for contributor
mapgen
meta
mineclone2+
Minecraft >= 1.13
Minecraft >= 1.17
missing feature
mobile
mobs
mod support
model needed
multiplayer
Needs adoption
needs discussion
needs engine change
needs more information
needs research
nodes
non-mob entities
performance
player
possible close
redstone
release notes
schematics
Skyblock
sounds
Testing / Retest
tools
translation
unconfirmed
mcl5
mcla
Media missing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#2402
No description provided.
Delete Branch "TheRandomLegoBrick/MineClone2:mud"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?