Give players fly priv when creative is enabled #1865

NO11 · 2021-09-19T14:09:34+02:00

NO11 commented

2021-09-19 14:09:34 +02:00

No description provided.

NO11 added this to the 0.72.0 milestone 2021-09-19 14:09:34 +02:00

NO11 added the

missing feature

gameplay

labels 2021-09-19 14:09:34 +02:00

NO11 added 5 commits 2021-09-19 14:09:40 +02:00

4194a76db0 Merge pull request 'master' (#8 ) from MineClone2/MineClone2:master into master

Reviewed-on: NO11/MineClone2#8

0e15accada Enable fly in creative mode

18a83fa5d7 Fix typo

fed43586f2 fix typo

f10d579d9c Only change fly priv on join if it wasn't revoked or granted

Ghost requested changes 2021-09-20 07:52:59 +02:00

mods/MISC/mcl_privs/init.lua Outdated

					
				@ -6,0 +8,4 @@

					local name = player:get_player_name()

					local meta = player:get_meta()

					if meta:get_int("fly_changed") == 1 then return end

Ghost commented

2021-09-20 07:52:51 +02:00

First-time contributor

use last_login parameter to check new players.

use `last_login` parameter to check new players.

NO11 commented

2021-09-20 16:17:21 +02:00

used on_newplayer now.

Ghost commented

2021-09-20 17:00:39 +02:00

First-time contributor

oh much better!

NO11 commented

2021-09-21 20:23:12 +02:00

Oh NO now i remember why i didnt use on_newplayer. Imagine: a server owner turns the server back to survival...

NO11 commented

2021-09-21 20:24:40 +02:00

use last_login parameter to check new players.

Sry i forgot what my own code does. It wasnt a check for new players, it was a check wether the server owner or someone else changed the privs of the player when creative is disabled again when the player joins.

> use `last_login` parameter to check new players. Sry i forgot what my own code does. It wasnt a check for new players, it was a check wether the server owner or someone else changed the privs of the player when creative is disabled again when the player joins.

NO11 commented

2021-09-21 20:26:04 +02:00

When the the sever owner grants fly to the player maunally, the priv will not be changed on rejoin when creative isnt enabled.

NO11 commented

2021-09-21 20:27:52 +02:00

So can i change it back? Do you understand it?

Ghost commented

2021-09-22 16:47:22 +02:00

First-time contributor

just change it then :p. this PR is still in the works. Though, i appreciate explaining why 👍.

just change it then \:p. this PR is still in the works. Though, i appreciate explaining why :+1:.

NO11 marked this conversation as resolved

mods/MISC/mcl_privs/init.lua Outdated

					
				@ -6,0 +16,4 @@

					end

					minetest.set_player_privs(name, {

						fly = fly,

					})

Ghost commented

2021-09-20 07:52:02 +02:00

First-time contributor

This will remove all of new players' default_privs (check minetest.conf.example for the setting).

Test code:

@@ -14,9 +14,11 @@ minetest.register_on_joinplayer(function(player)
 	if minetest.is_creative_enabled(name) then
 		fly = true
 	end
+	minetest.chat_send_all(dump2(minetest.get_player_privs(name), name .."'s initial privs"))
 	minetest.set_player_privs(name, {
 		fly = fly,
 	})
+	minetest.chat_send_all(dump2(minetest.get_player_privs(name), name .."'s current privs"))
 end)
 
 for _, action in pairs({ "grant", "revoke" }) do

Chatlog:

TES_'s initial privs = {}
TES_'s initial privs["interact"] = true
TES_'s initial privs["shout"] = true
TES_'s current privs = {}
TES_'s current privs["fly"] = true

This will remove all of new players' `default_privs` (check `minetest.conf.example` for the setting). Test code: ```diff @@ -14,9 +14,11 @@ minetest.register_on_joinplayer(function(player) if minetest.is_creative_enabled(name) then fly = true end + minetest.chat_send_all(dump2(minetest.get_player_privs(name), name .."'s initial privs")) minetest.set_player_privs(name, { fly = fly, }) + minetest.chat_send_all(dump2(minetest.get_player_privs(name), name .."'s current privs")) end) for _, action in pairs({ "grant", "revoke" }) do ``` Chatlog: ``` TES_'s initial privs = {} TES_'s initial privs["interact"] = true TES_'s initial privs["shout"] = true TES_'s current privs = {} TES_'s current privs["fly"] = true ```

NO11 commented

2021-09-27 22:04:34 +02:00

hmmm. I know this is oudated but i dont think set_player_privs changed https://dev.minetest.net/minetest.set_player_privs

privs — a table containing the new privileges of the player. The keys are privilege names and the values are true. Privileges not specified are removed if the player had them before the call.

hmmm. I know this is oudated but i dont think set_player_privs changed https://dev.minetest.net/minetest.set_player_privs ``` privs — a table containing the new privileges of the player. The keys are privilege names and the values are true. Privileges not specified are removed if the player had them before the call. ```

Ghost commented

2021-09-28 02:50:49 +02:00

First-time contributor

this is not "outdated" despite what gitea tells you. the code is still the same, see lines 17-19.

or, if i misunderstood; yes, dev.minetest.net is probably outdated, but in this case it's correct (which you can verify it yourself by running the test code). i use the nightly lua_api.txt on gitlab and unfortunately the description is rather sparse.

Privileges not specified are removed if the player had them before the call.

What this means is that if i had interact priv as specified by default_privs, i will lose the priv once the call is made. my suggestion to fix this:

local player_privs = minetest.get_player_privs(name)
player_privs.fly = true
minetest.set_player_privs(name, player_privs)

this is not "outdated" despite what gitea tells you. the code is still the same, see lines 17-19. or, if i misunderstood; yes, dev.minetest.net is probably outdated, but in this case it's correct (which you can verify it yourself by running the test code). i use the nightly `lua_api.txt` on [gitlab](https://minetest.gitlab.io/minetest/) and unfortunately the description is rather sparse. > Privileges not specified are removed if the player had them before the call. What this means is that if i had `interact` priv as specified by `default_privs`, i will lose the priv once the call is made. my suggestion to fix this: ```lua local player_privs = minetest.get_player_privs(name) player_privs.fly = true minetest.set_player_privs(name, player_privs) ```

NO11 commented

2021-09-30 21:55:18 +02:00

@iliekprogrammar for me it works also without your fix:

2021-09-30 14:53:18: ERROR[Server]: singleplayer's initial privs = {}
singleplayer's initial privs["privs"] = true
singleplayer's initial privs["shout"] = true
singleplayer's initial privs["maphack"] = true
singleplayer's initial privs["interact"] = true
singleplayer's initial privs["basic_privs"] = true

2021-09-30 14:53:18: ERROR[Server]: ---------
2021-09-30 14:53:18: ERROR[Server]: singleplayer's initial privs = {}
singleplayer's initial privs["interact"] = true
singleplayer's initial privs["shout"] = true
singleplayer's initial privs["maphack"] = true
singleplayer's initial privs["privs"] = true
singleplayer's initial privs["fly"] = true
singleplayer's initial privs["basic_privs"] = true

@iliekprogrammar for me it works also without your fix: ``` 2021-09-30 14:53:18: ERROR[Server]: singleplayer's initial privs = {} singleplayer's initial privs["privs"] = true singleplayer's initial privs["shout"] = true singleplayer's initial privs["maphack"] = true singleplayer's initial privs["interact"] = true singleplayer's initial privs["basic_privs"] = true 2021-09-30 14:53:18: ERROR[Server]: --------- 2021-09-30 14:53:18: ERROR[Server]: singleplayer's initial privs = {} singleplayer's initial privs["interact"] = true singleplayer's initial privs["shout"] = true singleplayer's initial privs["maphack"] = true singleplayer's initial privs["privs"] = true singleplayer's initial privs["fly"] = true singleplayer's initial privs["basic_privs"] = true ```

NO11 commented

2021-09-30 22:08:09 +02:00

You're right, sorry.

NO11 marked this conversation as resolved