Title HUD API #1778

AFCMS · 2021-06-02T11:07:55+02:00

AFCMS commented

2021-06-02 11:07:55 +02:00

This mod is the work I did in the chat-command-builder branch, but refactored to be faster and more usable in mods.

source: https://www.digminecraft.com/game_commands/title_command.php

WARNING: this mod doesn't add the /title command, it's only an API

TODO:

API
mc like layout
pre support of https://github.com/minetest/minetest/pull/11022 (maybe this pr will be merged in 1-2 year, so I will open an issue to remind posterity to activate this part of code)
remove testing commands
documentation
drop mcl_tmp_message
make every mod use the new API

This mod is the work I did in the `chat-command-builder` branch, but refactored to be faster and more usable in mods. source: https://www.digminecraft.com/game_commands/title_command.php WARNING: this mod doesn't add the `/title` command, it's only an API TODO: - [x] API - [x] mc like layout - [x] pre support of https://github.com/minetest/minetest/pull/11022 (maybe this pr will be merged in 1-2 year, so I will open an issue to remind posterity to activate this part of code) - [x] remove testing commands - [x] documentation - [x] drop `mcl_tmp_message` - [x] make every mod use the new API

AFCMS added this to the 0.72.0 milestone 2021-06-02 11:07:55 +02:00

AFCMS added the

GUI/HUD

API

labels 2021-06-02 11:07:55 +02:00

AFCMS self-assigned this 2021-06-02 11:07:55 +02:00

AFCMS added 4 commits 2021-06-02 11:08:02 +02:00

640b0dc485 basic title API working (testing needed)

6b53dda79b add todo list

c8102838cb add missing TODO entry (bold+italic)

7e64470f70 fix future API usage of bold+italic pr

AFCMS added this to the 0.72 project 2021-06-02 11:08:15 +02:00

AFCMS requested review from Owners 2021-06-02 11:08:31 +02:00

AFCMS added 1 commit 2021-06-02 11:12:25 +02:00

b9fd1ac227 credit digminecraft for the tutorial

AFCMS commented

2021-06-02 17:16:26 +02:00

Not sure, but maybe this pr will be ready to merge today.

AFCMS added 1 commit 2021-06-02 17:59:14 +02:00

a21b14e707 Merge branch 'master' into title-API

AFCMS added 1 commit 2021-06-04 19:11:02 +02:00

881f0b0a71 Merge branch 'master' into title-API

AFCMS commented

2021-06-04 19:15:21 +02:00

@EliasFleckenstein03 Could you review API? Also, is actionbar a duplicate of mcl_tmp_messages?

@EliasFleckenstein03 Could you review API? Also, is actionbar a duplicate of `mcl_tmp_messages`?

LizzyFleckenstein03 commented

2021-06-04 19:58:19 +02:00

--TODO: enable this code then Fleckenstein's pr get merged (in about 5-6 years)

Maybe link the PR you're referencing here in the comment.

Since this does not affect gameplay, I'm fine with it even without researching the concepts. However in general you can make my job a lot easier by linking any ressources you used as reference (MC Wiki etc.) so I don't have to do the research work again. This is something that this PR demonstrates very well.

`--TODO: enable this code then Fleckenstein's pr get merged (in about 5-6 years)` Maybe link the PR you're referencing here in the comment. Since this does not affect gameplay, I'm fine with it even without researching the concepts. However in general you can make my job a lot easier by linking any ressources you used as reference (MC Wiki etc.) so I don't have to do the research work again. This is something that this PR demonstrates very well.

LizzyFleckenstein03 approved these changes 2021-06-04 19:59:44 +02:00

AFCMS added 1 commit 2021-06-07 20:09:19 +02:00

c642f9e2f7 Merge branch 'master' into title-API

AFCMS commented

2021-06-07 20:23:41 +02:00

Praticaly fixed layout

AFCMS commented

2021-06-07 21:58:25 +02:00

https://youtu.be/oVrtQRO2hpY

AFCMS commented

2021-06-07 22:02:16 +02:00

Just realize we should be able to colorize/stylise parts of the text...
I hate the minetest crappy HUD API

Just realize we should be able to colorize/stylise parts of the text... I hate the minetest crappy HUD API

AFCMS commented

2021-06-07 22:30:59 +02:00

@EliasFleckenstein03 The mc layout of actionbar collide with mcl_tmp_message and show_wielded_item :-/ Any idea how to fix?

@EliasFleckenstein03 The mc layout of actionbar collide with `mcl_tmp_message` and `show_wielded_item` :-/ Any idea how to fix?

screenshot_20210607_222356.png

472 KiB

AFCMS added 1 commit 2021-06-07 22:32:23 +02:00

2603c4768b mcl_title: basic mc like layout (collide with other mods)

LizzyFleckenstein03 commented

2021-06-08 13:01:27 +02:00

Maybe move the wielditem name, tmp message and title exactly to where they are on the minecraft screen.

AFCMS added 1 commit 2021-07-09 11:33:44 +02:00

cbfec5c5c8 Merge branch 'master' into title-API

AFCMS added 1 commit 2021-07-09 11:34:32 +02:00

8e931e92f5 refactor mcl_title to be more efficient

AFCMS requested review from LizzyFleckenstein03 2021-07-09 11:35:07 +02:00

AFCMS added 4 commits 2021-07-20 18:55:48 +02:00

999b82c94a small documentation graphical improvement

9254bab971 Merge branch 'master' into title-API

b5f7ae5458 working implementation + support of other mods

c31c852a6e add documentation

AFCMS added 1 commit 2021-07-20 20:47:21 +02:00

13536baed8 Merge branch 'master' into title-API

AFCMS added 1 commit 2021-07-21 18:21:26 +02:00

e58bb6d859 Merge branch 'master' into title-API

LizzyFleckenstein03 approved these changes 2021-08-06 11:49:26 +02:00

LizzyFleckenstein03 commented

2021-08-06 11:50:01 +02:00

Haven't checked your sources but I trust you here that it was properly researched.

❤️ 1

AFCMS commented

2021-08-07 19:07:17 +02:00

there is an small inconsistency in API, will fix soon and merge

AFCMS added 1 commit 2021-08-16 13:48:19 +02:00

58a292a4f3 fix inconsistency

AFCMS added 1 commit 2021-08-16 14:20:03 +02:00

40898d3e9d WIP bold and italic support

AFCMS requested review from LizzyFleckenstein03 2021-08-16 14:39:23 +02:00

AFCMS added 1 commit 2021-08-19 19:21:43 +02:00

df4b8e64cc finish `mcl_title` API + doc

AFCMS commented

2021-08-19 19:24:57 +02:00

I removed bold + italic support until the lowest version supported by mcl2 is 5.5
Because mt devs ARE DUMB. Who designed that **** error management???

I removed bold + italic support until the lowest version supported by mcl2 is 5.5 Because mt devs [ARE DUMB](https://github.com/minetest/minetest/issues/11539#issuecomment-899487262). Who designed that **** error management???

AFCMS changed title from ~~WIP: title mod~~ to Title HUD API

2021-08-19 19:31:16 +02:00

AFCMS merged commit 2d1a43396f into master

2021-08-20 14:31:57 +02:00

AFCMS referenced this issue from a commit

2021-08-20 14:31:59 +02:00

Merge pull request 'Title HUD API' (#1778) from title-API into master

AFCMS deleted branch title-API

2021-08-20 14:32:17 +02:00

Sign in to join this conversation.

No reviewers