Fix Stalker texture generation #4343

teknomunk · 2024-05-29T14:01:37+02:00

teknomunk commented

2024-05-29 14:01:37 +02:00

This fixes stalker texture generation when the stalker is standing on a node that uses a texture using a texture modifier.

Testing

Build the structure in the image.
Use /spawn_mob stalker to drop a stalker into this cage
Verify there is not error about a missing texture.

This fixes stalker texture generation when the stalker is standing on a node that uses a texture using a texture modifier. ### Testing 1. Build the structure in the image. 2. Use /spawn_mob stalker to drop a stalker into this cage 3. Verify there is not error about a missing texture.

Screenshot_2024-05-29_06-58-21.png

1.5 MiB

😆 1

teknomunk commented

2024-05-29 14:02:07 +02:00

This will fix one of the issues referenced in #4333 Some issues with the new update 0.87

teknomunk added this to the 0.87.1 milestone 2024-05-29 14:02:17 +02:00

teknomunk added the

#P3: elevated

label 2024-05-29 14:02:28 +02:00

the-real-herowl reviewed 2024-05-30 09:41:12 +02:00

mods/ENTITIES/mobs_mc/stalker.lua Outdated

					
				@ -134,1 +135,3 @@

						self.object:set_properties({textures={get_texture(self)}})

						local new_texture = get_texture(self)

						local old_texture = self._stalker_texture

						if not old_texture or old_texture ~= new_texture then

the-real-herowl commented

2024-05-30 09:39:51 +02:00

Why not just do

if self._stalker_texture ~= new_texture then

instead if this line and the previous one?

Why not just do ``` if self._stalker_texture ~= new_texture then ``` instead if this line and the previous one?

teknomunk commented

2024-05-30 12:46:02 +02:00

You are right in pointing this out. There shouldn't be a difference. I'm guessing it is habit from dealing with crashes from comparing numbers with possibly nil fields.

teknomunk commented

2024-05-30 13:02:04 +02:00

Now using your version instead.

teknomunk marked this conversation as resolved

mods/ENTITIES/mobs_mc/stalker.lua Outdated

					
				@ -135,0 +135,4 @@

						local new_texture = get_texture(self)

						local old_texture = self._stalker_texture

						if not old_texture or old_texture ~= new_texture then

							self.object:set_properties({textures={new_texture}})

the-real-herowl commented

2024-05-30 09:41:09 +02:00

The "2 mesh buffers" warning means it should get a second (blank) texture here, just like above, in the mob definition.

teknomunk commented

2024-05-30 13:00:47 +02:00

Updated this to use "mobs_mc_empty.png" like elsewhere in this file.

teknomunk marked this conversation as resolved

the-real-herowl added the

Testing / Retest

label 2024-05-30 10:53:40 +02:00

teknomunk force-pushed fix-stalker-texture-gen from fba255f3f6 to 7be8826c12

2024-05-30 12:56:29 +02:00

Compare

the-real-herowl requested changes 2024-05-30 13:24:25 +02:00

mods/ENTITIES/mobs_mc/stalker.lua Outdated

					
				@ -267,1 +272,3 @@

						self.object:set_properties({textures={get_texture(self), get_overloaded_aura(self._aura_timer)}})

						local new_texture = get_texture(self)

						if self._stalker_texture ~= new_texture then

							self.object:set_properties({textures={new_texture, get_overloaded_aura(self._aura_timer)}})

the-real-herowl commented

2024-05-30 13:24:17 +02:00

Actually, this one was OK.

Firstly, you're not setting self._stalker_texture at any point, so this does nothing.

Secondly, this should be updated every ~~frame~~ step, for the aura animation. Yeah, it is stupid that we have to do animations server-side.

Actually, this one was OK. Firstly, you're not setting `self._stalker_texture` at any point, so this does nothing. Secondly, this should be updated every ~~frame~~ step, for the aura animation. Yeah, it is stupid that we have to do animations server-side.

teknomunk commented

2024-05-30 13:35:41 +02:00

Give me a minute, I'll revert this one.

the-real-herowl marked this conversation as resolved

teknomunk force-pushed fix-stalker-texture-gen from 8de73a695b to de19549d04

2024-05-30 13:37:43 +02:00

Compare

the-real-herowl requested review from the-real-herowl 2024-05-30 13:49:42 +02:00

teknomunk force-pushed fix-stalker-texture-gen from de19549d04 to a256208e6b

2024-05-31 12:47:55 +02:00

Compare

the-real-herowl approved these changes 2024-06-01 22:23:17 +02:00