add copper nuggets and make lantern craftable #32

SmokeyDope · 2023-03-19T22:05:53+01:00

SmokeyDope commented

2023-03-19 22:05:53 +01:00

No description provided.

SmokeyDope added 4 commits 2023-03-19 22:05:56 +01:00

e7738e09f5 Add copper nugget texture

6199f1ecc7 delete copper nugget (wrong directory lol)

5f4eaa8e70 add copper nugget texture to right directory

9cce703968 Add copper nugget and make coppern lantern craftable

Ghost reviewed 2023-03-19 23:53:18 +01:00

mcl_copper_stuff/tools.lua

					
				@ -229,7 +229,7 @@ minetest.register_tool("mcl_copper_stuff:shears_copper", {

				})

				-- Copper Lantern

				mcl_lanterns.register_lantern("mcl_copper_stuff:copper_lantern", {

Ghost commented

2023-03-19 23:53:18 +01:00

First-time contributor

Why did you change this?

SmokeyDope commented

2023-03-20 00:02:13 +01:00

"mcl_copper_stuff:" had to be removed in order for the crafting recipe to work, I believe this is because the function mcl_lanterns.register_lantern is used instead of the regular minetest.register_node which classifies the copper lantern as part of the mcl_lantern set.

Notice the crafting recipe for the lantern:

-- copper lantern recipe
minetest.register_craft({
	output = "mcl_lanterns:copper_lantern_floor",
	recipe = {
		{"mcl_copper_stuff:copper_nugget", "mcl_copper_stuff:copper_nugget", "mcl_copper_stuff:copper_nugget"},
		{"mcl_copper_stuff:copper_nugget", "mcl_torches:torch"             , "mcl_copper_stuff:copper_nugget"},
		{"mcl_copper_stuff:copper_nugget", "mcl_copper_stuff:copper_nugget", "mcl_copper_stuff:copper_nugget"},
	},
})

"mcl_copper_stuff:" had to be removed in order for the crafting recipe to work, I believe this is because the function mcl_lanterns.register_lantern is used instead of the regular minetest.register_node which classifies the copper lantern as part of the mcl_lantern set. Notice the crafting recipe for the lantern: ``` -- copper lantern recipe minetest.register_craft({ output = "mcl_lanterns:copper_lantern_floor", recipe = { {"mcl_copper_stuff:copper_nugget", "mcl_copper_stuff:copper_nugget", "mcl_copper_stuff:copper_nugget"}, {"mcl_copper_stuff:copper_nugget", "mcl_torches:torch" , "mcl_copper_stuff:copper_nugget"}, {"mcl_copper_stuff:copper_nugget", "mcl_copper_stuff:copper_nugget", "mcl_copper_stuff:copper_nugget"}, }, }) ```

Ghost marked this conversation as resolved

Ghost approved these changes 2023-03-22 03:05:19 +01:00

Ghost left a comment

First-time contributor

Works, looks good to me.

Ghost merged commit 7547c927d0 into master

2023-03-22 03:05:55 +01:00

Ghost referenced this issue from a commit

2023-03-22 03:05:56 +01:00

Merge pull request 'add copper nuggets and make lantern craftable' (#32) from add-copper-lantern-recipe into master

Ghost deleted branch add-copper-lantern-recipe

2023-03-22 03:05:57 +01:00