WIP: mcl_rose_gold #20

Closed
SmokeyDope wants to merge 13 commits from mcl_rose_gold into master
Member

This is everything i've done for rose gold so far. Many basic things still need to be added like crafting recipes. Any contributions to this would be much appreciated.

For more information/discussion on rose gold see #14

Decorative items to be added

  • Rose gold block

  • Rose gold ingot

  • Rose gold nugget

  • Rose gold Lantern

  • Rose gold block slabs

  • Rose gold block stairs

  • Rose gold fences

  • Rose gold bars

  • Rose gold chains

Oxidation blocks to be added

  • Waxed Rose gold block

  • Exposed Rose gold block

  • Waxed exposed rose gold block

  • Weathered rose gold block

  • Waxed weathered rose gold block

  • Oxidized rose gold block

  • Waxed oxidized rose gold block

Tools to be added

  • Rose gold pickaxe

  • Rose gold axe

  • Rose gold shovel

  • rose gold sword

  • Rose gold hoe

Armor to be added

  • Rose gold helmet

  • Rose gold chestplate

  • Rose gold leggings

  • rose gold boots

This is everything i've done for rose gold so far. Many basic things still need to be added like crafting recipes. Any contributions to this would be much appreciated. For more information/discussion on rose gold see #14 ### Decorative items to be added - [x] Rose gold block - [x] Rose gold ingot - [x] Rose gold nugget - [x] Rose gold Lantern - [ ] Rose gold block slabs - [ ] Rose gold block stairs - [ ] Rose gold fences - [ ] Rose gold bars - [ ] Rose gold chains ### Oxidation blocks to be added - [x] Waxed Rose gold block - [x] Exposed Rose gold block - [x] Waxed exposed rose gold block - [ ] Weathered rose gold block - [ ] Waxed weathered rose gold block - [ ] Oxidized rose gold block - [ ] Waxed oxidized rose gold block ### Tools to be added - [x] Rose gold pickaxe - [x] Rose gold axe - [x] Rose gold shovel - [x] rose gold sword - [x] Rose gold hoe ### Armor to be added - [ ] Rose gold helmet - [ ] Rose gold chestplate - [ ] Rose gold leggings - [ ] rose gold boots
SmokeyDope added 3 commits 2023-02-14 22:56:46 +01:00
SmokeyDope added 1 commit 2023-02-14 23:00:44 +01:00
Author
Member

@Michieal when you get some free time can you please check over and update the oxidation stuff in init.lua to conform to your new version of it?

@Michieal when you get some free time can you please check over and update the oxidation stuff in init.lua to conform to your new version of it?
First-time contributor

I think I need to write some documentation on the new way scraping and waxing works. Edit: Oh, I see Smokey already knows.

I think I need to write some documentation on the new way scraping and waxing works. Edit: Oh, I see Smokey already knows.
Member

I think I need to write some documentation on the new way scraping and waxing works. Edit: Oh, I see Smokey already knows.

Yeah, I should have done that when I added it. Should change the word "copper" in the waxing variable check.

@Michieal when you get some free time can you please check over and update the oxidation stuff in init.lua to conform to your new version of it?

I'll download the branch now, and see where I can help out. :)

> I think I need to write some documentation on the new way scraping and waxing works. Edit: Oh, I see Smokey already knows. Yeah, I should have done that when I added it. Should change the word "copper" in the waxing variable check. > @Michieal when you get some free time can you please check over and update the oxidation stuff in init.lua to conform to your new version of it? I'll download the branch now, and see where I can help out. :)
Member

I made the oxidization into an API with it's own mod. See this PR. Basically, it's a centralized spot for the ABM so that we don't have to hunt down instances if something goes wonky, or there are performance issues.

Okay, yeah. It's apparently much, much different with the recent changes. For example, here's an example of a copper node that oxidizes and scrapes oxidization.

[EDITED] The following shows all of the variant variables... (waxed, oxidized, scraped)

minetest.register_node("mcl_copper:block_exposed_cut", {
	description = S("Exposed Cut Copper"),
	_doc_items_longdesc = S("Exposed cut copper is a decorative block."),
	tiles = {"mcl_copper_exposed_cut.png"},
	is_ground_content = false,
	groups = {pickaxey = 2, building_block = 1},
	sounds = mcl_sounds.node_sound_metal_defaults(),
	_mcl_blast_resistance = 6,
	_mcl_hardness = 5,
	_mcl_waxed_variant = "mcl_copper:waxed_block_exposed_cut",
	_mcl_oxidized_variant = "mcl_copper:block_cut_weathered",
	_mcl_stripped_variant = "mcl_copper:block_cut",
})

I kinda feel like a surgeon looking at the code. "Cut this piece out, move this piece here, sew it all up." lmao.

I made the oxidization into an API with it's own mod. [See this PR.](https://git.minetest.land/MineClone2/MineClone2/pulls/3454) Basically, it's a centralized spot for the ABM so that we don't have to hunt down instances if something goes wonky, or there are performance issues. Okay, yeah. It's apparently much, much different with the recent changes. For example, here's an example of a copper node that oxidizes and scrapes oxidization. [EDITED] The following shows all of the variant variables... (waxed, oxidized, scraped) ```lua minetest.register_node("mcl_copper:block_exposed_cut", { description = S("Exposed Cut Copper"), _doc_items_longdesc = S("Exposed cut copper is a decorative block."), tiles = {"mcl_copper_exposed_cut.png"}, is_ground_content = false, groups = {pickaxey = 2, building_block = 1}, sounds = mcl_sounds.node_sound_metal_defaults(), _mcl_blast_resistance = 6, _mcl_hardness = 5, _mcl_waxed_variant = "mcl_copper:waxed_block_exposed_cut", _mcl_oxidized_variant = "mcl_copper:block_cut_weathered", _mcl_stripped_variant = "mcl_copper:block_cut", }) ``` I kinda feel like a surgeon looking at the code. "Cut this piece out, move this piece here, sew it all up." lmao.
Michieal added 1 commit 2023-02-15 08:53:55 +01:00
Member

Once the oxidization PR is merged, update to that copy of Master Branch, and use mcl_copper for example code.

Once the oxidization PR is merged, update to that copy of Master Branch, and use `mcl_copper` for example code.
SmokeyDope added 1 commit 2023-03-19 00:51:45 +01:00
SmokeyDope added 1 commit 2023-03-23 20:45:52 +01:00
873807c3d0 delete rose gold lantern texture
some pixels needed fixing
SmokeyDope added 1 commit 2023-03-23 20:46:16 +01:00
SmokeyDope added 1 commit 2023-03-25 18:21:20 +01:00
SmokeyDope added 1 commit 2023-03-25 18:23:59 +01:00
SmokeyDope added 1 commit 2023-03-25 22:50:21 +01:00
SmokeyDope added 1 commit 2023-03-25 22:50:47 +01:00
SmokeyDope added 1 commit 2023-03-25 22:55:19 +01:00
SmokeyDope closed this pull request 2023-05-03 19:46:34 +02:00
Member

@SmokeyDope why was this closed?

@SmokeyDope why was this closed?
Author
Member
@michieal https://git.minetest.land/MineClone2/MineClone2-Plus/issues/39 https://git.minetest.land/MineClone2/MineClone2-Plus/pulls/37

Pull request closed

Sign in to join this conversation.
No description provided.