𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟 MrRar
MrRar commented on pull request VoxeLibre/VoxeLibre#4178 2024-03-21 01:18:30 +01:00
Fix a crash with rocket explosion

Seems like a Minetest bug?

minetest.get_objects_inside_radius() is giving invalid object refs. I guess this was triggered by entities being removed from the mcl_explosions.explode(p,…

MrRar deleted branch fix_rocket_crash from VoxeLibre/VoxeLibre 2024-03-21 01:16:02 +01:00
MrRar pushed to master at VoxeLibre/VoxeLibre 2024-03-21 01:15:53 +01:00
e50ad7d6de Merge pull request 'Fix a crash with rocket explosion' (#4178) from fix_rocket_crash into master
4b6d63739c Fix a crash with rocket explosion
Compare 2 commits »
MrRar merged pull request VoxeLibre/VoxeLibre#4178 2024-03-21 01:15:52 +01:00
Fix a crash with rocket explosion
MrRar pushed to fix_rocket_crash at VoxeLibre/VoxeLibre 2024-03-21 01:14:50 +01:00
4b6d63739c Fix a crash with rocket explosion
21dbc25f13 Improve french translation (#4194)
Compare 2 commits »
MrRar approved VoxeLibre/VoxeLibre#4178 2024-03-21 01:13:18 +01:00
Fix a crash with rocket explosion

Looks good. I still think it's a Minetest bug BTW.

MrRar commented on pull request VoxeLibre/VoxeLibre#4180 2024-03-20 04:37:28 +01:00
Fix crash with cape when player has default skin

I was able to reproduce this crash. Kill yourself then close the game without clicking respawn. Then open the game and go into the same world.

Instead of modifying mcl_skins, delete…

MrRar commented on pull request VoxeLibre/VoxeLibre#4178 2024-03-20 04:33:42 +01:00
Fix a crash with rocket explosion

Seems like a Minetest bug?

minetest.get_objects_inside_radius() is giving invalid object refs. I guess this was triggered by entities being removed from the mcl_explosions.explode(p, 3, {}) call.

MrRar commented on pull request VoxeLibre/VoxeLibre#4180 2024-03-20 03:32:26 +01:00
Fix crash with cape when player has default skin

I was able to reproduce this crash. Kill yourself then close the game without clicking respawn. Then open the game and go into the same world.

Instead of modifying mcl_skins, delete the…

MrRar commented on pull request VoxeLibre/VoxeLibre#4180 2024-03-20 03:19:34 +01:00
Fix crash with cape when player has default skin

I wonder why player_plus cares if the player joins with 0 HP. mcl_player_plus is calling player:respawn() from on_joinplayer before mcl_skins has initialized player data.

MrRar commented on pull request VoxeLibre/VoxeLibre#4216 2024-03-20 02:40:04 +01:00
Fix - New game load crashes. Add defensive check.

I wasn't able to reproduce this. I tried creating a new singlenode world with Animalia enabled. This seems like an impossible bug. mcl_hunger.eat_internal[name] get setup in register_on_joinplayer.…

MrRar commented on pull request VoxeLibre/VoxeLibre#4147 2024-01-20 14:58:56 +01:00
Fix Survival Inventory Tab API

This is going to break a lot of stuff. Lots of mods use minetest.is_creative_enabled() with no argument. MCL2 has no business modifying the behavior of Minetest APIs in my opinion.

MrRar commented on pull request VoxeLibre/VoxeLibre#4134 2024-01-11 21:16:45 +01:00
Fix mcl_shields is_blocking crash when object not found under player

It's unclear to me what sort of a crash this could fix. Could you share an example crash call trace?

MrRar deleted branch player_crash_fix from VoxeLibre/VoxeLibre 2024-01-11 21:00:17 +01:00
MrRar pushed to master at VoxeLibre/VoxeLibre 2024-01-11 21:00:06 +01:00
c1115c9cef Merge pull request 'Fixed an invalid player object crash' (#4131) from player_crash_fix into master
12b3e34f88 Fix a crash
Compare 2 commits »
MrRar merged pull request VoxeLibre/VoxeLibre#4131 2024-01-11 21:00:05 +01:00
Fixed an invalid player object crash
MrRar commented on pull request VoxeLibre/VoxeLibre#4131 2024-01-11 20:54:28 +01:00
Fixed an invalid player object crash

The whole idea of setting player metadata for a damage animation is a bad idea. Player metadata hits the disk.

MrRar commented on pull request VoxeLibre/VoxeLibre#4108 2024-01-11 20:47:42 +01:00
Show elytra animation when using elytra

Ready for review

MrRar pushed to elytra at VoxeLibre/VoxeLibre 2024-01-11 20:46:09 +01:00
9b9a18c6b0 Show elytra animation when using elytra
59c5d54cbe Merge pull request 'Add and fix some german translations' (#4132) from Tuxilio/MineClone2:german-translation into master
4b5afee4bb Add and fix some german translations
3c2247d7c8 Merge pull request 'mobs:piglin: use (alt) zombified piglin sounds' (#4083) from Bakawun/MineClone2:piglin_sounds into master
324fd0dc4a Merge pull request 'Add missing Hoglin/Zoglin sounds' (#4082) from Bakawun/MineClone2:hoglin_sounds into master
Compare 89 commits »