Mineclonia
/
mcl_meshnode
7
0
Fork 0
Code Issues 2 Pull Requests Projects Releases Wiki Activity

Expose settings in Minetest settings GUI #12

Merged
erlehmann merged 1 commits from add-settingtypes into master 2021-08-30 03:11:11 +02:00
Conversation 0 Commits 1 Files Changed 1 +9
erlehmann commented 2021-08-30 02:36:55 +02:00
Owner
Copy Link

Issue: #11

Instructions written by @cora:

This makes the settings visible in the settingsgui by adding a settingtypes.txt file to the mod.

verify bug

  1. remove all lines starting with meshnode_ from your minetest.conf
    2.start minetest with meshnode on commit 5042cbbc1c
  2. in the advanced settings menu observe that no meshnode settings are there

test fix

  1. (re)start minetest with meshnode on commit caad057e4c
  2. go to advanced settings and enable "technical names"
  3. verify that the following settings are present under mods/meshnode:
  • max_speed
  • max_lift
  • yaw_amount
  • max_radius
  • show_in_creative
  • enable_crafting
  • disable_privilege
  • fake_shading
  • autoconf
Issue: https://git.minetest.land/Mineclonia/mcl_meshnode/issues/11 Instructions written by @cora: This makes the settings visible in the settingsgui by adding a settingtypes.txt file to the mod. ## verify bug 1. remove all lines starting with meshnode_ from your minetest.conf 2.start minetest with meshnode on commit 5042cbbc1c 3. in the advanced settings menu observe that no meshnode settings are there ## test fix 1. (re)start minetest with meshnode on commit caad057e4c 2. go to advanced settings and enable "technical names" 3. verify that the following settings are present under mods/meshnode: * max_speed * max_lift * yaw_amount * max_radius * show_in_creative * enable_crafting * disable_privilege * fake_shading * autoconf
minetest-mod-mcl_meshnode-settingtypes.png
24 KiB
minetest-mod-mcl_meshnode-settingtypes.png
erlehmann force-pushed add-settingtypes from 8b0e46723b to caad057e4c 2021-08-30 02:39:06 +02:00 Compare
cora approved these changes 2021-08-30 02:53:20 +02:00
cora left a comment
Member
Copy Link

verify bug

  • 1. remove all lines starting with meshnode_ from your minetest.conf
  • 2.start minetest with meshnode on commit 5042cbbc1c
  • 3. in the advanced settins menu observe that no meshnode settings are there

test fix

  • 1. (re)start minetest with meshnode on commit caad057e4c
  • 2. go to advanced settings and enable "technical names"
  • 3. verify that the following settings are present under mods/meshnode:
  • * max_speed
  • * max_lift
  • * yaw_amount
  • * max_radius
  • * show_in_creative
  • * enable_crafting
  • * disable_privilege
  • * fake_shading
    (- ) * autoconf - autoconf reproducibly doesnt show up the first time i start the game - if i exit and restart it is there however
## verify bug - [x] 1. remove all lines starting with meshnode_ from your minetest.conf - [x] 2.start minetest with meshnode on commit 5042cbbc1c - [x] 3. in the advanced settins menu observe that no meshnode settings are there ## test fix - [x] 1. (re)start minetest with meshnode on commit caad057e4c - [x] 2. go to advanced settings and enable "technical names" - [x] 3. verify that the following settings are present under mods/meshnode: - [x] * max_speed - [x] * max_lift - [x] * yaw_amount - [x] * max_radius - [x] * show_in_creative - [x] * enable_crafting - [x] * disable_privilege - [x] * fake_shading (- [x] ) * autoconf - autoconf reproducibly doesnt show up the first time i start the game - if i exit and restart it is there however
erlehmann merged commit e9dd34eea0 into master 2021-08-30 03:11:11 +02:00
erlehmann deleted branch add-settingtypes 2021-08-30 03:11:35 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
cora
Labels
Clear labels
  
in review

   
ready for review
No Label
in review
ready for review
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Mineclonia/mcl_meshnode#12
No description provided.
Delete Branch "add-settingtypes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?