Mineclonia
/
Mineclonia
Archived
12
17
Fork 13
Code Issues 105 Pull Requests 19 Projects Releases Wiki Activity

ITEMS/screwdriver: Show screwdriver in creative inventory #99

Merged
cora merged 1 commits from show-screwdriver-in-creative-inventory into master 2021-06-22 00:44:00 +02:00
Conversation 0 Commits 1 Files Changed 1 +1 -1
erlehmann commented 2021-06-22 00:20:08 +02:00
Owner
Copy Link
Problem

TRACKING ISSUE: #98

This patch makes the screwdriver show up in the creative inventory.

Solution

The patch removes the group not_in_creative_inventory = 1 from the screwdriver item.

Details

It doess not get more complex than that.

Testing Steps
Verify Bug
  1. With Mineclonia commit 87761bf454, enter a world in creative mode.
  2. Open your inventory.
  3. Enter "screwdriver" in the search field.
  4. Verify that there are no results.
Verify Patch
  1. With Mineclonia commit 0b92dc1f26, enter a world in creative mode.
  2. Open your inventory.
  3. Enter "screwdriver" in the search field.
  4. Verify that there is one result, the screwdriver.
  5. Click on the tab icon with the iron axe to get to the “tool” category.
  6. Verify that the creative inventory “tool” category contains the screwdriver.
To do
  • Fill out template
  • Create testing intructions
  • Verify testing instructions
##### Problem TRACKING ISSUE: https://git.minetest.land/Mineclonia/Mineclonia/issues/98 This patch makes the screwdriver show up in the creative inventory. ##### Solution The patch removes the group `not_in_creative_inventory = 1` from the screwdriver item. ##### Details It doess not get more complex than that. ##### Testing Steps ##### Verify Bug 1. With Mineclonia commit 87761bf454c22be95325509f592fd26d0ee02949, enter a world in creative mode. 2. Open your inventory. 3. Enter "screwdriver" in the search field. 4. *Verify that there are no results.* ##### Verify Patch 1. With Mineclonia commit 0b92dc1f2644f0aaeecd794a26155927762ccd28, enter a world in creative mode. 2. Open your inventory. 3. Enter "screwdriver" in the search field. 4. *Verify that there is one result, the screwdriver.* 5. Click on the tab icon with the iron axe to get to the “tool” category. 6. *Verify that the creative inventory “tool” category contains the screwdriver.* ##### To do - [x] Fill out template - [x] Create testing intructions - [x] Verify testing instructions
erlehmann added 1 commit 2021-06-22 00:20:10 +02:00
erlehmann changed title from WIP: ITEMS/screwdriver: Show screwdriver in creative inventory to ITEMS/screwdriver: Show screwdriver in creative inventory 2021-06-22 00:34:01 +02:00
cora approved these changes 2021-06-22 00:43:43 +02:00
cora left a comment
Member

Verify Bug

  • With Mineclonia commit 87761bf454, enter a world in creative mode.
  • Open your inventory.
  • Enter "screwdriver" in the search field.
  • Verify that there are no results.

Verify Patch

  • With Mineclonia commit 0b92dc1f26, enter a world in creative mode.
  • Open your inventory.
  • Enter "screwdriver" in the search field.
  • Verify that there is one result, the screwdriver.*
  • Click on the tab icon with the iron axe to get to the “tool” category.
  • Verify that the creative inventory tools category contains the screwdriver.
### Verify Bug - [x] With Mineclonia commit 87761bf454, enter a world in creative mode. - [x] Open your inventory. - [x] Enter "screwdriver" in the search field. - [x] Verify that there are no results. ### Verify Patch - [x] With Mineclonia commit 0b92dc1f26, enter a world in creative mode. - [x] Open your inventory. - [x] Enter "screwdriver" in the search field. - [x] Verify that there is one result, the screwdriver.* - [x] Click on the tab icon with the iron axe to get to the “tool” category. - [x] Verify that the creative inventory tools category contains the screwdriver.
cora merged commit 0816ee38b4 into master 2021-06-22 00:44:00 +02:00
erlehmann deleted branch show-screwdriver-in-creative-inventory 2021-06-22 00:46:17 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
cora
Labels
Clear labels   
blocker

blocks release until resolved

  
bug

   
code quality

   
confirmed

   
critical

crashes, catastrophic bugs

  
discussion

   
high priority

   
incompatibility

incompatible with mcl2

  
incomplete feature

   
invalid

   
low priority

   
missing feauture

   
needs testing

   
packet spam

   
performance

   
project

meta-issues

  
regression

   
translations

   
unconfirmed
  
in review

   
ready for review
No Label
blocker
bug
code quality
confirmed
critical
discussion
high priority
incompatibility
incomplete feature
invalid
low priority
missing feauture
needs testing
packet spam
performance
project
regression
translations
unconfirmed
in review
ready for review
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Mineclonia/Mineclonia#99
No description provided.
Delete Branch "show-screwdriver-in-creative-inventory"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?