Mineclonia
/
Mineclonia
Archived
12
17
Fork 13
Code Issues 105 Pull Requests 19 Projects Releases Wiki Activity

mesecons: Do not crash server if world border is depowered #79

Merged
cora merged 1 commits from fix-issue-78 into master 2021-05-30 00:29:52 +02:00
Conversation 1 Commits 1 Files Changed 1 +7 -5
ryvnf commented 2021-05-28 19:27:44 +02:00
Owner
Copy Link
Problem

TRACKING ISSUE: #78

Solution

Check node for nil.

Details

The same fix applied in MineClone2.

Testing Steps
  1. Put lever at world border
  2. Flip it on and off
  3. Server should not crash
##### Problem TRACKING ISSUE: #78 ##### Solution Check node for nil. ##### Details The same fix applied in MineClone2. ##### Testing Steps 1. Put lever at world border 2. Flip it on and off 3. Server should not crash
ryvnf added 1 commit 2021-05-28 19:27:46 +02:00
ryvnf added the
bug
critical
 labels 2021-05-28 19:28:34 +02:00
erlehmann commented 2021-05-29 23:34:12 +02:00
Owner
Copy Link
More specific testing steps

On commit fac4a38657 …

  • Generate a new world with mapgen v7, with the seed “test_crashbutton” and only the following mapgen options enabled: Caves, Dungeons, Decorations, Caverns, Ravines, Mountains.

  • Start a singleplayer game in that world in survival mode (creative mode flag unchecked) with damage enabled (Enable damage).

  • In the game console, type "/grantme all" and press enter.

  • In the game console, type “/teleport 30927,2,0” and press enter.

  • In the game console, type “/give singleplayer mesecons_button:button_stone_off”.

  • Place the button on the sand directly below you.

  • Press the button. The game should crash one second later. You should see a traceback.

On commit 27828b6317 …

  • Start a singleplayer game in the world you created before.

  • Press the button. The game should not crash one second later.

##### More specific testing steps On commit fac4a386574564e95111e719120a794f8f9f3b4b … - Generate a new world with mapgen v7, with the seed “test_crashbutton” and only the following mapgen options enabled: Caves, Dungeons, Decorations, Caverns, Ravines, Mountains. - Start a singleplayer game in that world in survival mode (creative mode flag unchecked) with damage enabled (Enable damage). - In the game console, type "/grantme all" and press enter. - In the game console, type “/teleport 30927,2,0” and press enter. - In the game console, type “/give singleplayer mesecons_button:button_stone_off”. - Place the button on the sand directly below you. - Press the button. The game should crash one second later. You should see a traceback. On commit 27828b6317f5f509588b2c5482109fc504bfb02a … - Start a singleplayer game in the world you created before. - Press the button. The game should not crash one second later.
cora approved these changes 2021-05-30 00:19:02 +02:00
Dismissed
cora left a comment
Member
More specific testing steps

On commit fac4a38657 …

  • Generate a new world with mapgen v7, with the seed “test_crashbutton” and only the following mapgen options enabled: Caves, Dungeons, Decorations, Caverns, Ravines, Mountains.

  • Start a singleplayer game in that world in survival mode (creative mode flag unchecked) with damage enabled (Enable damage).

  • In the game console, type "/grantme all" and press enter.

  • In the game console, type “/teleport 30927,2,0” and press enter.

  • In the game console, type “/give singleplayer mesecons_button:button_stone_off”.

  • Place the button on the sand directly below you.

  • Press the button. The game should crash one second later. You should see a traceback.

On commit 27828b6317 …

  • Start a singleplayer game in the world you created before.

  • Press the button. The game should not crash one second later.

Everything works as expected i.e. the game does not crash after applying the fix.

##### More specific testing steps On commit fac4a386574564e95111e719120a794f8f9f3b4b … - Generate a new world with mapgen v7, with the seed “test_crashbutton” and only the following mapgen options enabled: Caves, Dungeons, Decorations, Caverns, Ravines, Mountains. [x] - Start a singleplayer game in that world in survival mode (creative mode flag unchecked) with damage enabled (Enable damage). [x] - In the game console, type "/grantme all" and press enter. [x] - In the game console, type “/teleport 30927,2,0” and press enter. [x] - In the game console, type “/give singleplayer mesecons_button:button_stone_off”. [x] - Place the button on the sand directly below you. [x] - Press the button. The game should crash one second later. You should see a traceback. [x] On commit 27828b6317f5f509588b2c5482109fc504bfb02a … - Start a singleplayer game in the world you created before. [x] - Press the button. The game should not crash one second later. [x] Everything works as expected i.e. the game does not crash after applying the fix.
cora dismissed cora’s review 2021-05-30 00:22:30 +02:00
Reason:

I have done it wrong - bad cora

cora approved these changes 2021-05-30 00:25:20 +02:00
cora left a comment
Member
More specific testing steps

On commit fac4a38657 …

  • Generate a new world with mapgen v7, with the seed “test_crashbutton” and only the following mapgen options enabled: Caves, Dungeons, Decorations, Caverns, Ravines, Mountains.

  • Start a singleplayer game in that world in survival mode (creative mode flag unchecked) with damage enabled (Enable damage).

  • In the game console, type "/grantme all" and press enter.

  • In the game console, type “/teleport 30927,2,0” and press enter.

  • In the game console, type “/give singleplayer mesecons_button:button_stone_off”.

  • Place the button on the sand directly below you.

  • Press the button. The game should crash one second later. You should see a traceback.

On commit 27828b6317 …

  • Start a singleplayer game in the world you created before.

  • Press the button. The game should not crash one second later.

Everything works out as expected: Crash without and no crash with the fix.

##### More specific testing steps On commit fac4a386574564e95111e719120a794f8f9f3b4b … - [x] Generate a new world with mapgen v7, with the seed “test_crashbutton” and only the following mapgen options enabled: Caves, Dungeons, Decorations, Caverns, Ravines, Mountains. - [x] Start a singleplayer game in that world in survival mode (creative mode flag unchecked) with damage enabled (Enable damage). - [x] In the game console, type "/grantme all" and press enter. - [x] In the game console, type “/teleport 30927,2,0” and press enter. - [x] In the game console, type “/give singleplayer mesecons_button:button_stone_off”. - [x] Place the button on the sand directly below you. - [x] Press the button. The game should crash one second later. You should see a traceback. On commit 27828b6317f5f509588b2c5482109fc504bfb02a … - [x] Start a singleplayer game in the world you created before. - [x] Press the button. The game should not crash one second later. Everything works out as expected: Crash without and no crash with the fix.
cora merged commit 3ee2ef0618 into master 2021-05-30 00:29:52 +02:00
cora deleted branch fix-issue-78 2021-05-30 00:31:28 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
cora
Labels
Clear labels   
blocker

blocks release until resolved

  
bug

   
code quality

   
confirmed

   
critical

crashes, catastrophic bugs

  
discussion

   
high priority

   
incompatibility

incompatible with mcl2

  
incomplete feature

   
invalid

   
low priority

   
missing feauture

   
needs testing

   
packet spam

   
performance

   
project

meta-issues

  
regression

   
translations

   
unconfirmed
  
in review

   
ready for review
No Label
blocker
bug
code quality
confirmed
critical
discussion
high priority
incompatibility
incomplete feature
invalid
low priority
missing feauture
needs testing
packet spam
performance
project
regression
translations
unconfirmed
in review
ready for review
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Mineclonia/Mineclonia#79
No description provided.
Delete Branch "fix-issue-78"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?