Mineclonia
/
Mineclonia
Archived
12
17
Fork 13
Code Issues 105 Pull Requests 19 Projects Releases Wiki Activity

Render preview banners with transparent patterns correctly #72

Closed
erlehmann wants to merge 3 commits from banner-mask-fix-3 into master
pull from: banner-mask-fix-3
merge into: Mineclonia:master
Conversation 10 Commits 3 Files Changed 1 +4 -2
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mods/ITEMS/mcl_banners/init.lua
View File

@ -387,13 +387,15 @@ for colorid, colortab in pairs(mcl_banners.colors) do
-- redraw the pattern textures as low-resolution pixel
-- art and use that instead.
local layer = "(([combine:20x40:-2,-2="..pattern.."^[resize:16x24^[colorize:"..color..":"..layer_ratio.."))"
local layer = "(([combine:20x40:-2,-2=" .. pattern .. "^[resize:16x24^[colorize:" .. color .. ":" .. layer_ratio .. "))"
local mask = "(([combine:20x40:-2,-2=" .. pattern .. "^[resize:16x24" .. "))"
e commented 2021-05-19 02:32:52 +02:00
Review
Copy Link

I don't think it's necessary to use two parentheses for either layer or mask here. Probably not worth a commit to fix them, though.

I don't think it's necessary to use two parentheses for either `layer` or `mask` here. Probably not worth a commit to fix them, though.
erlehmann commented 2021-05-30 01:20:16 +02:00
Review
Copy Link

Please elaborate on that and propose an alternative. I just cargo culted it until it worked.

Please elaborate on that and propose an alternative. I just cargo culted it until it worked.
e commented 2021-05-30 01:58:20 +02:00
Review
Copy Link

layer and mask both start with (( and end with )), despite having no intervening parentheses, meaning (at least) one pair of parens is unneeded.

`layer` and `mask` both start with `((` and end with `))`, despite having no intervening parentheses, meaning (at least) one pair of parens is unneeded.
function escape(text)
return text:gsub("%^", "\\%^"):gsub(":", "\\:") -- :gsub("%(", "\\%("):gsub("%)", "\\%)")
end
finished_banner = "[combine:32x32:0,0=" .. escape(base) .. ":8,4=" .. escape(layer)
local layer_masked = layer .. "^[mask:" .. escape(mask)
finished_banner = "[combine:32x32:0,0=" .. escape(base) .. ":8,4=" .. escape(layer_masked)
end
inv = finished_banner