Mineclonia
/
Mineclonia
Archived
12
17
Fork 13
Code Issues 105 Pull Requests 19 Projects Releases Wiki Activity

Remove wrong preview banner crafting recipes #55

Merged
erlehmann merged 1 commits from banner-crafting-fix into master 2021-05-03 16:30:49 +02:00
Conversation 5 Commits 1 Files Changed 1 +1 -1
erlehmann commented 2021-05-02 13:06:18 +02:00
Owner
Copy Link

In commit ac5f115f83, preview banners were introduced and given
crafting recipes. Those crafting recipes were the same as for banners without a pattern. That
change made banners without patterns uncraftable and preview banners craftable instead – this
patch makes banners without patterns craftable again and preview banners uncraftable.

In commit ac5f115f83e0c1f8c1fa7d8d01a801e467bf2fea, preview banners were introduced and given crafting recipes. Those crafting recipes were the same as for banners without a pattern. That change made banners without patterns uncraftable and preview banners craftable instead – this patch makes banners without patterns craftable again and preview banners uncraftable.
erlehmann added 1 commit 2021-05-02 13:06:19 +02:00
ee9f49b86e
Remove wrong preview banner crafting recipes 
In commit ac5f115f83, preview banners were introduced and given
crafting recipes. Those crafting recipes were the same as for banners without a pattern. That
change made banners without patterns uncraftable and preview banners craftable instead – this
patch makes banners without patterns craftable again and preview banners uncraftable.
erlehmann commented 2021-05-02 13:13:23 +02:00
Author
Owner
Copy Link

How to test

  1. With and without this patch applied, try crafting banners on a crafting table with 6 colored wool and a stick. Without this patch applied, you should get a preview banner with three triangles at the top in the color of the colored wool that you used. With this batch applied, you should get a banner without a pattern that has one single color (the color of the wool used).

  2. With this patch applied try crafting banners with patterns on a crafting table. A preview banner should appear in the crafting result preview field of the crafting table. The preview banner should have a light gray background with a downscaled version of the new banner pattern.

  3. With this patch applied, verify that the preview is correct by actually crafting the banner and placing it in the world.

The above instructions should be tried for at least:

  • a banner pattern that has a solid color
  • a banner pattern that results in a gradient
  • a banner pattern that involves an object, such as a flower or a creeper head
  • a banner pattern applied to a banner that already has a banner pattern applied to it
  1. With this patch applied, for each of the 16 colors of wool, verify in the crafting guide that no crafting recipes exist where 6 wool and a stick make a preview banner and that all 16 of those recipes result in solid color banners without a pattern and that the color of the banner is the color of the wool used.
How to test ----------- 1. With and without this patch applied, try crafting banners on a crafting table with 6 colored wool and a stick. Without this patch applied, you should get a preview banner with three triangles at the top in the color of the colored wool that you used. With this batch applied, you should get a banner without a pattern that has one single color (the color of the wool used). 2. With this patch applied try crafting banners with patterns on a crafting table. A preview banner should appear in the crafting result preview field of the crafting table. The preview banner should have a light gray background with a downscaled version of the new banner pattern. 3. With this patch applied, verify that the preview is correct by actually crafting the banner and placing it in the world. The above instructions should be tried for at least: - a banner pattern that has a solid color - a banner pattern that results in a gradient - a banner pattern that involves an object, such as a flower or a creeper head - a banner pattern applied to a banner that already has a banner pattern applied to it 4. With this patch applied, for each of the 16 colors of wool, verify in the crafting guide that no crafting recipes exist where 6 wool and a stick make a preview banner and that all 16 of those recipes result in solid color banners without a pattern and that the color of the banner is the color of the wool used.
Li0n added the
bug
 label 2021-05-02 15:55:58 +02:00
erlehmann requested review from e 2021-05-03 10:44:42 +02:00
e commented 2021-05-03 12:16:02 +02:00
Member
Copy Link

I can confirm the basic functionality of the patch (more extensive test results forthcoming), but I'm starting to have some questions on whether or not we're doing the right things with regards to banners as a whole.

I can confirm the basic functionality of the patch (more extensive test results forthcoming), but I'm starting to have some questions on whether or not we're doing the right things with regards to banners as a whole.
e commented 2021-05-03 12:29:01 +02:00
Member
Copy Link

Gradient patterns don't show up as gradients, and triangle_bottom has odd artifacts around it, but they seem to be a bugs with the overarching preview banner patch.

Gradient patterns don't show up as gradients, and `triangle_bottom` has odd artifacts around it, but they seem to be a bugs with the overarching preview banner patch.
Screenshot from 2021-05-03 06-28-06.png
6.0 KiB
Screenshot from 2021-05-03 06-27-55.png
6.1 KiB
Screenshot from 2021-05-03 06-28-06.png Screenshot from 2021-05-03 06-27-55.png
e commented 2021-05-03 12:37:21 +02:00
Member
Copy Link

The crafting guide behaves as expected.

The crafting guide behaves as expected.
e approved these changes 2021-05-03 12:42:15 +02:00
e left a comment
Member

Behaves as described, no unexpected behavior (that can be attributed to this patch) was identified during testing.

Behaves as described, no unexpected behavior (that can be attributed to this patch) was identified during testing.
erlehmann merged commit a9d4a85e9a into master 2021-05-03 16:30:49 +02:00
erlehmann commented 2021-06-22 22:11:05 +02:00
Author
Owner
Copy Link

@kay27 please cherry-pick this PR to mineclone2 or mineclone5 (after testing it), banners have been uncraftable for two months now in mineclone2 and mineclone5, it is a bit annoying.

@kay27 please cherry-pick this PR to mineclone2 or mineclone5 (after testing it), banners have been uncraftable for two months now in mineclone2 and mineclone5, it is a bit annoying.
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
e
Labels
Clear labels   
blocker

blocks release until resolved

  
bug

   
code quality

   
confirmed

   
critical

crashes, catastrophic bugs

  
discussion

   
high priority

   
incompatibility

incompatible with mcl2

  
incomplete feature

   
invalid

   
low priority

   
missing feauture

   
needs testing

   
packet spam

   
performance

   
project

meta-issues

  
regression

   
translations

   
unconfirmed
  
in review

   
ready for review
No Label
blocker
bug
code quality
confirmed
critical
discussion
high priority
incompatibility
incomplete feature
invalid
low priority
missing feauture
needs testing
packet spam
performance
project
regression
translations
unconfirmed
in review
ready for review
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Mineclonia/Mineclonia#55
No description provided.
Delete Branch "banner-crafting-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?