Mineclonia
/
Mineclonia
Archived
12
17
Fork 13
Code Issues 105 Pull Requests 19 Projects Releases Wiki Activity

mcl_explosions: Fix rays for node destruction not being cast in (+X, +Y, +Z) direction from explosion #50

Merged
ryvnf merged 2 commits from mcl_explosions into master 2021-05-18 18:07:10 +02:00
Conversation 0 Commits 2 Files Changed 1 +37 -39
ryvnf commented 2021-05-01 18:24:06 +02:00
Owner
Copy Link

A bug was introduced in 679e2b1b which caused explosions to not cast rays for environment destruction in the (+X, +Y, +Z) direction. This PR fixes that.

This PR closes issue #49. That issue also contains instructions for how to reproduce the bug. Use that to confirm the issue is fixed.

A bug was introduced in 679e2b1b which caused explosions to not cast rays for environment destruction in the (+X, +Y, +Z) direction. This PR fixes that. This PR closes issue #49. That issue also contains instructions for how to reproduce the bug. Use that to confirm the issue is fixed.
ryvnf added 1 commit 2021-05-01 18:24:07 +02:00
74d4986d1d Fix rays not being cast in a specific direction 
A bug was introduced in 679e2b1b which caused explosions to not cast
rays for environment destruction in the (+X, +Y, +Z) direction.  This
commit fixes that.
ryvnf added the
bug
 label 2021-05-01 18:24:21 +02:00
ryvnf changed title from Fix rays for node destruction not being cast in (+X, +Y, +Z) direction from explosion to mcl_explosions: Fix rays for node destruction not being cast in (+X, +Y, +Z) direction from explosion 2021-05-16 11:17:17 +02:00
ryvnf added this to the First Release milestone 2021-05-16 22:50:00 +02:00
cora approved these changes 2021-05-18 16:52:05 +02:00
cora left a comment
Member

I tested before and after in creative and survival:

The snow node marked in the screenshot is in fact not destroyed by the explosion.

With the PR applied it gets destroyed.

I tested before and after in creative and survival: The snow node marked in the screenshot is in fact not destroyed by the explosion. With the PR applied it gets destroyed.
ryvnf added 1 commit 2021-05-18 18:04:48 +02:00
ryvnf merged commit 4c61fc80c6 into master 2021-05-18 18:07:10 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
cora
Labels
Clear labels   
blocker

blocks release until resolved

  
bug

   
code quality

   
confirmed

   
critical

crashes, catastrophic bugs

  
discussion

   
high priority

   
incompatibility

incompatible with mcl2

  
incomplete feature

   
invalid

   
low priority

   
missing feauture

   
needs testing

   
packet spam

   
performance

   
project

meta-issues

  
regression

   
translations

   
unconfirmed
  
in review

   
ready for review
No Label
blocker
bug
code quality
confirmed
critical
discussion
high priority
incompatibility
incomplete feature
invalid
low priority
missing feauture
needs testing
packet spam
performance
project
regression
translations
unconfirmed
in review
ready for review
Milestone
Clear milestone
No items
No Milestone
First Release
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Mineclonia/Mineclonia#50
No description provided.
Delete Branch "mcl_explosions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?