Mineclonia
/
Mineclonia
Archived
12
17
Fork 13
Code Issues 105 Pull Requests 19 Projects Releases Wiki Activity

mapgen/mcl_mapgen_core: base mushrooms and nether decorations off block seed #43

Merged
erlehmann merged 1 commits from e/Mineclonia:mapgen-nondet into master 2021-05-02 01:41:13 +02:00
Conversation 5 Commits 1 Files Changed 1 +3 -2
e commented 2021-04-26 05:35:14 +02:00
Member
Copy Link

This patch fixes the nondeterministic steps identified in #41.

Testing

(borrowed from #29)

With and without this patch, do the following:

  1. Create a new world with the the v7 mapgen and the seed test_nether, and the flags “caves”, “dungeons”, “decorations” set to true.
  2. Grant yourself all permissions with the command /grantme all.
  3. Teleport with the command /teleport 1019,-29012,1019
  4. You should see a red mushroom to the west, and a netherwart to the east.
  5. Repeat steps 1 through 3.
  6. Confirm the red mushroom and netherwart are in the same location.
This patch fixes the nondeterministic steps identified in #41. ## Testing (borrowed from #29) With and without this patch, do the following: 1. Create a new world with the the v7 mapgen and the seed `test_nether`, and the flags “caves”, “dungeons”, “decorations” set to true. 2. Grant yourself all permissions with the command `/grantme all`. 3. Teleport with the command `/teleport 1019,-29012,1019` 4. You should see a red mushroom to the west, and a netherwart to the east. 5. Repeat steps 1 through 3. 6. Confirm the red mushroom and netherwart are in the same location.
e added 1 commit 2021-04-26 05:35:16 +02:00
Li0n added the
bug
 label 2021-04-26 19:56:53 +02:00
erlehmann commented 2021-04-29 09:23:05 +02:00
Owner
Copy Link

I have verified that with the patch there is a red mushroom to the west and Nether wart to the east at coordinates 1019,-29012,1019 – both time I generated a map with the seed "test_nether"

I have verified that without the patch there is no mushroom and Nether wart at the same coordinates.

I have verified that with the patch there is a red mushroom to the west and Nether wart to the east at coordinates 1019,-29012,1019 – both time I generated a map with the seed "test_nether" I have verified that without the patch there is no mushroom and Nether wart at the same coordinates.
erlehmann approved these changes 2021-04-29 09:24:16 +02:00
erlehmann left a comment
Owner

This patch makes placement of mushrooms and Nether wart deterministic, as promised.

This patch makes placement of mushrooms and Nether wart deterministic, as promised.
erlehmann commented 2021-04-29 21:46:05 +02:00
Owner
Copy Link

@e do we have a ticket for this?

@e do we have a ticket for this?
e commented 2021-04-30 00:16:12 +02:00
Author
Member
Copy Link

@erlehmann

#41 ?

@erlehmann #41 ?
e commented 2021-04-30 00:19:08 +02:00
Author
Member
Copy Link

Does anyone think it's significant that the constants were removed? I'd almost expect to see the later step overwriting the former, it doesn't seem to happen.

Does anyone think it's significant that the constants were removed? I'd almost expect to see the later step overwriting the former, it doesn't seem to happen.
erlehmann commented 2021-04-30 01:19:52 +02:00
Owner
Copy Link

Does anyone think it's significant that the constants were removed? I'd almost expect to see the later step overwriting the former, it doesn't seem to happen.

I am not sure what the constants do, but I would try to have the behaviour match Mineclone2 if they have a deterministic solution by now, possibly using their constants.

> Does anyone think it's significant that the constants were removed? I'd almost expect to see the later step overwriting the former, it doesn't seem to happen. I am not sure what the constants do, but I would try to have the behaviour match Mineclone2 if they have a deterministic solution by now, possibly using their constants.
ryvnf approved these changes 2021-05-01 13:04:53 +02:00
erlehmann merged commit 150868f03b into master 2021-05-02 01:41:13 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
erlehmann
ryvnf
Labels
Clear labels   
blocker

blocks release until resolved

  
bug

   
code quality

   
confirmed

   
critical

crashes, catastrophic bugs

  
discussion

   
high priority

   
incompatibility

incompatible with mcl2

  
incomplete feature

   
invalid

   
low priority

   
missing feauture

   
needs testing

   
packet spam

   
performance

   
project

meta-issues

  
regression

   
translations

   
unconfirmed
  
in review

   
ready for review
No Label
blocker
bug
code quality
confirmed
critical
discussion
high priority
incompatibility
incomplete feature
invalid
low priority
missing feauture
needs testing
packet spam
performance
project
regression
translations
unconfirmed
in review
ready for review
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Mineclonia/Mineclonia#43
No description provided.
Delete Branch "e/Mineclonia:mapgen-nondet"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?