Mineclonia
/
Mineclonia
Archived
12
17
Fork 13
Code Issues 105 Pull Requests 19 Projects Releases Wiki Activity

Add mod.confs to silence Minetest 5.5 warnings #298

Merged
erlehmann merged 1 commits from :add-mod-confs into master 2022-05-12 01:33:15 +02:00
Conversation 5 Commits 1 Files Changed 8 +8
erlehmann commented 2022-05-11 20:25:47 +02:00
Owner
Copy Link

This is a copy of #297 for which I messed up the merge.

Problem

TRACKING ISSUE: #263

Solution

Add mod.confs with names defined to avoid any warnings that say "Mods6 not having a mod.conf file with the name is deprecated"

Details
Testing Steps
  1. Enter a world in Minetest 5.5+ with Mineclonia commit 54f72a1457
  2. Verify that warnings occur about mods which have no mod.conf with a name entry (which is deprecated) in terminal output or debug.txt.
  3. Enter a world in Minetest 5.5+ with Mineclonia commit ac3031c679 (branch: rudzik8/Mineclonia:add-mod-confs)
  4. Verify that no warnings occur about mods which have no mod.conf file with a name entry (which is deprecated) in terminal output or debug.txt.
This is a copy of https://git.minetest.land/Mineclonia/Mineclonia/pulls/297 for which I messed up the merge. <!-- Please include the main mod this PR affects in the title, including the leading directory. For example, if you have added a new type of banner to mcl_banners, the title should look like: items/mcl_banners: add new banner type --> ##### Problem TRACKING ISSUE: #263 <!-- Describe WHAT problem this pull request solves. If the tracking issue includes all the needed information, you can leave this section empty. --> ##### Solution Add mod.confs with names defined to avoid any warnings that say "Mods6 not having a mod.conf file with the name is deprecated" ##### Details <!-- Include any additional information here. --> ##### Testing Steps <!-- Write how we can verify this patch addresses its problem. If you need more steps, just keep adding numbers. If you don't need them all, delete the empty numbers. --> 1. Enter a world in Minetest 5.5+ with Mineclonia commit 54f72a14571971ab7611d7557a29757afbb80ac 2. Verify that warnings occur about mods which have no `mod.conf` with a `name` entry (which is deprecated) in terminal output or `debug.txt`. 3. Enter a world in Minetest 5.5+ with Mineclonia commit ac3031c679cfc8e615bbb1027afebfaadea913dd (branch: rudzik8/Mineclonia:add-mod-confs) 4. Verify that no warnings occur about mods which have no `mod.conf` file with a `name` entry (which is deprecated) in terminal output or `debug.txt`. <!-- If your pull request still needs work, uncomment the following section and include a list of things that need to be done before it's ready for us to look at. Please remember to put WIP: in front of the title as well. -->
erlehmann added 1 commit 2022-05-11 20:25:49 +02:00
erlehmann added the
ready for review
in review
 labels 2022-05-11 20:30:55 +02:00
erlehmann reviewed 2022-05-11 20:31:30 +02:00
erlehmann left a comment
Author
Owner

This works, but I can not approve my own stuff LOL.

This works, but I can not approve my own stuff LOL.
erlehmann commented 2022-05-11 20:32:03 +02:00
Author
Owner
Copy Link

@cora please help.

@cora please help.
cora commented 2022-05-11 21:14:26 +02:00
Member
Copy Link

Wdym press the big red button

Wdym press the big red button
cora commented 2022-05-11 21:14:52 +02:00
Member
Copy Link

I dont think my approval counts

I dont think my approval counts
cora approved these changes 2022-05-11 21:15:39 +02:00
erlehmann commented 2022-05-11 21:37:44 +02:00
Author
Owner
Copy Link

I dont think my approval counts

I have no idea why though.

> I dont think my approval counts I have no idea why though.
erlehmann commented 2022-05-11 21:38:51 +02:00
Author
Owner
Copy Link

@cora maybe you need to accept an invitation to be added to the team or so?

@cora maybe you need to accept an invitation to be added to the team or so?
erlehmann merged commit 20e44e4033 into master 2022-05-12 01:33:15 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
cora
Labels
Clear labels   
blocker

blocks release until resolved

  
bug

   
code quality

   
confirmed

   
critical

crashes, catastrophic bugs

  
discussion

   
high priority

   
incompatibility

incompatible with mcl2

  
incomplete feature

   
invalid

   
low priority

   
missing feauture

   
needs testing

   
packet spam

   
performance

   
project

meta-issues

  
regression

   
translations

   
unconfirmed
  
in review

   
ready for review
No Label
blocker
bug
code quality
confirmed
critical
discussion
high priority
incompatibility
incomplete feature
invalid
low priority
missing feauture
needs testing
packet spam
performance
project
regression
translations
unconfirmed
in review
ready for review
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Mineclonia/Mineclonia#298
No description provided.
Delete Branch ":add-mod-confs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?