Mineclonia
/
Mineclonia
Archived
12
17
Fork 13
Code Issues 105 Pull Requests 19 Projects Releases Wiki Activity

Solve quartz not generating in the nether #24

Merged
erlehmann merged 1 commits from reintroduce_nether_quartz_ore into master 2021-04-19 01:12:18 +02:00
Conversation 0 Commits 1 Files Changed 1 +1 -1
erlehmann commented 2021-04-19 00:39:39 +02:00
Owner
Copy Link

This PR fixes that Nether quartz was removed from the game by accident in Mineclone2 0.71:

#22

How to test

With and without the changes from this PR, do the following:

  1. In singleplayer Mineclone 5.4, generate a world with the seed test_nether on mapgen v7, with the top 3 mapgen options checked and the other ones unchecked.

  2. Start a game in the just generated world.

  3. Grant yourself all privileges with /grantme all.

  4. Teleport to the Nether with /teleport -2.5,-28970,40.

  5. You should teleport in front of a wall that has Nether quartz ore if the changes from this PR have been applied.

This PR fixes that Nether quartz was removed from the game by accident in Mineclone2 0.71: https://git.minetest.land/Mineclonia/Mineclonia/issues/22 How to test ----------- With and without the changes from this PR, do the following: 1. In singleplayer Mineclone 5.4, generate a world with the seed `test_nether` on mapgen `v7`, with the top 3 mapgen options checked and the other ones unchecked. 2. Start a game in the just generated world. 3. Grant yourself all privileges with `/grantme all`. 4. Teleport to the Nether with `/teleport -2.5,-28970,40`. 5. You should teleport in front of a wall that has Nether quartz ore if the changes from this PR have been applied.
erlehmann added 1 commit 2021-04-19 00:39:41 +02:00
erlehmann requested review from cora 2021-04-19 00:56:55 +02:00
cora approved these changes 2021-04-19 01:11:39 +02:00
cora left a comment
Member

I followed the steps in the pr and as expected without the patch no ore would generate. After it there is one node of ore as described.

I followed the steps in the pr and as expected without the patch no ore would generate. After it there is one node of ore as described.
erlehmann merged commit bbe07abb0d into master 2021-04-19 01:12:18 +02:00
Li0n added the
bug
 label 2021-04-26 20:41:06 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
cora
Labels
Clear labels   
blocker

blocks release until resolved

  
bug

   
code quality

   
confirmed

   
critical

crashes, catastrophic bugs

  
discussion

   
high priority

   
incompatibility

incompatible with mcl2

  
incomplete feature

   
invalid

   
low priority

   
missing feauture

   
needs testing

   
packet spam

   
performance

   
project

meta-issues

  
regression

   
translations

   
unconfirmed
  
in review

   
ready for review
No Label
blocker
bug
code quality
confirmed
critical
discussion
high priority
incompatibility
incomplete feature
invalid
low priority
missing feauture
needs testing
packet spam
performance
project
regression
translations
unconfirmed
in review
ready for review
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Mineclonia/Mineclonia#24
No description provided.
Delete Branch "reintroduce_nether_quartz_ore"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?