Fix shearsy wool typo in GROUPS.md #229

JosiahWI · 2022-01-12T18:18:42+01:00

JosiahWI commented

2022-01-12 18:18:42 +01:00

Problem

TRACKING ISSUE: fixes #223

Solution

I fixed the typo.

Details

I replaced shearsy=wool= with shearsy_wool=.

Testing Steps

N/A

To do

Ready for Review

##### Problem TRACKING ISSUE: fixes #223 ##### Solution I fixed the typo. ##### Details I replaced `shearsy=wool=` with `shearsy_wool=`. ##### Testing Steps N/A ##### To do Ready for Review

JosiahWI added 1 commit 2022-01-12 18:18:45 +01:00

e2e7e15b39

fix one character typo in GROUPS.md

Li0n_2 commented

2022-01-12 21:30:12 +01:00

hi Josiah, these changes cannot be approved until someone tests whether they affect the in-game interaction with nodes of the type shearsy_wool. I think the testing instructions would looks something like this:
in both versions of mineclonia with and without the fix, try digging some wool blocks (check how long it takes to dig), placing some, setting them on fire, burning them in the oven, crafting with them, using shears on them, using shears on a sheep, looking at the description when you hover over the items in your inventory, and reading the description in the help text that you get by clicking on a wool block with the looking glass help tool. note any differences between the 2 versions. if there are no differences, we are good to go. if there are differences, we can discuss whether they are wanted changes or need to be fixed.

hi Josiah, these changes cannot be approved until someone tests whether they affect the in-game interaction with nodes of the type shearsy_wool. I think the testing instructions would looks something like this: in both versions of mineclonia with and without the fix, try digging some wool blocks (check how long it takes to dig), placing some, setting them on fire, burning them in the oven, crafting with them, using shears on them, using shears on a sheep, looking at the description when you hover over the items in your inventory, and reading the description in the help text that you get by clicking on a wool block with the looking glass help tool. note any differences between the 2 versions. if there are no differences, we are good to go. if there are differences, we can discuss whether they are wanted changes or need to be fixed.

Li0n_2 added the

needs testing

code quality

labels 2022-01-12 21:31:26 +01:00

Li0n_2 approved these changes 2022-01-12 22:17:03 +01:00

Li0n_2 left a comment

on further inspection it looks like GROUPS.md is a documentation file that is not used by the game. no testing needed.

Li0n_2 merged commit 7ede0ca79a into master

2022-01-12 22:19:12 +01:00

Li0n_2 referenced this issue from a commit

2022-01-12 22:19:14 +01:00

Merge pull request 'Fix shearsy wool typo in GROUPS.md' (#229) from JosiahWI/Mineclonia:fix-groups-typo into master

This repo is archived. You cannot comment on pull requests.

No reviewers

No Milestone

No project

No Assignees

2 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Mineclonia/Mineclonia#229