Mineclonia
/
Mineclonia
Archived
12
17
Fork 13
Code Issues 105 Pull Requests 19 Projects Releases Wiki Activity

Various fixes to the enchanting and loot system #206

Open
LizzyFleckenstein03 wants to merge 5 commits from LizzyFleckenstein03/Mineclonia:enchanting_loot into master
pull from: LizzyFleckenstein03/Mineclonia:enchanting_loot
merge into: Mineclonia:master
Conversation 3 Commits 5 Files Changed 7 +125 -89
LizzyFleckenstein03 commented 2021-12-07 18:29:02 +01:00
Contributor
Copy Link
Problem

Doesn't really fix a singular problem, just some general enchanting/loot code cleanup.
Also adds features requested in #204.

Solution
  • enchanted loot generated by mapgen now uses PseudoRandom for randomness
  • prevent fishing loot from being calculated 32767 times (!!!) every time you fish
  • bows and fishing rods obtained from the treasure section of fishing loot are now enchanted
  • there is now a function to uniform enchant items other than books
  • removed stupidity and mistakes my previous me made
Details

Please don't make a big problem out of the fact that this fixes multiple things at once. If something is broken, fix it. Don't bitch about it please, this is much faster than making a separate PR for each issue, it saves my time and the reviewer's time.

You didn't investigate my enchanting code when I wrote it for the first time, so why make a problem out of me improving it now. Please just review this and don't create artificial problems. Thank you.

Testing Steps
  1. Fishing
  2. Dungeon loot
  3. Mineshaft loot
  4. Desert temple loot

It might be useful to add various loot chests as items to be able to place them and check their loot for testing this. Minecraft even has that feature.

##### Problem Doesn't really fix a singular problem, just some general enchanting/loot code cleanup. Also adds features requested in #204. ##### Solution - enchanted loot generated by mapgen now uses PseudoRandom for randomness - prevent fishing loot from being calculated 32767 times (!!!) every time you fish - bows and fishing rods obtained from the treasure section of fishing loot are now enchanted - there is now a function to uniform enchant items other than books - removed stupidity and mistakes my previous me made ##### Details Please don't make a big problem out of the fact that this fixes multiple things at once. If something is broken, fix it. Don't bitch about it please, this is much faster than making a separate PR for each issue, it saves my time and the reviewer's time. You didn't investigate my enchanting code when I wrote it for the first time, so why make a problem out of me improving it now. Please just review this and don't create artificial problems. Thank you. ##### Testing Steps 1. Fishing 2. Dungeon loot 3. Mineshaft loot 4. Desert temple loot It might be useful to add various loot chests as items to be able to place them and check their loot for testing this. Minecraft even has that feature.
LizzyFleckenstein03 added 5 commits 2021-12-07 18:29:03 +01:00
af8f1ea1bb
Various fixes to the enchanting and loot system 
- enchanted loot generated by mapgen now uses PseudoRandom for randomness
- prevent fishing loot from generating loot 32767 times (!!!) when only 1 is needed
- bows and fishing rods obtained from the treasure section of fishing loot are now enchanted
- there is now a function to uniform enchant items other than books
erlehmann commented 2021-12-07 23:42:12 +01:00
Owner
Copy Link

Please don't make a big problem out of the fact that this fixes multiple things at once. If something is broken, fix it. Don't bitch about it please, this is much faster than making a separate PR for each issue, it saves my time and the reviewer's time.

I won't complain about it here, but the thing is, with bigger PRs it is easier for the committer, but harder for the reviewer because they have to review/test everything at once or they can't approve it.

> Please don't make a big problem out of the fact that this fixes multiple things at once. If something is broken, fix it. Don't bitch about it please, this is much faster than making a separate PR for each issue, it saves my time and the reviewer's time. I won't complain about it here, but the thing is, with bigger PRs it is easier for the committer, but harder for the reviewer because they have to review/test everything at once or they can't approve it.
erlehmann commented 2021-12-07 23:46:13 +01:00
Owner
Copy Link

Testing Steps

  1. Fishing
  2. Dungeon loot
  3. Mineshaft loot
  4. Desert temple loot

Please provide more detailed testing steps. I have no idea what you expect to be verified here – in particular, what the difference to the previous loot generation should be.

Please provide a mapgen with settings and a seed so a reviewer can verify that the loot generation is deterministic.

It might be useful to add various loot chests as items to be able to place them and check their loot for testing this. Minecraft even has that feature.

Might be, but testers can place structures with debug privilege too – except Mineshafts, but those are common.

> Testing Steps > > 1. Fishing > 2. Dungeon loot > 3. Mineshaft loot > 4. Desert temple loot Please provide more detailed testing steps. I have no idea what you expect to be verified here – in particular, what the difference to the previous loot generation should be. Please provide a mapgen with settings and a seed so a reviewer can verify that the loot generation is deterministic. > It might be useful to add various loot chests as items to be able to place them and check their loot for testing this. Minecraft even has that feature. Might be, but testers can place structures with `debug` privilege too – except Mineshafts, but those are common.
erlehmann added a new dependency 2021-12-08 03:45:22 +01:00
#204 WIP: MAPGEN/mcl_structures: Add ruined Nether portal
erlehmann commented 2021-12-08 05:28:40 +01:00
Owner
Copy Link

bows and fishing rods obtained from the treasure section of fishing loot are now enchanted

Nice. I noticed this has been missing even before this PR.

> bows and fishing rods obtained from the treasure section of fishing loot are now enchanted Nice. I noticed this has been missing even before this PR.
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
blocker

blocks release until resolved

  
bug

   
code quality

   
confirmed

   
critical

crashes, catastrophic bugs

  
discussion

   
high priority

   
incompatibility

incompatible with mcl2

  
incomplete feature

   
invalid

   
low priority

   
missing feauture

   
needs testing

   
packet spam

   
performance

   
project

meta-issues

  
regression

   
translations

   
unconfirmed
  
in review

   
ready for review
No Label
blocker
bug
code quality
confirmed
critical
discussion
high priority
incompatibility
incomplete feature
invalid
low priority
missing feauture
needs testing
packet spam
performance
project
regression
translations
unconfirmed
in review
ready for review
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#204 WIP: MAPGEN/mcl_structures: Add ruined Nether portal
Mineclonia/Mineclonia
Reference: Mineclonia/Mineclonia#206
No description provided.
Delete Branch "LizzyFleckenstein03/Mineclonia:enchanting_loot"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?