Mineclonia
/
Mineclonia
Archived
12
17
Fork 13
Code Issues 105 Pull Requests 19 Projects Releases Wiki Activity

ITEMS/mcl_chests: Add debug command to show ender chest inventory formspec. #194

Merged
cora merged 1 commits from add-enderchest-command into master 2021-12-03 11:53:53 +01:00
Conversation 0 Commits 1 Files Changed 1 +7
erlehmann commented 2021-12-02 19:57:08 +01:00
Owner
Copy Link
Problem

TRACKING ISSUE: #192

For debugging purposes, I want to open an ender chest inventory formspec without being near an ender chest.

Solution

This patch adds a chat command to show a player the ender chest inventory formspec.

Details

The command is named /enderchest.

Testing Steps
  1. Start Minetest with Mineclonia commit 54b36c42a9.
  2. Place an ender chest (mcl_chests:ender_chest_small), open its inventory and put some items (whatever) into it.
  3. Remove the ender chest you placed.
  4. Verify that the chat command help screen (accessible with /help) shows that mcl_chests has a /enderchest command with help text. The command name should be colored gray.
  5. Execute /enderchest. Verify that you do not see the ender chest form spec but a message about missing privileges.
  6. Execute /grantme debug to get the debug privilege.
  7. Verify that the chat command help screen (accessible with /help) shows that mcl_chests has a /enderchest command with help text. The command name should be colored green.
  8. Execute /enderchest. Verify that you see the ender chest form spec.
  9. Verify that you can put items in the ender chest inventory.
  10. Verify that you can take out items from the ender chest inventory.
  11. Verify that you can swap items with items from the ender chest inventory.
  12. Verify that you can close the ender chest form spec with the escape key.
##### Problem TRACKING ISSUE: https://git.minetest.land/Mineclonia/Mineclonia/issues/192 For debugging purposes, I want to open an ender chest inventory formspec without being near an ender chest. ##### Solution This patch adds a chat command to show a player the ender chest inventory formspec. ##### Details The command is named `/enderchest`. ##### Testing Steps 1. Start Minetest with Mineclonia commit 54b36c42a93f834c80dda5ac5854aa0f70b7aa10. 5. Place an ender chest (`mcl_chests:ender_chest_small`), open its inventory and put some items (whatever) into it. 6. Remove the ender chest you placed. 2. Verify that the chat command help screen (accessible with /help) shows that mcl_chests has a `/enderchest` command with help text. The command name should be colored gray. 7. Execute `/enderchest`. Verify that you do not see the ender chest form spec but a message about missing privileges. 3. Execute /grantme debug to get the debug privilege. 4. Verify that the chat command help screen (accessible with /help) shows that mcl_chests has a `/enderchest` command with help text. The command name should be colored green. 7. Execute `/enderchest`. Verify that you see the ender chest form spec. 8. Verify that you can put items in the ender chest inventory. 9. Verify that you can take out items from the ender chest inventory. 10. Verify that you can swap items with items from the ender chest inventory. 11. Verify that you can close the ender chest form spec with the escape key.
erlehmann added 1 commit 2021-12-02 19:57:10 +01:00
cora approved these changes 2021-12-03 11:53:35 +01:00
cora left a comment
Member
  • 1. Start Minetest with Mineclonia commit 54b36c42a9.
  • 2. Place an ender chest (mcl_chests:ender_chest_small), open its inventory and put some items (whatever) into it.
  • 3. Remove the ender chest you placed.
  • 4. Verify that the chat command help screen (accessible with /help) shows that mcl_chests has a /enderchest command with help text. The command name should be colored gray.
  • 5. Execute /enderchest. Verify that you do not see the ender chest form spec but a message about missing privileges.
  • 6. Execute /grantme debug to get the debug privilege.
  • 7. Verify that the chat command help screen (accessible with /help) shows that mcl_chests has a /enderchest command with help text. The command name should be colored green.
  • 8. Execute /enderchest. Verify that you see the ender chest form spec.
  • 9. Verify that you can put items in the ender chest inventory.
  • 10. Verify that you can take out items from the ender chest inventory.
  • 11. Verify that you can swap items with items from the ender chest inventory.
  • 12. Verify that you can close the ender chest form spec with the escape key.
- [x] 1. Start Minetest with Mineclonia commit 54b36c42a93f834c80dda5ac5854aa0f70b7aa10. - [x] 2. Place an ender chest (`mcl_chests:ender_chest_small`), open its inventory and put some items (whatever) into it. - [x] 3. Remove the ender chest you placed. - [x] 4. Verify that the chat command help screen (accessible with /help) shows that mcl_chests has a `/enderchest` command with help text. The command name should be colored gray. - [x] 5. Execute `/enderchest`. Verify that you do not see the ender chest form spec but a message about missing privileges. - [x] 6. Execute /grantme debug to get the debug privilege. - [x] 7. Verify that the chat command help screen (accessible with /help) shows that mcl_chests has a `/enderchest` command with help text. The command name should be colored green. - [x] 8. Execute `/enderchest`. Verify that you see the ender chest form spec. - [x] 9. Verify that you can put items in the ender chest inventory. - [x] 10. Verify that you can take out items from the ender chest inventory. - [x] 11. Verify that you can swap items with items from the ender chest inventory. - [x] 12. Verify that you can close the ender chest form spec with the escape key.
cora merged commit dd347c50c5 into master 2021-12-03 11:53:53 +01:00
cora deleted branch add-enderchest-command 2021-12-03 11:53:55 +01:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
cora
Labels
Clear labels   
blocker

blocks release until resolved

  
bug

   
code quality

   
confirmed

   
critical

crashes, catastrophic bugs

  
discussion

   
high priority

   
incompatibility

incompatible with mcl2

  
incomplete feature

   
invalid

   
low priority

   
missing feauture

   
needs testing

   
packet spam

   
performance

   
project

meta-issues

  
regression

   
translations

   
unconfirmed
  
in review

   
ready for review
No Label
blocker
bug
code quality
confirmed
critical
discussion
high priority
incompatibility
incomplete feature
invalid
low priority
missing feauture
needs testing
packet spam
performance
project
regression
translations
unconfirmed
in review
ready for review
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#193 ITEMS/mcl_chests: Fix access to ender chest inventory without an ender chest
Mineclonia/Mineclonia
Reference: Mineclonia/Mineclonia#194
No description provided.
Delete Branch "add-enderchest-command"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?