Fix: Add missing translations for mcl_enchanting (Enchantment Table) #17
erle
Li0n
Labels
No Label
blocker
bug
code quality
confirmed
critical
discussion
high priority
incompatibility
incomplete feature
invalid
low priority
missing feauture
needs testing
packet spam
performance
project
regression
translations
unconfirmed
in review
ready for review
No Milestone
No project
No Assignees
3 Participants
No due date set.
Dependencies
No dependencies set.
Reference: Mineclonia/Mineclonia#17
Loading…
Reference in New Issue
No description provided.
Delete Branch "n_to/Mineclonia:update_template.txt"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes one affected module of: #16
Changes:
Affected views:
To review this, I would like to know where in the game these texts actually show up.
Is it enough to run the help tool?
I added the affected views to the description.
a8b73f43e9to4939222470I think you should put a warning at the top of the translations files for french and russian that some of it is machine translated. I think if you start a line with a # it gets ignored by the code and can be used for comments. this would help any future translators to find the bad translations more easily to correct them.
@Li0n I added a disclaimer as proposed.
I checked whether I could make these translations show up in the game in english, german and french. I did not check whether the translations are perfect but they seemed about the same length as the english so I'm sure it is better than nothing. I did not check russian in-game but I don't see why it would be different from the other languages. the code looks good. the english helptext is not perfect but that is not really an urgent problem in my opinion and can be fixed later.
Only thing I can think of is that cyrillic glyphs can sometimes have display problems when latin glyphs have none. Thank you for noting that you did not check that out, maybe we can ask someone who can speak russian.
@erlehmann How shall we proceed here? Shall I remove the russian translation as noone is capable of verifying it?
@n_to I am going to check now if it displays and I guess we can fix it once someone speaks up about the "magic cheese desk" or whatever mess the autotranslate made?
@Li0n has approved it, but please hold off merging until I checked the cyrillic glyphs render correctly to prevent encoding problems.
@ -83,3 +83,3 @@<player> <enchantment> [<level>]=Usage: /enchant <player> <enchantment> [<level>]=Player '@1' cannot be found.=Player '@1' cannot be found.= origin FixForBugThis looks like a mistake. Please change or explain it.
@erlehmann I honestly have no idea where this came from. I thought I had not touched this file manually (only used the translation tool to generate the missing strings). It must have been some accidental copypasting. I promise to be more careful with these things in the future and check the changes more thoroughly before creating the PR.
I have removed the value in
77a123820dand will now rerequest your review.Try using
git add -pin the future.New bug in the PR was found and fixed
I noticed a whitespace error. Not sure if this affects the translation in-game.
@ -98,2 +98,4 @@Enchanted Book=Verzaubertes BuchEnchanting Table=ZaubertischSpend experience, and lapis to enchant various items.=Verbrauche Erfahrung und Lapislazuli, um verschiedene Gegenstände zu verzaubern.Enchanting Tables will let you enchant armors, tools, weapons, and books with various abilities. But, at the cost of some experience, and lapis lazuli.=Mit Zaubertischen kannst Du Rüstungen, Werkzeuge, Waffen und Bücher mit verschiedenen Fähigkeiten verzaubern. Das kostet aber Erfahrung und Lapislazuli.There is a whitespace error here (space at the end of the line). Please remove this.
You would have probably noticed this with
git add -p.I used 'git add -p' for the first time today (you only told me about it after the last push).
The whitespace most certainly has no impact on the translation as it is only used in the helpscreen, will be used nowhere else (as it is a text written only for this help-screen) and renders there perfectly fine.
I respect your thoroughness and will in future check for trailing spaces. Or let git check this for me :3
d55a436af6to48091cecab@erlehmann As they are all about the same topic and target I combined all changes in one whole commit so this does not clog up our log.
it seems unlikely that this commit can break the game in any way (since it follows the guidelines that were set up for this translation mod) so that's good enough for me for now. translations can always be improved later. I hope someone else checks a bit more thoroughly.