ITEMS/mcl_core: Add debarking and stripped trunk / wood #135

Merged

cora merged 8 commits from stripped-wood-3 into master 2021-09-07 03:41:02 +02:00

Conversation 11 Commits 8 Files Changed 17 +168 -54

erlehmann commented 2021-07-31 21:26:17 +02:00

Owner

Copy Link

Problem

TRACKING ISSUE: #80

This PR is a refactoring of #86 to make it easier to review, get a nicer history, and fix typos.

Solution

@NO11 wrote code that adds:

• stripping nodes with an axe
• stripped wood variant nodes
• more plank crafting recipes

Details

Debarking works by right clicking wood using an axe to turn it into its stripped variant.

Both strippd tree trunk and stripped tree bark nodes have been added.
Trunk nodes show annual rings textures on two opposing sides instead of stripped wood textures.

Testing Steps

Node & Item Names

Tree:

• mcl_core:acaciatree
• mcl_core:birchtree
• mcl_core:darktree
• mcl_core:jungletree
• mcl_core:sprucetree
• mcl_core:tree

Bark:

• mcl_core:acaciatree_bark
• mcl_core:birchtree_bark
• mcl_core:darktree_bark
• mcl_core:jungletree_bark
• mcl_core:sprucetree_bark
• mcl_core:tree_bark

Stripped Tree:

• mcl_core:stripped_acacia
• mcl_core:stripped_birch
• mcl_core:stripped_dark_oak
• mcl_core:stripped_jungle
• mcl_core:stripped_spruce
• mcl_core:stripped_oak

Stripped Bark:

• mcl_core:stripped_acacia_bark
• mcl_core:stripped_birch_bark
• mcl_core:stripped_dark_oak_bark
• mcl_core:stripped_jungle_bark
• mcl_core:stripped_spruce_bark
• mcl_core:stripped_oak_bark

Wooden Planks:

• mcl_core:acaciawood
• mcl_core:birchwood
• mcl_core:darkwood
• mcl_core:junglewood
• mcl_core:sprucewood
• mcl_core:wood

Axes:

• mcl_tools:axe_wood
• mcl_tools:axe_stone
• mcl_tools:axe_iron
• mcl_tools:axe_gold
• mcl_tools:axe_diamond

Protection Block:

• protector:protect

Preparation

1. Check out Mineclonia commit 3759d50344.

Verify Plank Crafting

1. In a Mineclonia world in survival mode, check for every wood type (oak, dark oak, jungle, acacia, spruce, birch) of the following nodes that you can craft four planks of the corresponding wood type in your player inventory (not needing a craftng bench):

• tree
• tree bark
• stripped tree
• stripped tree bark

(These are 6 × 4 = 24 different nodes. Please check them all – it is the only way to be sure.)

Verify German Translation

1. In a Mineclonia world in creative mode, start the game once in English and once in German and verify that the nodes names are translated like this:

• Stripped Acacia Log=Entrindeter Akazienstamm
• Stripped Acacia Wood=Entrindetes Akazienholz
• Stripped Birch Log=Entrindeter Birkenstamm
• Stripped Birch Wood=Entrindetes Birkenholz
• Stripped Dark Oak Log=Entrindeter Schwarzeichenstamm
• Stripped Dark Oak Wood=Entrindetes Schwarzeichenholz
• Stripped Jungle Log=Entrindeter Dschungelbaumstamm
• Stripped Jungle Wood=Entrindetes Dschungelholz
• Stripped Oak Log=Entrindeter Eichenstamm
• Stripped Oak Wood=Entrindetes Eichenholz
• Stripped Spruce Log=Entrindeter Fichtenstamm
• Stripped Spruce Wood=Entrindetes Fichtenholz

2. Using the help screen, check that the node descriptions are also translated correctly from English to German:

• The stripped trunk of an acacia tree.=Der entrindete Stamm einer Akazie.
• The stripped trunk of a birch tree.=Der entrindete Stamm einer Birke.
• The stripped trunk of a dark oak tree.=Der entrindete Stamm einer Schwarzeiche.
• The stripped trunk of a jungle tree.=Der entrindete Stamm eines Dschungelbaums.
• The stripped trunk of an oak tree.=Der entrindete Stamm einer Eiche.
• The stripped trunk of a spruce tree.=Der entrindete Stamm einer Fichte.
• The stripped wood of an acacia tree.=Das entrindete Holz einer Akazie.
• The stripped wood of a birch tree.=Das entrindete Holz einer Birke.
• The stripped wood of a dark oak tree.=Das entrindete Holz einer Schwarzeiche.
• The stripped wood of a jungle tree.=Das entrindete Holz eines Dschungelbaums.
• The stripped wood of an oak tree.=Das entrindete Holz einer Eiche.
• The stripped wood of a spruce tree.=Das entrindete Holz einer Fichte.

(This step is to help find typos in the translation template. We should probably automate it.)

Verify Bark crafting

1. In a Mineclonia world in survival mode, check for every wood type (oak, dark oak, jungle, acacia, spruce, birch) of the following nodes that you can craft three bark out of four of the corresponding wood type in your player inventory (not needing a craftng bench):

• tree
• stripped tree

Verify Wood Stripping

1. In a Mineclonia world in survival mode, for every wood type (oak, dark oak, jungle, acacia, spruce, birch) place the following nodes three times each – once on top (or bottom), once against the north (or south) face, once on the west (or east) face of an exiting node:

• tree
• tree bark

(This means placing 6 × 3 × 2 = 36 nodes.)

2. Right-click all the placed nodes with an arsenal of axes of different types (wood, stone, iron, gold, diamond). You do not need to use each axe on each node, but please use every axe at least once.

3. Verify the following:

• After right-clicking tree or tree bark nodes with an axe, the stripped nodes being swapped in face the same direction as the replaced node. (See the attached picture for some different directions that stripped nodes can have.)
• Axes lose durability when being stripped. Each axe should have a health bar shown after the first right click on a tree or tree bark block.

Verify Wood Stripping Protection

1. Install the mod “Protector Redo” by TenPlus1 from the content tab in Minetest.
2. In a Mineclonia world in survival mode with the “host server” option selected and the username set to “a” and the protector mod activated, place two tree or tree bark nodes and a protector block right next to it.
3. Right click one of the previously placed tree or tree bark nodes with an axe: Verify that the node is replaced with its stripped variant.
4. Exit the world.
5. In the same Mineclonia world in survival mode with the “host server” option selected and the username set to “b” and the protector mod activated, right click the previously placed tree or tree bark node with an axe.
6. Verify that the node is not replaced by its stripped variant and that a chat message is shown that the node belongs to user “a”.

To do

• Fill out PR template
• Write comprehensive testing instructions
• Verify testing instructions

##### Problem TRACKING ISSUE: https://git.minetest.land/Mineclonia/Mineclonia/issues/80 This PR is a refactoring of https://git.minetest.land/Mineclonia/Mineclonia/pulls/86 to make it easier to review, get a nicer history, and fix typos. ##### Solution @NO11 wrote code that adds: • stripping nodes with an axe • stripped wood variant nodes • more plank crafting recipes ##### Details Debarking works by right clicking wood using an axe to turn it into its stripped variant. Both strippd tree trunk and stripped tree bark nodes have been added. Trunk nodes show annual rings textures on two opposing sides instead of stripped wood textures. ##### Testing Steps ###### Node & Item Names Tree: * mcl_core:acaciatree * mcl_core:birchtree * mcl_core:darktree * mcl_core:jungletree * mcl_core:sprucetree * mcl_core:tree Bark: * mcl_core:acaciatree_bark * mcl_core:birchtree_bark * mcl_core:darktree_bark * mcl_core:jungletree_bark * mcl_core:sprucetree_bark * mcl_core:tree_bark Stripped Tree: * mcl_core:stripped_acacia * mcl_core:stripped_birch * mcl_core:stripped_dark_oak * mcl_core:stripped_jungle * mcl_core:stripped_spruce * mcl_core:stripped_oak Stripped Bark: * mcl_core:stripped_acacia_bark * mcl_core:stripped_birch_bark * mcl_core:stripped_dark_oak_bark * mcl_core:stripped_jungle_bark * mcl_core:stripped_spruce_bark * mcl_core:stripped_oak_bark Wooden Planks: * mcl_core:acaciawood * mcl_core:birchwood * mcl_core:darkwood * mcl_core:junglewood * mcl_core:sprucewood * mcl_core:wood Axes: * mcl_tools:axe_wood * mcl_tools:axe_stone * mcl_tools:axe_iron * mcl_tools:axe_gold * mcl_tools:axe_diamond Protection Block: * protector:protect ###### Preparation 1. Check out Mineclonia commit 3759d503440e4558566076a41b68b1f60ddce8e8. ###### Verify Plank Crafting 1. In a Mineclonia world *in survival mode*, check for every wood type (oak, dark oak, jungle, acacia, spruce, birch) of the following nodes that you can craft four planks of the corresponding wood type in your player inventory (not needing a craftng bench): * tree * tree bark * stripped tree * stripped tree bark (These are 6 × 4 = 24 different nodes. Please check them all – it is the only way to be sure.) ###### Verify German Translation 1. In a Mineclonia world *in creative mode*, start the game once in English and once in German and verify that the nodes names are translated like this: * Stripped Acacia Log=Entrindeter Akazienstamm * Stripped Acacia Wood=Entrindetes Akazienholz * Stripped Birch Log=Entrindeter Birkenstamm * Stripped Birch Wood=Entrindetes Birkenholz * Stripped Dark Oak Log=Entrindeter Schwarzeichenstamm * Stripped Dark Oak Wood=Entrindetes Schwarzeichenholz * Stripped Jungle Log=Entrindeter Dschungelbaumstamm * Stripped Jungle Wood=Entrindetes Dschungelholz * Stripped Oak Log=Entrindeter Eichenstamm * Stripped Oak Wood=Entrindetes Eichenholz * Stripped Spruce Log=Entrindeter Fichtenstamm * Stripped Spruce Wood=Entrindetes Fichtenholz 2. Using the help screen, check that the node descriptions are also translated correctly from English to German: * The stripped trunk of an acacia tree.=Der entrindete Stamm einer Akazie. * The stripped trunk of a birch tree.=Der entrindete Stamm einer Birke. * The stripped trunk of a dark oak tree.=Der entrindete Stamm einer Schwarzeiche. * The stripped trunk of a jungle tree.=Der entrindete Stamm eines Dschungelbaums. * The stripped trunk of an oak tree.=Der entrindete Stamm einer Eiche. * The stripped trunk of a spruce tree.=Der entrindete Stamm einer Fichte. * The stripped wood of an acacia tree.=Das entrindete Holz einer Akazie. * The stripped wood of a birch tree.=Das entrindete Holz einer Birke. * The stripped wood of a dark oak tree.=Das entrindete Holz einer Schwarzeiche. * The stripped wood of a jungle tree.=Das entrindete Holz eines Dschungelbaums. * The stripped wood of an oak tree.=Das entrindete Holz einer Eiche. * The stripped wood of a spruce tree.=Das entrindete Holz einer Fichte. (This step is to help find typos in the translation template. We should probably automate it.) ###### Verify Bark crafting 1. In a Mineclonia world *in survival mode*, check for every wood type (oak, dark oak, jungle, acacia, spruce, birch) of the following nodes that you can craft three bark out of four of the corresponding wood type in your player inventory (not needing a craftng bench): * tree * stripped tree ###### Verify Wood Stripping 1. In a Mineclonia world *in survival mode*, for every wood type (oak, dark oak, jungle, acacia, spruce, birch) place the following nodes three times each – once on top (or bottom), once against the north (or south) face, once on the west (or east) face of an exiting node: * tree * tree bark (This means placing 6 × 3 × 2 = 36 nodes.) 2. Right-click all the placed nodes with an arsenal of axes of different types (wood, stone, iron, gold, diamond). You do not need to use each axe on each node, but please use every axe at least once. 3. Verify the following: * After right-clicking tree or tree bark nodes with an axe, the stripped nodes being swapped in face the same direction as the replaced node. (See the attached picture for some different directions that stripped nodes can have.) * Axes lose durability when being stripped. Each axe should have a health bar shown after the first right click on a tree or tree bark block. ###### Verify Wood Stripping Protection 1. Install the mod “Protector Redo” by TenPlus1 from the content tab in Minetest. 2. In a Mineclonia world *in survival mode* with the “host server” option selected and the username set to “a” and the protector mod activated, place two tree or tree bark nodes and a protector block right next to it. 3. Right click one of the previously placed tree or tree bark nodes with an axe: Verify that the node is replaced with its stripped variant. 4. Exit the world. 5. In the same Mineclonia world *in survival mode* with the “host server” option selected and the username set to “b” and the protector mod activated, right click the previously placed tree or tree bark node with an axe. 6. Verify that the node is not replaced by its stripped variant and that a chat message is shown that the node belongs to user “a”. ##### To do - [x] Fill out PR template - [x] Write comprehensive testing instructions - [x] Verify testing instructions

minetest-mod-mineclonia-debarked-wood.png

524 KiB

erlehmann referenced this pull request 2021-07-31 21:26:48 +02:00

WIP: ITEMS/mcl_core: Add stripped wood blocks #120

erlehmann commented 2021-07-31 21:28:55 +02:00

Author

Owner

Copy Link

Heavy rebase action going on here.

Heavy rebase action going on here.

erlehmann force-pushed stripped-wood-3 from 616937e9c4 to 2e5e00aa86 2021-07-31 21:37:52 +02:00 Compare

erlehmann changed title from WIP: ITEMS/mcl_core: Add debarking and stripped wood to WIP: ITEMS/mcl_core: Add debarking and stripped trunk / wood 2021-07-31 21:38:42 +02:00

erlehmann commented 2021-07-31 21:39:46 +02:00

Author

Owner

Copy Link

I squashed the three texture commits by @NO11 into a single one.

I squashed the three texture commits by @NO11 into a single one.

erlehmann force-pushed stripped-wood-3 from 2e5e00aa86 to e17d119bbc 2021-07-31 21:54:48 +02:00 Compare

erlehmann commented 2021-07-31 22:00:35 +02:00

Author

Owner

Copy Link

I rewrote the history so there are 2 commits less that only fix typos.

I rewrote the history so there are 2 commits less that only fix typos.

erlehmann commented 2021-07-31 22:04:44 +02:00

Author

Owner

Copy Link

Next up: Rewrite history so that the ”Fix typos” and “Add some spaces” commits are gone.

Next up: Rewrite history so that the ”Fix typos” and “Add some spaces” commits are gone.

NO11 commented 2021-08-30 23:05:31 +02:00

First-time contributor

Copy Link

How long do you want to wait? I will close this soon if it doesn’t happen, it was a request from you to add it and not from me.

How long do you want to wait? I will close this soon if it doesn’t happen, it was a request from you to add it and not from me.

erlehmann commented 2021-08-30 23:43:03 +02:00

Author

Owner

Copy Link

Sorry I procrastinated it. Thank you for reminding me. This is the next thing I work on Mineclonia.

Sorry I procrastinated it. Thank you for reminding me. This is the next thing I work on Mineclonia.

👍 1

erlehmann force-pushed stripped-wood-3 from e17d119bbc to bd8a45cd3f 2021-08-30 23:46:04 +02:00 Compare

erlehmann commented 2021-08-30 23:46:39 +02:00

Author

Owner

Copy Link

Rebased on master.

Rebased on master.

erlehmann force-pushed stripped-wood-3 from bd8a45cd3f to b0433f384c 2021-09-05 08:31:06 +02:00 Compare

erlehmann commented 2021-09-05 08:32:34 +02:00

Author

Owner

Copy Link

Removed pointless removal of a newline at the end of a file in one commit.

Removed pointless removal of a newline at the end of a file in one commit.

erlehmann force-pushed stripped-wood-3 from b0433f384c to 8537e154e2 2021-09-05 08:37:58 +02:00 Compare

erlehmann commented 2021-09-05 08:38:27 +02:00

Author

Owner

Copy Link

Added some spaces.

Added some spaces.

erlehmann force-pushed stripped-wood-3 from 8537e154e2 to 02f2bd9ed9 2021-09-05 08:45:18 +02:00 Compare

erlehmann commented 2021-09-05 08:45:28 +02:00

Author

Owner

Copy Link

Reduced commit count by one through squashing a commit that only fixed typos into a related commit.

Reduced commit count by one through squashing a commit that only fixed typos into a related commit.

erlehmann force-pushed stripped-wood-3 from 02f2bd9ed9 to 3759d50344 2021-09-07 00:49:31 +02:00 Compare

erlehmann commented 2021-09-07 00:52:20 +02:00

Author

Owner

Copy Link

Fixed a typo (“noddef” → “nodedef”).

Fixed a typo (“noddef” → “nodedef”).

erlehmann changed title from WIP: ITEMS/mcl_core: Add debarking and stripped trunk / wood to ITEMS/mcl_core: Add debarking and stripped trunk / wood 2021-09-07 02:42:41 +02:00

cora approved these changes 2021-09-07 03:40:45 +02:00

cora left a comment

Member

• 1. In a Mineclonia world in survival mode, check for every wood type (oak, dark oak, jungle, acacia, spruce, birch) of the following nodes that you can craft four planks of the corresponding wood type in your player inventory (not needing a craftng bench):

• tree

• tree bark

• stripped tree

• stripped tree bark

(These are 6 × 4 = 24 different nodes. Please check them all – it is the only way to be sure.)

Verify German Translation

1. In a Mineclonia world in creative mode, start the game once in English and once in German and verify that the nodes names are translated like this:

• * Stripped Acacia Log=Entrindeter Akazienstamm
• * Stripped Acacia Wood=Entrindetes Akazienholz
• * Stripped Birch Log=Entrindeter Birkenstamm
• * Stripped Birch Wood=Entrindetes Birkenholz
• * Stripped Dark Oak Log=Entrindeter Schwarzeichenstamm
• * Stripped Dark Oak Wood=Entrindetes Schwarzeichenholz
• * Stripped Jungle Log=Entrindeter Dschungelbaumstamm
• * Stripped Jungle Wood=Entrindetes Dschungelholz
• * Stripped Oak Log=Entrindeter Eichenstamm
• * Stripped Oak Wood=Entrindetes Eichenholz
• * Stripped Spruce Log=Entrindeter Fichtenstamm
• * Stripped Spruce Wood=Entrindetes Fichtenholz

2. Using the help screen, check that the node descriptions are also translated correctly from English to German:

• * The stripped trunk of an acacia tree.=Der entrindete Stamm einer Akazie.
• * The stripped trunk of a birch tree.=Der entrindete Stamm einer Birke.
• * The stripped trunk of a dark oak tree.=Der entrindete Stamm einer Schwarzeiche.
• * The stripped trunk of a jungle tree.=Der entrindete Stamm eines Dschungelbaums.
• * The stripped trunk of an oak tree.=Der entrindete Stamm einer Eiche.
• * The stripped trunk of a spruce tree.=Der entrindete Stamm einer Fichte.
• * The stripped wood of an acacia tree.=Das entrindete Holz einer Akazie.
• * The stripped wood of a birch tree.=Das entrindete Holz einer Birke.
• * The stripped wood of a dark oak tree.=Das entrindete Holz einer Schwarzeiche.
• * The stripped wood of a jungle tree.=Das entrindete Holz eines Dschungelbaums.
• * The stripped wood of an oak tree.=Das entrindete Holz einer Eiche.
• * The stripped wood of a spruce tree.=Das entrindete Holz einer Fichte.

(This step is to help find typos in the translation template. We should probably automate it.)

Verify Bark crafting

1. In a Mineclonia world in survival mode, check for every wood type (oak, dark oak, jungle, acacia, spruce, birch) of the following nodes that you can craft three bark out of four of the corresponding wood type in your player inventory (not needing a craftng bench):

• * tree
• * stripped tree

Verify Wood Stripping

1. In a Mineclonia world in survival mode, for every wood type (oak, dark oak, jungle, acacia, spruce, birch) place the following nodes three times each – once on top (or bottom), once against the north (or south) face, once on the west (or east) face of an exiting node:

• * tree
• * tree bark

(This means placing 6 × 3 × 2 = 36 nodes.)

2. Right-click all the placed nodes with an arsenal of axes of different types (wood, stone, iron, gold, diamond). You do not need to use each axe on each node, but pleae use every axe at least once.

3. Verify the following:

• * After right-clicking tree or tree bark nodes with an axe, the stripped nodes being swapped in face the same direction as the replaced node. (See the attached picture for some different directions that stripped nodes can have.)
• * Axes lose durability when being stripped. Each axe should have a health bar shown after the first right click on a tree or tree bark block.

Verify Wood Stripping Protection

• 1. Install the mod “Protector Redo” by TenPlus1 from the content tab in Minetest.
• 2. In a Mineclonia world in survival mode with the “host server” option selected and the username set to “a” and the protector mod activated, place two tree or tree bark nodes and a protector block right next to it.
• 3. Right click one of the previously placed tree or tree bark nodes with an axe: Verify that the node i replaced with its stripped variant.
• 4. Exit the world.
• 5. In the same Mineclonia world in survival mode with the “host server” option selected and the username set to “b” and the protector mod activated, right click the previously placed tree or tree bark node with an axe.
• 6. Verify that the node is not replaced by its stripped variant and that a chat message is shown that the node belongs to user “a”.

- [x] 1. In a Mineclonia world *in survival mode*, check for every wood type (oak, dark oak, jungle, acacia, spruce, birch) of the following nodes that you can craft four planks of the corresponding wood type in your player inventory (not needing a craftng bench): - [x] tree - [x] tree bark - [x] stripped tree - [x] stripped tree bark (These are 6 × 4 = 24 different nodes. Please check them all – it is the only way to be sure.) ###### Verify German Translation 1. In a Mineclonia world *in creative mode*, start the game once in English and once in German and verify that the nodes names are translated like this: - [x] * Stripped Acacia Log=Entrindeter Akazienstamm - [x] * Stripped Acacia Wood=Entrindetes Akazienholz - [x] * Stripped Birch Log=Entrindeter Birkenstamm - [x] * Stripped Birch Wood=Entrindetes Birkenholz - [x] * Stripped Dark Oak Log=Entrindeter Schwarzeichenstamm - [x] * Stripped Dark Oak Wood=Entrindetes Schwarzeichenholz - [x] * Stripped Jungle Log=Entrindeter Dschungelbaumstamm - [x] * Stripped Jungle Wood=Entrindetes Dschungelholz - [x] * Stripped Oak Log=Entrindeter Eichenstamm - [x] * Stripped Oak Wood=Entrindetes Eichenholz - [x] * Stripped Spruce Log=Entrindeter Fichtenstamm - [x] * Stripped Spruce Wood=Entrindetes Fichtenholz 2. Using the help screen, check that the node descriptions are also translated correctly from English to German: - [x] * The stripped trunk of an acacia tree.=Der entrindete Stamm einer Akazie. - [x] * The stripped trunk of a birch tree.=Der entrindete Stamm einer Birke. - [x] * The stripped trunk of a dark oak tree.=Der entrindete Stamm einer Schwarzeiche. - [x] * The stripped trunk of a jungle tree.=Der entrindete Stamm eines Dschungelbaums. - [x] * The stripped trunk of an oak tree.=Der entrindete Stamm einer Eiche. - [x] * The stripped trunk of a spruce tree.=Der entrindete Stamm einer Fichte. - [x] * The stripped wood of an acacia tree.=Das entrindete Holz einer Akazie. - [x] * The stripped wood of a birch tree.=Das entrindete Holz einer Birke. - [x] * The stripped wood of a dark oak tree.=Das entrindete Holz einer Schwarzeiche. - [x] * The stripped wood of a jungle tree.=Das entrindete Holz eines Dschungelbaums. - [x] * The stripped wood of an oak tree.=Das entrindete Holz einer Eiche. - [x] * The stripped wood of a spruce tree.=Das entrindete Holz einer Fichte. (This step is to help find typos in the translation template. We should probably automate it.) ###### Verify Bark crafting 1. In a Mineclonia world *in survival mode*, check for every wood type (oak, dark oak, jungle, acacia, spruce, birch) of the following nodes that you can craft three bark out of four of the corresponding wood type in your player inventory (not needing a craftng bench): - [x] * tree - [x] * stripped tree ###### Verify Wood Stripping 1. In a Mineclonia world *in survival mode*, for every wood type (oak, dark oak, jungle, acacia, spruce, birch) place the following nodes three times each – once on top (or bottom), once against the north (or south) face, once on the west (or east) face of an exiting node: - [x] * tree - [x] * tree bark (This means placing 6 × 3 × 2 = 36 nodes.) 2. Right-click all the placed nodes with an arsenal of axes of different types (wood, stone, iron, gold, diamond). You do not need to use each axe on each node, but pleae use every axe at least once. 3. Verify the following: - [x] * After right-clicking tree or tree bark nodes with an axe, the stripped nodes being swapped in face the same direction as the replaced node. (See the attached picture for some different directions that stripped nodes can have.) - [x] * Axes lose durability when being stripped. Each axe should have a health bar shown after the first right click on a tree or tree bark block. ###### Verify Wood Stripping Protection - [x] 1. Install the mod “Protector Redo” by TenPlus1 from the content tab in Minetest. - [x] 2. In a Mineclonia world *in survival mode* with the “host server” option selected and the username set to “a” and the protector mod activated, place two tree or tree bark nodes and a protector block right next to it. - [x] 3. Right click one of the previously placed tree or tree bark nodes with an axe: Verify that the node i replaced with its stripped variant. - [x] 4. Exit the world. - [x] 5. In the same Mineclonia world *in survival mode* with the “host server” option selected and the username set to “b” and the protector mod activated, right click the previously placed tree or tree bark node with an axe. - [x] 6. Verify that the node is not replaced by its stripped variant and that a chat message is shown that the node belongs to user “a”.

cora merged commit 42a076cc0b into master 2021-09-07 03:41:02 +02:00

cora referenced this issue from a commit 2021-09-07 03:41:03 +02:00

Merge pull request 'ITEMS/mcl_core: Add debarking and stripped trunk / wood' (#135) from stripped-wood-3 into master

cora deleted branch stripped-wood-3 2021-09-07 03:41:17 +02:00

cora referenced this pull request 2021-09-07 03:41:50 +02:00

Port stripped tree logs from Mineclone2 #80

This repo is archived. You cannot comment on pull requests.

Reviewers

No reviewers

cora

Labels

Clear labels   

blocker

blocks release until resolved

  

bug

  

code quality

  

confirmed

  

critical

crashes, catastrophic bugs

  

discussion

  

high priority

  

incompatibility

incompatible with mcl2

  

incomplete feature

  

invalid

  

low priority

  

missing feauture

  

needs testing

  

packet spam

  

performance

  

project

meta-issues

  

regression

  

translations

  

unconfirmed

  

in review

  

ready for review

No Label

blocker

bug

code quality

confirmed

critical

discussion

high priority

incompatibility

incomplete feature

invalid

low priority

missing feauture

needs testing

packet spam

performance

project

regression

translations

unconfirmed

in review

ready for review

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

3 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Mineclonia/Mineclonia#135

No description provided.