Mineclonia
/
Mineclonia
Archived
12
17
Fork 13
Code Issues 105 Pull Requests 19 Projects Releases Wiki Activity

ITEMS/mcl_core: Fix snow dupe #102

Merged
cora merged 1 commits from fix-snow-dupe into master 2021-06-24 23:46:05 +02:00
Conversation 0 Commits 1 Files Changed 1 +1 -1
erlehmann commented 2021-06-23 13:43:09 +02:00
Owner
Copy Link
Problem

TRACKING ISSUE: #101

Players can duplicate snow layers by picking them up with a tool enchanted with silk touch.

Solution

This patch reduces the amount of snow layers dropped by one.

Details

Snow dupe is the most useless dupe I have seen so far.

Testing Steps
Verify Bug
  1. Create a new world in Mineclonia commit 0816ee38b4 using v7 mapgen with the seed “cold”.
  2. Enter the newly created world in survival mode.
  3. Execute the following commands in the in-game terminal/chat:
  • /grantme give
  • /giveme mcl_farming:hoe_wood
  • /forceenchant singleplayer silk_touch
  1. Verify that you have a wooden hoe enchanted with silk touch in your inventory.
  2. Pick up a snow layer using the wooden hoe enchanted with silk touch.
  3. Verify that you have two snow layers.
Verify Patch
  1. Create a new world in Mieclonia commit 1e42c37895 using v7 mapgen with the seed “cold”.
  2. Enter the newly created world in survival mode.
  3. Execute the following commands in the in-game terminal/chat:
  • /grantme give
  • /giveme mcl_farming:hoe_wood
  • /forceenchant singleplayer silk_touch
  • /giveme mcl_core:snow 36
  1. Verify that you have a wooden hoe enchanted with silk touch and 36 snow layers in your inventory.
  2. Find a grass block and place 1 snow layer on it.
  3. Find a grass block and place 2 snow layers on it.
  4. Find a grass block and place 3 snow layers on it.
  5. Find a grass block and place 4 snow layers on it.
  6. Find a grass block and place 5 snow layers on it.
  7. Find a grass block and place 6 snow layers on it.
  8. Find a grass block and place 7 snow layers on it.
  9. Find a grass block and place 8 snow layers on it.
  10. Verify you have zero snow layers in your inventory.
  11. Pick up all the snow you placed in steps 5 to 12 with the wooden hoe enchanted with silk touch.
  12. Verify you have 36 snow layers in your in inventory.
##### Problem TRACKING ISSUE: https://git.minetest.land/Mineclonia/Mineclonia/issues/101 Players can duplicate snow layers by picking them up with a tool enchanted with silk touch. ##### Solution This patch reduces the amount of snow layers dropped by one. ##### Details Snow dupe is the most useless dupe I have seen so far. ##### Testing Steps ###### Verify Bug 1. Create a new world in Mineclonia commit 0816ee38b49824dab96d9744bd27698c4333e3bf using v7 mapgen with the seed “cold”. 2. Enter the newly created world in survival mode. 3. Execute the following commands in the in-game terminal/chat: - `/grantme give` - `/giveme mcl_farming:hoe_wood` - `/forceenchant singleplayer silk_touch` 4. Verify that you have a wooden hoe enchanted with silk touch in your inventory. 5. Pick up a snow layer using the wooden hoe enchanted with silk touch. 6. Verify that you have two snow layers. ###### Verify Patch 1. Create a new world in Mieclonia commit 1e42c378956b374b8d866dfa5aa0076bc186e099 using v7 mapgen with the seed “cold”. 2. Enter the newly created world in survival mode. 3. Execute the following commands in the in-game terminal/chat: - `/grantme give` - `/giveme mcl_farming:hoe_wood` - `/forceenchant singleplayer silk_touch` - `/giveme mcl_core:snow 36` 4. Verify that you have a wooden hoe enchanted with silk touch and 36 snow layers in your inventory. 5. Find a grass block and place 1 snow layer on it. 6. Find a grass block and place 2 snow layers on it. 7. Find a grass block and place 3 snow layers on it. 8. Find a grass block and place 4 snow layers on it. 9. Find a grass block and place 5 snow layers on it. 10. Find a grass block and place 6 snow layers on it. 11. Find a grass block and place 7 snow layers on it. 12. Find a grass block and place 8 snow layers on it. 13. Verify you have zero snow layers in your inventory. 14. Pick up all the snow you placed in steps 5 to 12 with the wooden hoe enchanted with silk touch. 15. Verify you have 36 snow layers in your in inventory.
erlehmann added 1 commit 2021-06-23 13:43:11 +02:00
1e42c37895
Reduce snow layer silk touch drop amount 
It was possible to duplicate snow layers by placing them and then mining
them using a tool enchanted with silk touch. This commit fixes the “snow
dupe” by reducing the amount of snow layers dropped in this case by one.
cora approved these changes 2021-06-24 23:45:49 +02:00
cora left a comment
Member
Verify Bug
  • 1. Create a new world in Mineclonia commit 0816ee38b4 using v7 mapgen with the seed “cold”.
  • 2. Enter the newly created world in survival mode.
  • 3. Execute the following commands in the in-game terminal/chat:[…]
  • 4. Verify that you have a wooden hoe enchanted with silk touch in your inventory.
  • 5. Pick up a snow layer using the wooden hoe enchanted with silk touch.
  • 6. Verify that you have two snow layers.
Verify Patch
  • 1. Create a new world in Mieclonia commit 1e42c37895 using v7 mapgen with the seed “cold”.
  • 2. Enter the newly created world in survival mode.
  • 3. Execute the following commands in the in-game terminal/chat: […]
  • 4. Verify that you have a wooden hoe enchanted with silk touch and 36 snow layers in your inventory.
  • 5. Find a grass block and place 1 snow layer on it.
  • 6. Find a grass block and place 2 snow layers on it.
  • 7. Find a grass block and place 3 snow layers on it.
  • 8. Find a grass block and place 4 snow layers on it.
  • 9. Find a grass block and place 5 snow layers on it.
  • 10. Find a grass block and place 6 snow layers on it.
  • 11. Find a grass block and place 7 snow layers on it.
  • 12. Find a grass block and place 8 snow layers on it.
  • 13. Verify you have zero snow layers in your inventory.
  • 14. Pick up all the snow you placed in steps 5 to 12 with the wooden hoe enchanted with silk touch.
  • 15. Verify you have 36 snow layers in your in inventory.
###### Verify Bug - [x] 1. Create a new world in Mineclonia commit 0816ee38b49824dab96d9744bd27698c4333e3bf using v7 mapgen with the seed “cold”. - [x] 2. Enter the newly created world in survival mode. - [x] 3. Execute the following commands in the in-game terminal/chat:[…] - [x] 4. Verify that you have a wooden hoe enchanted with silk touch in your inventory. - [x] 5. Pick up a snow layer using the wooden hoe enchanted with silk touch. - [x] 6. Verify that you have two snow layers. ###### Verify Patch - [x] 1. Create a new world in Mieclonia commit 1e42c378956b374b8d866dfa5aa0076bc186e099 using v7 mapgen with the seed “cold”. - [x] 2. Enter the newly created world in survival mode. - [x] 3. Execute the following commands in the in-game terminal/chat: […] - [x] 4. Verify that you have a wooden hoe enchanted with silk touch and 36 snow layers in your inventory. - [x] 5. Find a grass block and place 1 snow layer on it. - [x] 6. Find a grass block and place 2 snow layers on it. - [x] 7. Find a grass block and place 3 snow layers on it. - [x] 8. Find a grass block and place 4 snow layers on it. - [x] 9. Find a grass block and place 5 snow layers on it. - [x] 10. Find a grass block and place 6 snow layers on it. - [x] 11. Find a grass block and place 7 snow layers on it. - [x] 12. Find a grass block and place 8 snow layers on it. - [x] 13. Verify you have zero snow layers in your inventory. - [x] 14. Pick up all the snow you placed in steps 5 to 12 with the wooden hoe enchanted with silk touch. - [x] 15. Verify you have 36 snow layers in your in inventory.
cora merged commit 58fe08332f into master 2021-06-24 23:46:05 +02:00
cora deleted branch fix-snow-dupe 2021-06-24 23:46:17 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
cora
Labels
Clear labels   
blocker

blocks release until resolved

  
bug

   
code quality

   
confirmed

   
critical

crashes, catastrophic bugs

  
discussion

   
high priority

   
incompatibility

incompatible with mcl2

  
incomplete feature

   
invalid

   
low priority

   
missing feauture

   
needs testing

   
packet spam

   
performance

   
project

meta-issues

  
regression

   
translations

   
unconfirmed
  
in review

   
ready for review
No Label
blocker
bug
code quality
confirmed
critical
discussion
high priority
incompatibility
incomplete feature
invalid
low priority
missing feauture
needs testing
packet spam
performance
project
regression
translations
unconfirmed
in review
ready for review
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Mineclonia/Mineclonia#102
No description provided.
Delete Branch "fix-snow-dupe"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?