MineClone5/MineClone5
MineClone5
/
MineClone5
24
30
Fork 36
Code Issues 148 Pull Requests 12 Releases 24 Wiki Activity

New Advancements and Nodes #326

Merged
MrRar merged 12 commits from :PrairieWind_commits into master 2022-06-08 20:02:17 +02:00
Conversation 9 Commits 12 Files Changed 30 +195
Ghost commented 2022-05-30 02:35:16 +02:00
First-time contributor
Copy Link

Advancements:

  • What a Deal!
  • Sweet Dreams
  • Postmortal
  • Fishy Business
  • Serious Dedication

Nodes:

  • Fletching Table
  • Loom
  • Cartography Table

The armor advancements will come later, so for now, this PR is ready to go. Im going to need to tinker with figuring out hwo to activate the armor advacements before I add them.

#### Advancements: - [x] What a Deal! - [x] Sweet Dreams - [x] Postmortal - [x] Fishy Business - [x] Serious Dedication #### Nodes: - [x] Fletching Table - [x] Loom - [x] Cartography Table The armor advancements will come later, so for now, this PR is ready to go. Im going to need to tinker with figuring out hwo to activate the armor advacements before I add them.
Ghost added 4 commits 2022-05-30 02:35:18 +02:00
Ghost added 1 commit 2022-05-30 03:11:57 +02:00
Ghost added 1 commit 2022-05-30 05:07:28 +02:00
Ghost added 1 commit 2022-06-01 03:46:37 +02:00
Ghost added 1 commit 2022-06-01 18:22:46 +02:00
MrRar commented 2022-06-01 19:49:59 +02:00
Owner
Copy Link

Cool stuff! Looms will be a lot of work.

Cool stuff! Looms will be a lot of work.
Ghost commented 2022-06-01 19:51:34 +02:00
Author
First-time contributor
Copy Link

Cool stuff! Looms will be a lot of work.

Indeed sir, but it will worth it. And it should transfer over to mineclone 2 easily, being as thats were the nodes are officially at right now.

> Cool stuff! Looms will be a lot of work. Indeed sir, but it will worth it. And it should transfer over to mineclone 2 easily, being as thats were the nodes are officially at right now.
Ghost commented 2022-06-01 19:53:47 +02:00
Author
First-time contributor
Copy Link

I also need to work on the advancements gui. I would like to divide the advancements based on overworld, nether, end, adventure, or hsubandry, like mc has it. Maybe not the fancy road map yet since not all of the advancements are added. But it would be nice to see them organized.

I also need to work on the advancements gui. I would like to divide the advancements based on overworld, nether, end, adventure, or hsubandry, like mc has it. Maybe not the fancy road map yet since not all of the advancements are added. But it would be nice to see them organized.
cora commented 2022-06-01 21:53:15 +02:00
Owner
Copy Link

Cool stuff! Looms will be a lot of work.

Indeed sir, but it will worth it. And it should transfer over to mineclone 2 easily, being as thats were the nodes are officially at right now.

Please do not break banners ^^

> > Cool stuff! Looms will be a lot of work. > > Indeed sir, but it will worth it. And it should transfer over to mineclone 2 easily, being as thats were the nodes are officially at right now. Please do not break banners ^^
Ghost changed title from WIP: New Advancements and Nodes to New Advancements and Nodes 2022-06-03 18:02:59 +02:00
Ghost changed title from New Advancements and Nodes to New Advancements and Nodes 2022-06-03 18:02:59 +02:00
Ghost changed title from New Advancements and Nodes to New Advancements and Nodes 2022-06-03 18:03:01 +02:00
Ghost added 1 commit 2022-06-03 18:39:34 +02:00
Ghost commented 2022-06-05 00:00:07 +02:00
Author
First-time contributor
Copy Link

This PR is ready for review and being pulled. As I said, I need to work on figuring out how to activate the armor advancements, which will take a bit of tinkering, so that will come in a later, new pull request.

This PR is ready for review and being pulled. As I said, I need to work on figuring out how to activate the armor advancements, which will take a bit of tinkering, so that will come in a later, new pull request.
cora commented 2022-06-05 00:17:23 +02:00
Owner
Copy Link

i cant think of another way than regularly check player invs for armor if they don't have the achievement yet. i mean if you do it like every couple seconds thats not super expensive ig.

i cant think of another way than regularly check player invs for armor if they don't have the achievement yet. i mean if you do it like every couple seconds thats not super expensive ig.
Ghost commented 2022-06-05 00:18:53 +02:00
Author
First-time contributor
Copy Link

i cant think of another way than regularly check player invs for armor if they don't have the achievement yet. i mean if you do it like every couple seconds thats not super expensive ig.

I tried tinkering with the mcl_inventory mod and adding stack on move stuff, but what I had wasnt working, so again, ill do that in another PR.

> i cant think of another way than regularly check player invs for armor if they don't have the achievement yet. i mean if you do it like every couple seconds thats not super expensive ig. I tried tinkering with the mcl_inventory mod and adding stack on move stuff, but what I had wasnt working, so again, ill do that in another PR.
MrRar commented 2022-06-07 14:56:26 +02:00
Owner
Copy Link

I was going to complain that you don't have to actually sleep in a bed to get the sweet dreams achievement but it appears that is how it is in MC as well.

I was going to complain that you don't have to actually sleep in a bed to get the sweet dreams achievement but it appears that is how it is in MC as well.
MrRar requested changes 2022-06-07 22:35:29 +02:00
mods/HUD/mcl_achievements/init.lua
@ -199,6 +199,60 @@ awards.register_achievement("mcl:enterEndPortal", {
icon = "mcl_end_end_stone.png",
})
-- Triggered in mcl_totems
MrRar commented 2022-06-06 20:36:07 +02:00
Owner
Copy Link

Please use tabs for all the regestrations.

Please use tabs for all the regestrations.
Ghost marked this conversation as resolved
mods/ITEMS/mcl_totems/init.lua Outdated
@ -43,6 +43,7 @@ mcl_damage.register_modifier(function(obj, damage, reason)
obj:set_wielded_item(wield)
end
end
awards.unlock(obj:get_player_name(), "mcl:postMortal")
MrRar commented 2022-06-06 20:37:13 +02:00
Owner
Copy Link

Should use tabs

Should use tabs
Ghost marked this conversation as resolved
Ghost added 1 commit 2022-06-08 00:01:42 +02:00
Ghost added 1 commit 2022-06-08 00:02:55 +02:00
Ghost requested review from MrRar 2022-06-08 00:03:38 +02:00
MrRar requested changes 2022-06-08 14:46:28 +02:00
mods/ITEMS/mcl_beds/functions.lua Outdated
@ -76,6 +76,7 @@ local function lay_down(player, pos, bed_pos, state, skip)
-- save respawn position when entering bed
if spawn_mod and mcl_spawn.set_spawn_pos(player, bed_pos, nil) then
minetest.chat_send_player(name, S("New respawn position set!"))
awards.unlock(player:get_player_name(), "mcl:sweetDreams")
MrRar commented 2022-06-08 14:46:20 +02:00
Owner
Copy Link

I'm sorry I should have marked this one as well.
Everything else looks good.

I'm sorry I should have marked this one as well. Everything else looks good.
Ghost commented 2022-06-08 18:46:28 +02:00
Author
First-time contributor
Copy Link

Is this the white space, or do I need to move it? Sorry about all of the white space issues, I had to reset linux, and forgot to turn on the whitespace markers on Geany.

Is this the white space, or do I need to move it? Sorry about all of the white space issues, I had to reset linux, and forgot to turn on the whitespace markers on Geany.
Ghost added 1 commit 2022-06-08 18:55:21 +02:00
Ghost requested review from MrRar 2022-06-08 18:57:48 +02:00
MrRar merged commit da4b867314 into master 2022-06-08 20:02:17 +02:00
Ghost deleted branch PrairieWind_commits 2022-06-08 20:18:54 +02:00
MrRar commented 2022-06-12 01:13:16 +02:00
Owner
Copy Link

The localization stuff needs to be updated for this. I missed this.

The localization stuff needs to be updated for this. I missed this.
Sign in to join this conversation.
Reviewers
No reviewers
MrRar
Labels
Clear labels   
bug

If confirmed

  
contribution inside

PRs, snippets, attaches

  
CRITICAL

Crashes, catastrophic bugs

  
discussion

To discuss some things

  
ELEVATED PRIORITY

Higher than normal

  
fresh ideas

Non-MC features and other things

  
HIGH PRIORITY

Most important

  
missing feature

wee haven't implemented this yet

  
offtopic

Not about MineClone 5 or incorrect

  
requires engine change

minetest would need to be modified

No Label
bug
contribution inside
CRITICAL
discussion
ELEVATED PRIORITY
fresh ideas
HIGH PRIORITY
missing feature
offtopic
requires engine change
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: MineClone5/MineClone5#326
No description provided.
Delete Branch ":PrairieWind_commits"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?