MineClone5/MineClone5
MineClone5
/
MineClone5
24
30
Fork 36
Code Issues 148 Pull Requests 12 Releases 24 Wiki Activity

fix crash and netherite hoes #31

Merged
erlehmann merged 1 commits from fix-crash-hoe-smithing into master 2021-09-10 22:53:36 +02:00
Conversation 4 Commits 1 Files Changed 1 +1 -1
cora commented 2021-09-10 21:51:15 +02:00
Owner
Copy Link

The item registration in mcl_farming for diamond hoes contains the wrong
upgrade_item id (mcl_tools:hoe_netherite, should me mcl_farming:). This
PR changes that.

Testing

Relevant itemid's for /give:

  • mcl_farming:hoe_diamond
  • mcl_smithing_table:table
  • mcl_nether:netherite_ingot

Verify Bug

  1. Open MineClone5 on commit 2c231559be
  2. Give yourself a smithing table and place it
  3. put a diamond hoe in the first inventory slot
  4. observe the server crashing

Verify Patch

  1. Open MineClone5 on commit 7ae73bcf47
  2. Give yourself a smithing table and place it (you can use the one you previosly placed)
  3. put a diamond hoe in the first inventory slot
  4. put a netherite ingot in the second inventory slot
  5. Verify you can take a netherite hoe from the third slot.
  6. Verify the game did not crash
The item registration in mcl_farming for diamond hoes contains the wrong upgrade_item id (mcl_tools:hoe_netherite, should me mcl_farming:). This PR changes that. ### Testing Relevant itemid's for /give: * mcl_farming:hoe_diamond * mcl_smithing_table:table * mcl_nether:netherite_ingot #### Verify Bug 1. Open MineClone5 on commit 2c231559be 2. Give yourself a smithing table and place it 3. put a diamond hoe in the first inventory slot 4. observe the server crashing #### Verify Patch 1. Open MineClone5 on commit 7ae73bcf47 2. Give yourself a smithing table and place it (you can use the one you previosly placed) 3. put a diamond hoe in the first inventory slot 4. put a netherite ingot in the second inventory slot 5. Verify you can take a netherite hoe from the third slot. 6. Verify the game did not crash
cora added 1 commit 2021-09-10 21:51:18 +02:00
7ae73bcf47 fix crash and netherite hoes 
The item registration in mcl_farming for diamond hoes contains the wrong
upgrade_item id (mcl_tools:hoe_netherite, should me mcl_farming:). This
commit changes that.
erlehmann commented 2021-09-10 22:21:28 +02:00
Collaborator
Copy Link

I'll test it now.

I'll test it now.
erlehmann commented 2021-09-10 22:53:23 +02:00
Collaborator
Copy Link

Fast bugfixing! Excellent patch! Love the commit! Thank you!

Verify Bug
  • Open MineClone5 on commit 2c231559be
  • Give yourself a smithing table and place it
  • put a diamond hoe in the first inventory slot
  • observe the server crashing
Verify Patch
  • Open MineClone5 on commit 7ae73bcf47
  • Give yourself a smithing table and place it (you can use the one you previosly placed)
  • put a diamond hoe in the first inventory slot
  • put a netherite ingot in the second inventory slot
  • Verify you can take a netherite hoe from the third slot.
  • Verify the game did not crash
Fast bugfixing! Excellent patch! Love the commit! Thank you! ##### Verify Bug - [x] Open MineClone5 on commit 2c231559be - [x] Give yourself a smithing table and place it - [x] put a diamond hoe in the first inventory slot - [x] observe the server crashing ##### Verify Patch - [x] Open MineClone5 on commit 7ae73bcf47 - [x] Give yourself a smithing table and place it (you can use the one you previosly placed) - [x] put a diamond hoe in the first inventory slot - [x] put a netherite ingot in the second inventory slot - [x] Verify you can take a netherite hoe from the third slot. - [x] Verify the game did not crash
erlehmann merged commit 0b6420c9f5 into master 2021-09-10 22:53:36 +02:00
erlehmann deleted branch fix-crash-hoe-smithing 2021-09-10 22:55:38 +02:00
erlehmann commented 2021-09-10 22:57:29 +02:00
Collaborator
Copy Link

A+++ Fantastic! Highly Recommended!

GREAT PATCHING EXCEPTIONAL QUALITY 5 STAR PROGRAMMER

Delivered on time, accurate description, works perfectly. Very pleased.

A+++ Fantastic! Highly Recommended! GREAT PATCHING EXCEPTIONAL QUALITY 5 STAR PROGRAMMER Delivered on time, accurate description, works perfectly. Very pleased.
cora commented 2021-09-10 22:58:49 +02:00
Author
Owner
Copy Link

lol

lol
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

If confirmed

  
contribution inside

PRs, snippets, attaches

  
CRITICAL

Crashes, catastrophic bugs

  
discussion

To discuss some things

  
ELEVATED PRIORITY

Higher than normal

  
fresh ideas

Non-MC features and other things

  
HIGH PRIORITY

Most important

  
missing feature

wee haven't implemented this yet

  
offtopic

Not about MineClone 5 or incorrect

  
requires engine change

minetest would need to be modified

No Label
bug
contribution inside
CRITICAL
discussion
ELEVATED PRIORITY
fresh ideas
HIGH PRIORITY
missing feature
offtopic
requires engine change
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: MineClone5/MineClone5#31
No description provided.
Delete Branch "fix-crash-hoe-smithing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?