MineClone5/MineClone5
MineClone5
/
MineClone5
24
30
Fork 36
Code Issues 148 Pull Requests 12 Releases 24 Wiki Activity

Use baby_size to scale chick size on hatching instead of dividing by 2 #305

Merged
kay27 merged 1 commits from balazsszalab/MineClone5:master into master 2022-05-06 01:06:30 +02:00
Conversation 8 Commits 1 Files Changed 1 +7 -7
balazsszalab commented 2022-05-03 23:23:11 +02:00
Contributor
Copy Link

Using baby_size to scale chick size on hatching keeps the sizes of chickens consintent independently of the method of their spawning. This way changing baby_size of chickens produces the same sized chicks from breeding as well as from hatching.

Using baby_size to scale chick size on hatching keeps the sizes of chickens consintent independently of the method of their spawning. This way changing baby_size of chickens produces the same sized chicks from breeding as well as from hatching.
balazsszalab added 1 commit 2022-05-03 23:23:14 +02:00
cora commented 2022-05-03 23:46:13 +02:00
Owner
Copy Link

oh no does this fix giant mobs ?

oh no does this fix giant mobs ?
cora commented 2022-05-03 23:46:39 +02:00
Owner
Copy Link

it was fun while it lasted i suppose :)

it was fun while it lasted i suppose :)
MrRar commented 2022-05-03 23:52:08 +02:00
Owner
Copy Link

We shouldn't really be scaling down adults to make babies at all because babies need big heads. There's no way to scale a bone in Minetest (that I know of) so they would ideally use a different mesh.

We shouldn't really be scaling down adults to make babies at all because babies need big heads. There's no way to scale a bone in Minetest (that I know of) so they would ideally use a different mesh.
MrRar commented 2022-05-03 23:53:41 +02:00
Owner
Copy Link

@cora I haven't seen that. Sounds cool.

@cora I haven't seen that. Sounds cool.
cora commented 2022-05-04 11:40:48 +02:00
Owner
Copy Link

  • Put baby mob in boat
  • Wait for it to grow

might already be fixed in mcl5 though .. no idea havent tried this in a while.

![](https://mister-muffin.de/p/HvY0.png) * Put baby mob in boat * Wait for it to grow might already be fixed in mcl5 though .. no idea havent tried this in a while.
cora commented 2022-05-04 11:41:06 +02:00
Owner
Copy Link

It's only visual

It's only visual
balazsszalab commented 2022-05-04 22:57:39 +02:00
Author
Contributor
Copy Link

@cora No it does not fix it. Actually, I was trying to make giant chicks when I noticed that chiks have different sizes when they are hatched from an egg or born by breeding two chickens. The fix just ensures that chicks born both ways have the same size.

@cora No it does not fix it. Actually, I was trying to make giant chicks when I noticed that chiks have different sizes when they are hatched from an egg or born by breeding two chickens. The fix just ensures that chicks born both ways have the same size.
kay27 commented 2022-05-05 00:13:38 +02:00
Owner
Copy Link

I don't think it's fixed. But why the PR is WIP? Looks good enough to me, could you please remove WIP: prefix if it's ready?

I don't think it's fixed. But why the PR is WIP? Looks good enough to me, could you please remove WIP: prefix if it's ready?
balazsszalab changed title from WIP: Use baby_size to scale chick size on hatching instead of dividing by 2 to Use baby_size to scale chick size on hatching instead of dividing by 2 2022-05-05 21:04:26 +02:00
kay27 merged commit 13dc68f40f into master 2022-05-06 01:06:30 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

If confirmed

  
contribution inside

PRs, snippets, attaches

  
CRITICAL

Crashes, catastrophic bugs

  
discussion

To discuss some things

  
ELEVATED PRIORITY

Higher than normal

  
fresh ideas

Non-MC features and other things

  
HIGH PRIORITY

Most important

  
missing feature

wee haven't implemented this yet

  
offtopic

Not about MineClone 5 or incorrect

  
requires engine change

minetest would need to be modified

No Label
bug
contribution inside
CRITICAL
discussion
ELEVATED PRIORITY
fresh ideas
HIGH PRIORITY
missing feature
offtopic
requires engine change
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: MineClone5/MineClone5#305
No description provided.
Delete Branch "balazsszalab/MineClone5:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?