Remove music interruptions #3529

ancientmarinerdev · 2023-03-10T04:10:00+01:00

ancientmarinerdev commented

2023-03-10 04:10:00 +01:00

Partial fix for #3520

Removing the interruptions for whether or getting overground.

Testing

If a song has played, it won't play again that day, so you have to:

/time 23900

wait a little, then:

/time 9000

Going undergound, with song playing won't change song.
Weather change, or good weather won't change song.

Partial fix for #3520 Removing the interruptions for whether or getting overground. ### Testing If a song has played, it won't play again that day, so you have to: /time 23900 wait a little, then: /time 9000 Going undergound, with song playing won't change song. Weather change, or good weather won't change song.

ancientmarinerdev added the

sounds

label 2023-03-10 04:10:00 +01:00

ancientmarinerdev changed title from ~~WIP: Remove music interruptions~~ to Remove music interruptions

2023-03-11 00:56:28 +01:00

FossFanatic commented

2023-03-11 16:08:46 +01:00

What is is_hp_changed for? Does it just stop music when you take damage or something? Seems like a mood killer in multiple ways if that's the case.

What is `is_hp_changed` for? Does it just stop music when you take damage or something? Seems like a mood killer in multiple ways if that's the case.

ancientmarinerdev commented

2023-03-11 16:36:45 +01:00

What is is_hp_changed for? Does it just stop music when you take damage or something? Seems like a mood killer in multiple ways if that's the case.

I guess that is a fair point. I can remove that too.

> What is `is_hp_changed` for? Does it just stop music when you take damage or something? Seems like a mood killer in multiple ways if that's the case. I guess that is a fair point. I can remove that too.

ancientmarinerdev commented

2023-03-11 23:18:14 +01:00

What is is_hp_changed for? Does it just stop music when you take damage or something? Seems like a mood killer in multiple ways if that's the case.

I have changed that now.

> What is `is_hp_changed` for? Does it just stop music when you take damage or something? Seems like a mood killer in multiple ways if that's the case. I have changed that now.

👍 2

ancientmarinerdev force-pushed fix_music_interruptions from b831d1c2e2 to 03d8363ed1

2023-03-13 00:09:55 +01:00

Compare

ancientmarinerdev added this to the 0.83.0 - Safe and Sound milestone 2023-03-13 00:10:29 +01:00

ancientmarinerdev referenced this issue from a commit

2023-03-13 00:13:45 +01:00

Merge pull request 'Remove music interruptions' (#3529) from fix_music_interruptions into master

ancientmarinerdev merged commit b49828e9cb into master

2023-03-13 00:13:46 +01:00

ancientmarinerdev deleted branch fix_music_interruptions

2023-03-13 00:13:53 +01:00