Jukebox should work with background music #3520

New Issue

Ghost · 2023-03-08T18:26:22+01:00

Ghost commented

2023-03-08 18:26:22 +01:00

The music in-game gets cut off suddenly in certain scenarios.

The only time that the music should get interrupted, is when you change dimensions or play a music disc, and those are the only cases where it should do so.

The music in-game gets cut off suddenly in certain scenarios. The only time that the music should get interrupted, is when you change dimensions or play a music disc, and those are the only cases where it should do so.

👍 1

Ghost added the

sounds

annoying

enhancement

labels 2023-03-08 18:26:22 +01:00

Ghost changed title from ~~Remove Music Interruptions~~ to Remove Many Music Interruptions

2023-03-08 18:46:28 +01:00

ancientmarinerdev added the

#P3: elevated

label 2023-03-08 23:23:55 +01:00

Ghost commented

2023-03-09 13:09:18 +01:00

The music should also not be prevented from playing at all when it's nighttime or raining.

ancientmarinerdev commented

2023-03-09 13:40:36 +01:00

The music should also not be prevented from playing at all when it's nighttime or raining.

Point taken, that part is legacy code and I can imagine it probably isn't the ideal situation.

> The music should also not be prevented from playing at all when it's nighttime or raining. Point taken, that part is legacy code and I can imagine it probably isn't the ideal situation.

Ghost commented

2023-03-09 15:21:47 +01:00

The last complaint that I have, is that the new music is way too quiet. It feels as if the music is playing in a room next to me.

I need to crank the volume way up to even hear anything, and that comes with the risk of me getting startled by any sudden sounds in-game which are now extremely loud.

I would like for the music to be at least two times louder than it currently is.

The last complaint that I have, is that the new music is way too quiet. It feels as if the music is playing in a room next to me. I need to crank the volume way up to even hear anything, and that comes with the risk of me getting startled by any sudden sounds in-game which are now extremely loud. I would like for the music to be at least two times louder than it currently is.

ancientmarinerdev added this to the 0.83.0 - Safe and Sound milestone 2023-03-09 19:18:31 +01:00

ancientmarinerdev referenced this issue

2023-03-10 04:10:00 +01:00

Remove music interruptions #3529

SmokeyDope commented

2023-03-13 20:35:19 +01:00

The last complaint that I have, is that the new music is way too quiet. It feels as if the music is playing in a room next to me.

I need to crank the volume way up to even hear anything, and that comes with the risk of me getting startled by any sudden sounds in-game which are now extremely loud.

I would like for the music to be at least two times louder than it currently is.

Ideally there should be a way to change music gain in the settings, until thats a thing maybe we can bump up the gain of the songs themselves in an audio editor? Ive played around with audacity in the past, its something I could probably do if th. Would this be a decent short term solution?

On a side note, can you define the gain of songs the same way as a regular sound by adding the gain paramater to the end?

song_name = "songname.ogg", gain=2.0,

> The last complaint that I have, is that the new music is way too quiet. It feels as if the music is playing in a room next to me. > > I need to crank the volume way up to even hear anything, and that comes with the risk of me getting startled by any sudden sounds in-game which are now extremely loud. > > I would like for the music to be at least two times louder than it currently is. Ideally there should be a way to change music gain in the settings, until thats a thing maybe we can bump up the gain of the songs themselves in an audio editor? Ive played around with audacity in the past, its something I could probably do if th. Would this be a decent short term solution? On a side note, can you define the gain of songs the same way as a regular sound by adding the gain paramater to the end? ``` song_name = "songname.ogg", gain=2.0, ```

Ghost commented

2023-03-13 20:44:34 +01:00

Around double the loudness sounds good to me. That's about on par with Minecraft's music loudness as well.

Please try not to ruin the audial quality or making the filesizes too big though.

Around double the loudness sounds good to me. That's about on par with Minecraft's music loudness as well. Please try not to ruin the audial quality or making the filesizes too big though.

ancientmarinerdev commented

2023-03-14 23:52:56 +01:00

Diminixed has volunteered to look into the levels for songs.

Music discs logic needs to be checked to see if it does stop songs before starting it.

Diminixed has volunteered to look into the levels for songs. Music discs logic needs to be checked to see if it does stop songs before starting it.

ancientmarinerdev modified the milestone from 0.83.0 - Safe and Sound to 3 - Near future

2023-03-15 17:41:09 +01:00

ancientmarinerdev referenced this issue

2023-03-19 21:18:32 +01:00

Diminixed normalized volume levels of songs + 2 new tracks, 2 updated versions! #3564

ancientmarinerdev modified the milestone from 3 - Near future to 0.83.0 - Safe and Sound

2023-03-23 06:32:10 +01:00

ancientmarinerdev commented

2023-03-26 01:01:40 +01:00

Volume levels has been merged, so this is a ticket for music discs and Jukebox to ensure it works with game music. Stops it, and background music doesn't play under jukebox is finished.

ancientmarinerdev changed title from ~~Remove Many Music Interruptions~~ to Jukebox should work with background music

2023-03-26 01:02:27 +01:00

ancientmarinerdev added

#P4 priority: medium

and removed

#P3: elevated

labels 2023-03-26 01:02:57 +01:00

Ghost commented

2023-03-26 01:31:39 +01:00

Interesting, new priority tag names.

Ghost modified the milestone from 0.83.0 - Safe and Sound to 0.84.0 - Very Nice

2023-04-15 22:51:33 +02:00