Fixed weather not clearing after sleep #3414

Ghost · 2023-02-07T18:57:45+01:00

Ghost commented

2023-02-07 18:57:45 +01:00

First-time contributor

When it is raining, the weather doesn't clear after you sleep. Hopefully this fixes it correctly. Yes, it looks strange, but I got funky results from testing it when coded "clean".

Testing

Place a bed, set time to night time, and weather to rain or snow. Sleep. On master, it should still be raining or snowing in the morning. On branch, it should be clear or just clearing up.

Issues Fixed

This PR Fixes #3411.

When it is raining, the weather doesn't clear after you sleep. Hopefully this fixes it correctly. Yes, it looks strange, but I got funky results from testing it when coded "clean". #### Testing Place a bed, set time to night time, and weather to rain or snow. Sleep. On master, it should still be raining or snowing in the morning. On branch, it should be clear or just clearing up. #### Issues Fixed This PR Fixes #3411.

❤️ 2

Ghost force-pushed rain_bed_skip from 8a0b58463c to b1a66d76f7

2023-02-09 19:22:58 +01:00

Compare

ancientmarinerdev commented

2023-02-10 02:47:09 +01:00

A side note from master, day rain is pitch black, night rain is light. Any ideas? It's bugging me :).

ancientmarinerdev approved these changes 2023-02-10 02:50:39 +01:00

ancientmarinerdev left a comment

Looks good and works.

Thanks for picking this up, it was a little annoying :).

Looks good and works. Thanks for picking this up, it was a little annoying :).

ancientmarinerdev force-pushed rain_bed_skip from b1a66d76f7 to 70fb4f8a0d

2023-02-10 02:51:38 +01:00

Compare

ancientmarinerdev added this to the 0.83.0 - Safe and Sound milestone 2023-02-10 02:51:43 +01:00

Ghost commented

2023-02-10 02:52:44 +01:00

First-time contributor

A side note from master, day rain is pitch black, night rain is light. Any ideas? It's bugging me :).

Honestly, I have no idea. Its something that erked cora's hide too.

> A side note from master, day rain is pitch black, night rain is light. Any ideas? It's bugging me :). Honestly, I have no idea. Its something that erked cora's hide too.

👍 1

Ghost commented

2023-02-10 02:54:48 +01:00

First-time contributor

Jeez, merge conflict checking has been slow lately.

ancientmarinerdev merged commit c1d5d4280e into master

2023-02-10 03:00:25 +01:00

ancientmarinerdev referenced this issue from a commit

2023-02-10 03:00:25 +01:00

Merge pull request 'Fixed weather not clearing after sleep' (#3414) from rain_bed_skip into master

ancientmarinerdev deleted branch rain_bed_skip

2023-02-10 03:00:41 +01:00