• Joined on 2024-05-01
Bram commented on pull request VoxeLibre/VoxeLibre#4617 2024-09-07 13:47:25 +02:00
Add dripstone to VoxeLibre

The dripstone mod has been accepted on ContentDB. It can now be safely assumed that the dripstone namespace is reserved for this mod.

Bram pushed to dripstone at Bram/VoxeLibre 2024-09-05 01:24:18 +02:00
6ce92620f4 Wet sponges create lava droplets
57b8e6e8f3 Nether lava creates lava droplets
6c50640821 Lava droplets burn away flowers
b26030fcc7 Water droplets turn farmland into wet farmland
a3922a4394 Implement API architecture feedback
Compare 5 commits »
Bram pushed to dripstone at Bram/VoxeLibre 2024-09-05 01:02:07 +02:00
18d78c105c Wet sponges create lava droplets
9c92c57358 Nether lava creates lava droplets
a8238cc539 Lava droplets burn away flowers
d88ca04581 Water droplets turn farmland into wet farmland
Compare 4 commits »
Bram pushed to dripstone at Bram/VoxeLibre 2024-09-04 21:47:31 +02:00
c009c89c8a Implement API architecture feedback
Bram commented on pull request VoxeLibre/VoxeLibre#4617 2024-09-04 17:54:09 +02:00
Add dripstone to VoxeLibre

It's just a constant difference though - so just like the h value, I'm more than happy to change the value to 4w + 2 or even 2w + 1.

Bram commented on pull request VoxeLibre/VoxeLibre#4617 2024-09-04 17:53:12 +02:00
Add dripstone to VoxeLibre

I think you're forgetting to square the 2:

2(w + 1) * 2(w + 1) * h - 2w * 2w * h
4(w + 1)²           * h - 4w²     * h
... rewrites to ...
h(4(w+1)²        - 4w²)
h(4(w² + 2w + 1) -…
Bram commented on pull request VoxeLibre/VoxeLibre#4617 2024-09-04 16:05:59 +02:00
Add dripstone to VoxeLibre

While noordstar_dripstone.add_droplet_source is an explicit declaration that a node can create droplets, using secondary features such as liquidity and group names is an implicit declaration.…

Bram commented on pull request VoxeLibre/VoxeLibre#4617 2024-09-04 15:20:31 +02:00
Add dripstone to VoxeLibre

In this case, we're dealing with truthy values and I'm not sure if it improves readability.

Also, wouldn't this return false instead of nil?

Bram commented on pull request VoxeLibre/VoxeLibre#4617 2024-09-04 15:18:00 +02:00
Add dripstone to VoxeLibre

As per the function internal.nodebox_of_size(w), the width of the nodebox of size w is 2*w. As a result, the volume of a dripstone node of size w is 2w*2w*h.

So in order to grow from…

Bram commented on pull request VoxeLibre/VoxeLibre#4617 2024-09-04 15:07:05 +02:00
Add dripstone to VoxeLibre

I have several reasons why I implemented it this way:

  • The code contribution guidelines states to not declare functions as an assignment.
  • The method adds extra security. Exposed functions can…
Bram commented on pull request VoxeLibre/VoxeLibre#4617 2024-09-04 00:10:42 +02:00
Add dripstone to VoxeLibre

I've finished the refactor which removes most of the repetition, and makes the mod a lot more customizable. Here's the [updated API documentation with images](https://git.noordstar.me/Bram/dripston

Bram pushed to dripstone at Bram/VoxeLibre 2024-09-03 23:59:39 +02:00
7a751fa699 Update noordstar_dripstone with refactor for PR #4617
Bram commented on pull request VoxeLibre/VoxeLibre#4617 2024-09-02 05:12:16 +02:00
Add dripstone to VoxeLibre

I've spent some time considering the options, and I might know a way to make the code less repetitive. I am working on a refactor.

Bram pushed to dripstone at Bram/VoxeLibre 2024-08-31 19:42:08 +02:00
144979e938 Resolve missing tabulation
Bram pushed to dripstone at Bram/VoxeLibre 2024-08-31 19:38:53 +02:00
22e0d3e67f Reformat noordstar_dripstone mod to pull request #4617 feedback
8cabf356bc Adjust dripstone mod to pull request #4617 feedback
Compare 2 commits »
Bram commented on pull request VoxeLibre/VoxeLibre#4617 2024-08-31 14:16:39 +02:00
Add dripstone to VoxeLibre

Most of the feedback looks good, and I will update the code accordingly.

I'm a bit skeptical of implementing tables through which can be looped in order to avoid repetition. The dripstone has a…

Bram created pull request VoxeLibre/VoxeLibre#4617 2024-08-31 01:30:51 +02:00
Add dripstone to VoxeLibre
Bram pushed to dripstone at Bram/VoxeLibre 2024-08-31 01:12:49 +02:00
73d27b32de Adjust dripstone growth rate
Bram pushed to dripstone at Bram/VoxeLibre 2024-08-31 00:59:36 +02:00
84b501b6e6 Make cauldrons catch dripstone droplets
4005489822 Add noordstar_dripstone mod
Compare 2 commits »
Bram created branch dripstone in Bram/VoxeLibre 2024-08-31 00:59:36 +02:00