Araca Araca
Araca pushed to durability-tooltip at Araca/MineClone2 2024-05-02 21:56:55 +02:00
2c25c94199 use math.ceil() instead of math.round()
50f3f2c5c8 Remove "Mining" word for durability in tooltip
bb0080617a Add durability for bow & fishing rod
c501ff6e1d Add remaining use of a tool/weapon in tooltips
81ca224bb8 Add wear to shears used to harvest comb from a beehive (#4251)
Compare 121 commits »
Araca commented on pull request VoxeLibre/VoxeLibre#4196 2024-04-15 11:28:35 +02:00
Add remaining use of a tool/weapon in tooltips

same here

Araca commented on pull request VoxeLibre/VoxeLibre#4196 2024-04-15 11:28:24 +02:00
Add remaining use of a tool/weapon in tooltips

I tested. It's doesn't solve the mentioned issue because here it's not the compute of the remaining use but the total uses, which is displayed right.

Araca commented on pull request VoxeLibre/VoxeLibre#4196 2024-04-15 11:12:13 +02:00
Add remaining use of a tool/weapon in tooltips

Based on our discussion MineClone2/MineClone2#4196 (comment) I removed the notion of "Mining Durability", now it's only "Durability". So it's not used anymore

Araca commented on pull request VoxeLibre/VoxeLibre#4196 2024-03-29 11:15:03 +01:00
Add remaining use of a tool/weapon in tooltips

I don't think it's a good solution to use a different method for the first case. It's like hiding a bug.

and otherwise using math.ceil with (use - 1) to correctly show 59/60 after the first…

Araca commented on pull request VoxeLibre/VoxeLibre#4188 2024-03-28 17:47:46 +01:00
Add possibility to edit a sign

Nice find. I changed that. Thanks

Araca pushed to edit-sign at Araca/MineClone2 2024-03-28 17:47:28 +01:00
ae433bcb6e espace old_text for sign formspec
Araca commented on pull request VoxeLibre/VoxeLibre#4183 2024-03-28 17:39:43 +01:00
New mcl_copper and new 1.21 MC blocks

But you can still merge this, no ?

Araca commented on pull request VoxeLibre/VoxeLibre#4183 2024-03-28 17:38:08 +01:00
New mcl_copper and new 1.21 MC blocks

Oh ok, thanks for the details

Araca pushed to durability-tooltip at Araca/MineClone2 2024-03-28 17:37:26 +01:00
30538e31b7 use math.ceil() instead of math.round()
Araca commented on pull request VoxeLibre/VoxeLibre#4196 2024-03-28 17:36:32 +01:00
Add remaining use of a tool/weapon in tooltips

I think your use of math.round() instead of math.ceil() allows tooltips that read "Durability: 0/60" to happen. Changing this in 3 spots should fix this.

This is true. But please note that by…

Araca commented on pull request VoxeLibre/VoxeLibre#4183 2024-03-28 17:23:04 +01:00
New mcl_copper and new 1.21 MC blocks

why is this PR closed please ? It was so close to be finalized

Araca commented on pull request VoxeLibre/VoxeLibre#4196 2024-03-06 18:36:37 +01:00
Add remaining use of a tool/weapon in tooltips

I mean, durability does affect both, only speed doesn't, so revert speed but not durability.

Done, I remove "Mining" for the durability

![image](/attachments/0977890e-d587-4cd8-aef5-980c0c2…

Araca pushed to durability-tooltip at Araca/MineClone2 2024-03-06 18:33:47 +01:00
28e1d00830 Remove "Mining" word for durability in tooltip
Araca commented on pull request VoxeLibre/VoxeLibre#4196 2024-03-06 14:55:19 +01:00
Add remaining use of a tool/weapon in tooltips

@the-real-herowl I knew it could lead to debate, this is why I did it in a separated commit. So if I understand well, you suggest to revert the last commit ?

Araca commented on pull request VoxeLibre/VoxeLibre#4196 2024-03-06 10:14:40 +01:00
Add remaining use of a tool/weapon in tooltips

In the last commit, I removed the notion of "Mining" for Durability & Speed in tooltip and factoid. It's to avoid having "mining speed" for sword for example

NOW ![image](/attachments/6a820…

Araca pushed to durability-tooltip at Araca/MineClone2 2024-03-06 10:12:55 +01:00
4af961e3df Remove "mining" from durability & speed because it affects sword too
Araca commented on pull request VoxeLibre/VoxeLibre#4196 2024-03-06 09:21:26 +01:00
Add remaining use of a tool/weapon in tooltips

Thanks for the check and your remarl. You are right. I added this line to force tooltip update, but your point about recursion make me check again and it was a mistake. I updated my commit, it…

Araca pushed to durability-tooltip at Araca/MineClone2 2024-03-06 09:19:18 +01:00
6ff068d922 Add durability for bow & fishing rod
Araca commented on pull request VoxeLibre/VoxeLibre#4196 2024-03-05 15:30:42 +01:00
Add remaining use of a tool/weapon in tooltips

Which line crashes the game exactly?

ModError: Runtime error from mod 'tt' in callback on_mods_loaded(): stack overflow
stack traceback:
	[C]: in function 'get_name'
	.../games/minec…