From 379dd847eedc1c93a28be53ca4a6c1504cc2382e Mon Sep 17 00:00:00 2001 From: Rootyjr <41842051+Rootyjr@users.noreply.github.com> Date: Tue, 30 Jul 2019 21:22:28 -0500 Subject: [PATCH 1/7] Completely rework fishing rod to simulate a much more MC-like behaviour --- mods/ITEMS/mcl_fishing/init.lua | 309 +++++++++++++++++- .../textures/mcl_fishing_bobber.png | Bin 0 -> 2281 bytes .../textures/mcl_fishing_fishing_rod.png | Bin 299 -> 2397 bytes mods/ITEMS/mcl_throwing/init.lua | 45 +++ 4 files changed, 342 insertions(+), 12 deletions(-) create mode 100644 mods/ITEMS/mcl_fishing/textures/mcl_fishing_bobber.png diff --git a/mods/ITEMS/mcl_fishing/init.lua b/mods/ITEMS/mcl_fishing/init.lua index 0c23daae74..0d34779d41 100644 --- a/mods/ITEMS/mcl_fishing/init.lua +++ b/mods/ITEMS/mcl_fishing/init.lua @@ -1,4 +1,9 @@ local S = minetest.get_translator("mcl_fishing") +local mod_throwing = minetest.get_modpath("mcl_throwing") + +local entity_mapping = { + ["mcl_fishing:bobber"] = "mcl_fishing:bobber_entity", +} local go_fishing = function(itemstack, user, pointed_thing) if pointed_thing and pointed_thing.under then @@ -83,26 +88,308 @@ local go_fishing = function(itemstack, user, pointed_thing) return nil end +local bobber_ENTITY={ + physical = false, + timer=0, + textures = {"mcl_fishing_bobber.png"}, + visual_size = {x=0.5, y=0.5}, + collisionbox = {0.45,0.45,0.45,0.45,0.45,0.45}, + pointable = false, + + get_staticdata = get_staticdata, + on_activate = on_activate, + + _lastpos={}, + _dive = false, + _waittick = nil, + _tick = 0, + player=nil, + _oldy = nil, + objtype="fishing", +} + +local fish = function(itemstack, player) + local pos = player:get_pos() + + local objs = minetest.get_objects_inside_radius(pos, 250) + local num = 0 + local ent = nil + local noent = true + + --Check for bobber if so handle. + for n = 1, #objs do + ent = objs[n]:get_luaentity() + if ent then + if ent.player and ent.objtype=="fishing" then + if (player:get_player_name() == ent.player) then + noent = false + if ent._dive == true then + local itemname + local itemcount = 1 + local itemwear = 0 + -- FIXME: Maybe use a better seeding + local pr = PseudoRandom(os.time() * math.random(1, 100)) + local r = pr:next(1, 100) + if r <= 85 then + -- Fish + items = mcl_loot.get_loot({ + items = { + { itemstring = "mcl_fishing:fish_raw", weight = 60 }, + { itemstring = "mcl_fishing:salmon_raw", weight = 25 }, + { itemstring = "mcl_fishing:clownfish_raw", weight = 2 }, + { itemstring = "mcl_fishing:pufferfish_raw", weight = 13 }, + } + }, pr) + elseif r <= 95 then + -- Junk + items = mcl_loot.get_loot({ + items = { + { itemstring = "mcl_core:bowl", weight = 10 }, + { itemstring = "mcl_fishing:fishing_rod", weight = 2, wear_min = 6554, wear_max = 65535 }, -- 10%-100% damage + { itemstring = "mcl_mobitems:leather", weight = 10 }, + { itemstring = "3d_armor:boots_leather", weight = 10, wear_min = 6554, wear_max = 65535 }, -- 10%-100% damage + { itemstring = "mcl_mobitems:rotten_flesh", weight = 10 }, + { itemstring = "mcl_core:stick", weight = 5 }, + { itemstring = "mcl_mobitems:string", weight = 5 }, + { itemstring = "mcl_potions:potion_water", weight = 10 }, + { itemstring = "mcl_mobitems:bone", weight = 10 }, + { itemstring = "mcl_dye:black", weight = 1, amount_min = 10, amount_max = 10 }, + { itemstring = "mcl_mobitems:string", weight = 10 }, -- TODO: Tripwire Hook + } + }, pr) + else + -- Treasure + items = mcl_loot.get_loot({ + items = { + -- TODO: Enchanted Bow + { itemstring = "mcl_bows:bow", wear_min = 49144, wear_max = 65535 }, -- 75%-100% damage + -- TODO: Enchanted Book + { itemstring = "mcl_books:book" }, + -- TODO: Enchanted Fishing Rod + { itemstring = "mcl_fishing:fishing_rod", wear_min = 49144, wear_max = 65535 }, -- 75%-100% damage + { itemstring = "mcl_mobs:nametag", }, + { itemstring = "mcl_mobitems:saddle", }, + { itemstring = "mcl_flowers:waterlily", }, + } + }, pr) + end + local item + if #items >= 1 then + item = ItemStack(items[1]) + else + item = ItemStack() + end + local inv = player:get_inventory() + if inv:room_for_item("main", item) then + inv:add_item("main", item) + end + if not minetest.settings:get_bool("creative_mode") then + local idef = itemstack:get_definition() + itemstack:add_wear(65535/65) -- 65 uses + if itemstack:get_count() == 0 and idef.sound and idef.sound.breaks then + minetest.sound_play(idef.sound.breaks, {pos=player.get_pos(), gain=0.5}) + end + end + end + --Check if object is on land. + local epos = ent.object:get_pos() + epos.y = math.floor(epos.y) + local node = minetest.get_node(epos) + local def = minetest.registered_nodes[node.name] + if def.walkable then + if not minetest.settings:get_bool("creative_mode") then + local idef = itemstack:get_definition() + itemstack:add_wear((65535/65)*2) -- if so and not creative then wear double like in MC. + if itemstack:get_count() == 0 and idef.sound and idef.sound.breaks then + minetest.sound_play(idef.sound.breaks, {pos=player.get_pos(), gain=0.5}) + end + end + end + --Destroy bobber. + ent.object:remove() + return itemstack + end + end + end + end + --Check for flying bobber. + for n = 1, #objs do + ent = objs[n]:get_luaentity() + if ent then + if ent._thrower and ent.objtype=="fishing" then + if player:get_player_name() == ent._thrower then + noent = false + break + end + end + end + end + --If no bobber or flying_bobber exists then throw bobber. + if noent == true then + local playerpos = player:get_pos() + local dir = player:get_look_dir() + local obj = mcl_throwing.throw("mcl_throwing:flying_bobber", {x=playerpos.x, y=playerpos.y+1.5, z=playerpos.z}, dir, 15) + obj:get_luaentity()._thrower = player:get_player_name() + end +end + +-- Movement function of bobber +local bobber_on_step = function(self, dtime) + self.timer=self.timer+dtime + local epos = self.object:get_pos() + epos.y = math.floor(epos.y) + local node = minetest.get_node(epos) + local def = minetest.registered_nodes[node.name] + + --If we have no player remove self. + if self.player == nil then + self.object:remove() + end + + --Check if player is nearby + if self._tick % 5 == 0 and self.player ~= nil then + --Destroy bobber if item not wielded. + if (minetest.get_player_by_name(self.player):get_wielded_item():get_name() ~= "mcl_fishing:fishing_rod") then + self.object:remove() + end + + --Destroy bobber if player is too far away. + local objpos = self.object:get_pos() + local playerpos = minetest.get_player_by_name(self.player):get_pos() + if (((playerpos.y - objpos.y) >= 33) or ((playerpos.y - objpos.y) <= -33)) then + self.object:remove() + elseif (((playerpos.x - objpos.x) >= 33) or ((playerpos.x - objpos.x) <= -33)) then + self.object:remove() + elseif (((playerpos.z - objpos.z) >= 33) or ((playerpos.z - objpos.z) <= -33)) then + self.object:remove() + elseif ((((playerpos.z + playerpos.x) - (objpos.z + objpos.x)) >= 33) or ((playerpos.z + playerpos.x) - (objpos.z + objpos.x)) <= -33) then + self.object:remove() + elseif ((((playerpos.y + playerpos.x) - (objpos.y + objpos.x)) >= 33) or ((playerpos.y + playerpos.x) - (objpos.y + objpos.x)) <= -33) then + self.object:remove() + elseif ((((playerpos.z + playerpos.y) - (objpos.z + objpos.y)) >= 33) or ((playerpos.z + playerpos.y) - (objpos.z + objpos.y)) <= -33) then + self.object:remove() + end + + end + --if in liquid then bob. + if def.liquidtype == "source" then + if self._oldy == nil then + self.object:set_pos({x=self.object:get_pos().x,y=math.floor(self.object:get_pos().y)+.5,z=self.object:get_pos().z}) + self._oldy = self.object:get_pos().y + end + minetest.log(self.object:get_pos().y.." "..self._oldy) + -- reset to original position after dive. + if self.object:get_pos().y > self._oldy then + self.object:set_pos({x=self.object:get_pos().x,y=self._oldy,z=self.object:get_pos().z}) + self.object:set_velocity({x=0,y=0,z=0}) + self.object:set_acceleration({x=0,y=0,z=0}) + end + if self._dive then + for i=1,2 do + --spray bubbles there's a fish. + minetest.add_particle({ + pos = {x=epos["x"]+math.random(-1,1)*math.random()/2,y=epos["y"]+0.1,z=epos["z"]+math.random(-1,1)*math.random()/2}, + velocity = {x=0, y=4, z=0}, + acceleration = {x=0, y=-5, z=0}, + expirationtime = math.random(), + size = math.random()+0.5, + collisiondetection = true, + vertical = false, + texture = "mcl_particles_bubble.png", + }) + end + if self._tick ~= self._waittick then + self._tick = self._tick + 1 + else + self._waittick = nil + self._tick = 0 + self._dive = false + end + else if self._waittick == nil then + --wait for random number of ticks. + self._waittick = math.random(50,800) + else + if self._tick ~= self._waittick then + self._tick = self._tick + 1 + else + --wait time is over time to dive. + self._dive = true + self.object:set_velocity({x=0,y=-2,z=0}) + self.object:set_acceleration({x=0,y=5,z=0}) + self._waittick = 30 + self._tick = 0 + end + end + end +end + + -- Destroy when hitting a solid node + --if self._lastpos.x~=nil then + -- if (def and def.walkable) or not def then + --self.object:remove() + -- return + -- end + --end + --self._lastpos={x=pos.x, y=pos.y, z=pos.z} -- Set lastpos-->Node will be added at last pos outside the node +end + +bobber_ENTITY.on_step = bobber_on_step + +minetest.register_entity("mcl_fishing:bobber_entity", bobber_ENTITY) + +--If player leaves area remove bobber. +minetest.register_on_leaveplayer(function(player) + local objs = minetest.get_objects_inside_radius(player:get_pos(), 250) + local num = 0 + local ent = nil + local noent = true + + for n = 1, #objs do + ent = objs[n]:get_luaentity() + if ent then + if ent.player and ent.objtype=="fishing" then + ent.object:remove() + elseif ent._thrower and ent.objtype=="fishing" then + ent.object:remove() + end + end + end +end) + +--if player dies remove bobber. +minetest.register_on_dieplayer(function(player) + local objs = minetest.get_objects_inside_radius(player:get_pos(), 250) + local num = 0 + local ent = nil + local noent = true + + for n = 1, #objs do + ent = objs[n]:get_luaentity() + if ent then + if ent.player and ent.objtype=="fishing" then + ent.object:remove() + elseif ent._thrower and ent.objtype=="fishing" then + ent.object:remove() + end + end + end +end) + -- Fishing Rod minetest.register_tool("mcl_fishing:fishing_rod", { description = S("Fishing Rod"), _doc_items_longdesc = S("Fishing rods can be used to catch fish."), - _doc_items_usagehelp = S("Rightclick a water source to try to go fishing. Who knows what you're going to catch?"), + _doc_items_usagehelp = S("Rightclick to launch the bobber. When it sinks right-click again to reel in an item. Who knows what you're going to catch?"), -- This item is incomplete, hide it from creative inventory - groups = { tool=1, not_in_creative_inventory=1 }, + groups = { tool=1}, inventory_image = "mcl_fishing_fishing_rod.png", stack_max = 1, - liquids_pointable = true, - on_place = go_fishing, + on_place = fish, + on_secondary_use = fish, sound = { breaks = "default_tool_breaks" }, }) ---[[ - -Temporarily removed from crafting as the fishing rod is massively overpowered atm. - -TODO: Re-enable crafting when fishing rod has been improved. - +--Make fishing rods craftable again. minetest.register_craft({ output = "mcl_fishing:fishing_rod", recipe = { @@ -119,8 +406,6 @@ minetest.register_craft({ {'mcl_mobitems:string','','mcl_core:stick'}, } }) -]] - minetest.register_craft({ type = "fuel", recipe = "mcl_fishing:fishing_rod", diff --git a/mods/ITEMS/mcl_fishing/textures/mcl_fishing_bobber.png b/mods/ITEMS/mcl_fishing/textures/mcl_fishing_bobber.png new file mode 100644 index 0000000000000000000000000000000000000000..0c93fd4f9009a8d22f4cee482f1f6ed2a425b57a GIT binary patch literal 2281 zcmV zaB^>EX>4U6ba`-PAZ2)IW&i+q+O1dTbu>2&{Ld;}0s%0V!}y*%aQPmF4VR=(vTvm$ zi31U4z_6syVR;*r;hE8?JIHNFc*$vxRpix4?v~E}?}g(K*}Q&w9vcrZ zs)apa#Z5@`{O09J5QRiZXg$6~rXogZ=uCNd#ZT!whED*Vy(j#1*>btyScZKUD(QC}2(? z<}((We&g^5X91ooL6Zr_27eEadKUclc`(%bD03nmPOK0YkNQFwgSqhyEf7L|V`?Y9 zq*kM!KZ95SgLc9kkYLhznaGx|+LFn$Xse)V^ja_E>ox$0;M*b?5-^}0i6uwcGkYT7 z7{E_L3qFJpLy8;)+n80+MIS?qF(o)n zCc##Meu5x#mTa=kF8dsE%&DM!iYd0Z;!7y8q{>w)wg6RK^)=L3Q=^7bYNpxdns1@S zmO5&!OE=wi*L@E?_H?qgS$$;fnYpi7qslsMoI$I0(n_1lTke4X9geCf$4X@R#O=pLgqDQg@{ z&+%n`+S;LX6u^+Bak?foJDq9$T#auLhC+eq`T3;>^ckHI%5@gpHx1o+3n=dHy zDWF)3x3UI?O7L41x7j<;ozt0X5ZV~EaTC3A^?4^yibVnDHAt9}Hch66VwNF`>nm_u zhAQ&>X)%L>b5ZBelG|G?j&j|$Y9i`(2W3p`e1cB3ZLsB@L0rmeYCBmfT4b+1TxLq& zSaPh+@v@h2us84L4>*nGV20F}RQxFu=egE4B#}-Jg;od#?*uo#?9R!Yo6N}?Tw+7q zjKF;Lu2r8F2#JD<#1yDaEqx$0Ki zSxZk@s3VQM*J1&K?dx@W`nYd3>T~HgYmY;GocUqhptA6_KgHdxI()nzN%m_Z;reM8 zi~(;Ec_)e_YPm(Oz6$-m^<1mxibC4u7X|rWFMaForateC*TE|L$SS3D&u>o0RoSmD zz~;HJcab%dC52B1%eh3(lG^~6EHy~SML4Q|0gk$O+LD;v>i_@&glR)VP)S2WAaHVT zW@&6?004NLeUUv#!$2IxUsI(b6$d+r2+dHPEQpFaY88r5A=C=3I+$GgAv9@7Qd}Gb z*Mfr|i&X~~XI&j!1wrrw#KqM~(M3x9Us7lh}W*M`Rl!EX0x<`PocX6KOf9}uGqvkCJ1VrK)W|%hdI`QPDZE)Tv zjTnMuzPM~KB@8!K(hN~T6UK^#*xo$`gO$13M7 z&RV(3n)l={4CnRbC9cyPL=p>Fgai=^s@OmoHsZAEq*zGPe!|B;;QA$UDdgG!BgZ@{ z&>*{h@IUz7tyLHw^OC{|p!3CXK8AqMF3_ks&iAq7G){ovGjOH1{FOQ|{YiSQrNxeb z-fiIGx}_<5z~v6m|76If>`FnJLZJY>pV2qvfWBLxd)4c$xsTHaAVXcHZh(VBV7N%x zYd-JpYVYmeGtK^f0G)(#xPUZWX8-^I24YJ`L;zF(Q2l~`L%?J@^aT+|XpB3xgGwZH7Y zeCBt0dwSmA`#kUaK0->#Z;85X=m0|H7B#3;>eaR7?D$i`{-}}_j_45|&N(Zrc5`fnB z9^rEKNq`nhqqx6JbNBF4P*AXi-PJklN(TVlU2UWLk2;W?g z3I781CWA(zd4<7&e)aSm)Bb=2xX)ySxuy!I!^*}{>Z9QHB!OM&1faoG!sYcV04`^r z%n8RlTL9!FnhIj^Bx{jP_QLawdAwpi;FH;nUiAwfrcMEC>wq*qXzL`b5<0IOM+g>KIzEV)2=pT6lgnMt;#%gXx00000NkvXXu0mjf DnAuiz literal 0 HcmV?d00001 diff --git a/mods/ITEMS/mcl_fishing/textures/mcl_fishing_fishing_rod.png b/mods/ITEMS/mcl_fishing/textures/mcl_fishing_fishing_rod.png index f8b4f871498da37a2f57fb78e0030a5b17a4e7ff..2fbcc73445a20508c2283c2365f16e23f681663f 100644 GIT binary patch delta 2387 zcmV-Z39R<30^JgjBYy>^dQ@0+Qek%>aB^>EX>4U6ba`-PAZ2)IW&i+q+O1bvmgFc5 z{O1&N1Pif9$6qXZ4%z~R)X zO}LR`9jm3o&Fk(Q=gouNTt8Tt7%i`EXnTBu-QOOFZrk&t-G9Wg{m6Dim*aWxn0egS z9prYzcG+q7jqV3hxJzgM+p^tm=g)l?0Y>%k$JW@!#K*kaH4`HWR!(RmuFPZLvUr^1 zDj)GP$32Em0A6=b_#J0te1l^-I@1bIIBh%mCp%x$*oTP7UNhVKh-yFLaev(5*L#)T z+sZCE=ty1INq?QG%sULsfRpEA0cXU&$9L&$2UOS2f!ACD%eF_|0@F9d4Mx9EL zql-R<7=NQgjY(LXcnK0kL?x+JMj7))gGLoqO$n1Gm*6X5e1aj{%-Ln1LylRp=2Re` z;)*Y!#3DsYsv41Yk-c5rqGIcEoRgR?^|8)k12r61%} z8jOKK*U0)#7k4-2KIP2--JkMiUomF}b^ix*W>9y>+(+JCuvXJ7w>$|Ns}Pu?LNb;g z1|=)_!|UXCt@-VP++v-#xy8~`FxTr07)%YW@W2xDZ8vc-1bEB!5$s0sH!46wL`#8XK>lwWdD`^jV)g)Hr2% zRM({}9$Lm`>QZhQL(Dlw>l#y!%wdZ}>XG`)6}yMN=C(OWb00NezF1LTXrbG*yo)JK zxcVJ&VJ&CUU9S9lN*hH6yv;8=9%RD18hzdbk`CCnwQr)aak+hbW z*7S}9g?c|3sI-*>J{_2#JZKd9B#R%nPv484EYHr0Wnt{$LJE%obH%(b@FkRT>wtnp6Rl?NA z-oQ))b`zyw5%BU_@Or+Hw*4R20Hm}$REezZ4r=U1$}5U)yvSO#4s~Z$2^HX0_k;}*7VXxM+Xc3mfuYZr=wQ#S@$I-UVjYZbs&CC zYhix-YB2NNpg)q*E%}{n!q&!wdivJFr>w`$=N$+|`C)u6{2$Ag2BrJwDRzQ8z!`chp@@$5KcOIENxt%_7h@z~8>o%IVAPNKiR0 zqiGw-Anu`7##Kwl(uWl8# z_wtx+*Z?=Lt>9C%D&F<~0USd^V%eruVE_ODglR)VP)S2WAaHVTW@&6?004NLeUUv# z!$2IxUsI(b6$d+r2+dHPEQpFaY88r5A=C=3I+$GgAv9@7Qd}Gb*MEY8AB$B77iV1^ zTm?b!1H{GENzp}0{9jUN5#zyeKi=JY+`R*YdYNff$0(rbwwX>Q#B6Rw480@B#c@7{fY2_`s5#E}vEwvOfZ#K5rMLW*Ixzi7dVj5@#g2g9ZQ$a%r73&B zorH3@fHYla00006VoOIv0RI600RN!9r;`8x010qNS#tmYE+YT{E+YYWr9XB6 z000McNliru<9`Pq05>|YRUy*=00F2;L_t(I%bkrV=o^Ae5ORm%Md=_JGK7Ip7x8B1Mer9C4rB)_q*IZ)iymBPT|DT)c}Q`nT^8#f z_;?um()jvoJ@6df&-3B+c|Xtlc|=wD-;s<4F$$u)t$$g=<|7pmE;@lcV0~p??>01X z-R-2~Nkd7N41lXnC;qydr1uX?h8O^Ub2&nt{qkmX2;Y4_HC{Jep~qU11Au@Tk?^yp z>>gzCxE%C`Tl7MJz4SJ!imFmq-zqO&c5&_YLn_M4&V?8NsfDDhugoiesuJq#mlo5{ z?m?D{@_({3k7LF7=l4<3M!<|%PCPEhsSpd`s;agY7e0;ySWY%}GI(5$6VtH(UuP4t z_-Vpc5HKS$GCs|~=sRk>ZX3k-SN!UG&*r^G8zeCk=f_%#jh&3`om?vF_H7Ke_ZFG& zi$#E`ctWP)iGtKSz8eLI6ge1vJBimgNw90-7sx90S*mj#3&dDIx#>002ovPDHLk FV1n8hiC+K! delta 273 zcmV+s0q*|Y5~~7`BYyz$Nkl`S_ z07w%d7a%l0ee&S{$>Rs%nh^#dY)3W#Bc9i015yANkvXXu0mjf^cH%e diff --git a/mods/ITEMS/mcl_throwing/init.lua b/mods/ITEMS/mcl_throwing/init.lua index 7205a17b5b..1c579bd8dd 100644 --- a/mods/ITEMS/mcl_throwing/init.lua +++ b/mods/ITEMS/mcl_throwing/init.lua @@ -2,6 +2,7 @@ mcl_throwing = {} local S = minetest.get_translator("mcl_throwing") local mod_death_messages = minetest.get_modpath("mcl_death_messages") +local mod_fishing = minetest.get_modpath("mcl_fishing") -- -- Snowballs and other throwable items @@ -10,12 +11,14 @@ local mod_death_messages = minetest.get_modpath("mcl_death_messages") local GRAVITY = tonumber(minetest.settings:get("movement_gravity")) local entity_mapping = { + ["mcl_throwing:flying_bobber"] = "mcl_throwing:flying_bobber_entity", ["mcl_throwing:snowball"] = "mcl_throwing:snowball_entity", ["mcl_throwing:egg"] = "mcl_throwing:egg_entity", ["mcl_throwing:ender_pearl"] = "mcl_throwing:ender_pearl_entity", } local velocities = { + ["mcl_throwing:flying_bobber_entity"] = 5, ["mcl_throwing:snowball_entity"] = 22, ["mcl_throwing:egg_entity"] = 22, ["mcl_throwing:ender_pearl_entity"] = 22, @@ -117,6 +120,22 @@ local pearl_ENTITY={ _thrower = nil, -- Player ObjectRef of the player who threw the ender pearl } +local flying_bobber_ENTITY={ + physical = false, + timer=0, + textures = {"mcl_fishing_bobber.png"}, --FIXME: Replace with correct texture. + visual_size = {x=0.5, y=0.5}, + collisionbox = {0,0,0,0,0,0}, + pointable = false, + + get_staticdata = get_staticdata, + on_activate = on_activate, + + _lastpos={}, + _thrower = nil, + objtype="fishing", +} + -- Snowball on_step()--> called when snowball is moving. local snowball_on_step = function(self, dtime) self.timer=self.timer+dtime @@ -284,13 +303,39 @@ local pearl_on_step = function(self, dtime) self._lastpos={x=pos.x, y=pos.y, z=pos.z} -- Set lastpos-->Node will be added at last pos outside the node end +-- Movement function of flying bobber +local flying_bobber_on_step = function(self, dtime) + self.timer=self.timer+dtime + local pos = self.object:get_pos() + local node = minetest.get_node(pos) + local def = minetest.registered_nodes[node.name] + --local player = minetest.get_player_by_name(self._thrower) + + -- Destroy when hitting a solid node + if self._lastpos.x~=nil then + if (def and (def.walkable or def.liquidtype == "flowing" or def.liquidtype == "source")) or not def then + local make_child= function(object) + local ent = object:get_luaentity() + ent.player = self._thrower + ent.child = true + end + make_child(minetest.add_entity(self._lastpos, "mcl_fishing:bobber_entity")) + self.object:remove() + return + end + end + self._lastpos={x=pos.x, y=pos.y, z=pos.z} -- Set lastpos-->Node will be added at last pos outside the node +end + snowball_ENTITY.on_step = snowball_on_step egg_ENTITY.on_step = egg_on_step pearl_ENTITY.on_step = pearl_on_step +flying_bobber_ENTITY.on_step = flying_bobber_on_step minetest.register_entity("mcl_throwing:snowball_entity", snowball_ENTITY) minetest.register_entity("mcl_throwing:egg_entity", egg_ENTITY) minetest.register_entity("mcl_throwing:ender_pearl_entity", pearl_ENTITY) +minetest.register_entity("mcl_throwing:flying_bobber_entity", flying_bobber_ENTITY) local how_to_throw = S("Use the punch key to throw.") From 3da1c551a1d9c3515914d56771051503b2a70ea7 Mon Sep 17 00:00:00 2001 From: Rootyjr <41842051+Rootyjr@users.noreply.github.com> Date: Tue, 30 Jul 2019 22:24:27 -0500 Subject: [PATCH 2/7] Remove WIP and update descriptions. --- mods/ITEMS/mcl_fishing/depends.txt | 1 + mods/ITEMS/mcl_fishing/locale/template.txt | 2 +- mods/ITEMS/mcl_mobitems/init.lua | 3 --- mods/ITEMS/mcl_throwing/depends.txt | 1 + mods/MISC/mcl_wip/init.lua | 1 - 5 files changed, 3 insertions(+), 5 deletions(-) diff --git a/mods/ITEMS/mcl_fishing/depends.txt b/mods/ITEMS/mcl_fishing/depends.txt index 93ef0bf523..1fd904fe1d 100644 --- a/mods/ITEMS/mcl_fishing/depends.txt +++ b/mods/ITEMS/mcl_fishing/depends.txt @@ -2,3 +2,4 @@ mcl_core mcl_sounds mcl_loot mcl_mobs +mcl_throwing diff --git a/mods/ITEMS/mcl_fishing/locale/template.txt b/mods/ITEMS/mcl_fishing/locale/template.txt index c958e0b406..d2bac9807b 100644 --- a/mods/ITEMS/mcl_fishing/locale/template.txt +++ b/mods/ITEMS/mcl_fishing/locale/template.txt @@ -1,7 +1,7 @@ # textdomain: mcl_fishing Fishing Rod= Fishing rods can be used to catch fish.= -Rightclick a water source to try to go fishing. Who knows what you're going to catch?= +Rightclick to launch the bobber. When it sinks right-click again to reel in an item. Who knows what you're going to catch?= Raw Fish= Raw fish is obtained by fishing and is a food item which can be eaten safely. Cooking it improves its nutritional value.= Cooked Fish= diff --git a/mods/ITEMS/mcl_mobitems/init.lua b/mods/ITEMS/mcl_mobitems/init.lua index f25043116a..8a670766aa 100644 --- a/mods/ITEMS/mcl_mobitems/init.lua +++ b/mods/ITEMS/mcl_mobitems/init.lua @@ -359,8 +359,6 @@ minetest.register_craft({ }, }) ---[[ -TODO: Re-enable this when fishing rod is available again minetest.register_craft({ output = "mcl_mobitems:carrot_on_a_stick", recipe = { @@ -376,7 +374,6 @@ minetest.register_craft({ { "mcl_farming:carrot_item", "" }, }, }) -]] minetest.register_craft({ type = "shapeless", diff --git a/mods/ITEMS/mcl_throwing/depends.txt b/mods/ITEMS/mcl_throwing/depends.txt index faf0d2d4f0..2787220ee4 100644 --- a/mods/ITEMS/mcl_throwing/depends.txt +++ b/mods/ITEMS/mcl_throwing/depends.txt @@ -1,3 +1,4 @@ mcl_core? mcl_mobitems? doc? +mcl_fishing diff --git a/mods/MISC/mcl_wip/init.lua b/mods/MISC/mcl_wip/init.lua index 0b042e2125..4f8f0a562f 100644 --- a/mods/MISC/mcl_wip/init.lua +++ b/mods/MISC/mcl_wip/init.lua @@ -3,7 +3,6 @@ local S = minetest.get_translator("mcl_wip") local wip_items = { - "mcl_fishing:fishing_rod", "mcl_maps:empty_map", "mcl_comparators:comparator_off_comp", "mcl_minecarts:hopper_minecart", From c50958a6407555471d2c8030fd64dfac4d004dc0 Mon Sep 17 00:00:00 2001 From: Rootyjr <41842051+Rootyjr@users.noreply.github.com> Date: Tue, 30 Jul 2019 22:39:07 -0500 Subject: [PATCH 3/7] Fix fishing depends.txt --- mods/ITEMS/mcl_fishing/depends.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/mods/ITEMS/mcl_fishing/depends.txt b/mods/ITEMS/mcl_fishing/depends.txt index 1fd904fe1d..93ef0bf523 100644 --- a/mods/ITEMS/mcl_fishing/depends.txt +++ b/mods/ITEMS/mcl_fishing/depends.txt @@ -2,4 +2,3 @@ mcl_core mcl_sounds mcl_loot mcl_mobs -mcl_throwing From 48b73f5f2e11c73be39655c79fd7667a138bf65c Mon Sep 17 00:00:00 2001 From: Rootyjr <41842051+Rootyjr@users.noreply.github.com> Date: Tue, 30 Jul 2019 22:47:40 -0500 Subject: [PATCH 4/7] Add self-credit. --- mods/ITEMS/mcl_fishing/init.lua | 85 +-------------------------------- 1 file changed, 2 insertions(+), 83 deletions(-) diff --git a/mods/ITEMS/mcl_fishing/init.lua b/mods/ITEMS/mcl_fishing/init.lua index 0d34779d41..65c2590e91 100644 --- a/mods/ITEMS/mcl_fishing/init.lua +++ b/mods/ITEMS/mcl_fishing/init.lua @@ -1,3 +1,5 @@ +--Fishing Rod, Bobber, and Flying Bobber mechanics and Bobber artwork by Rootyjr. + local S = minetest.get_translator("mcl_fishing") local mod_throwing = minetest.get_modpath("mcl_throwing") @@ -5,89 +7,6 @@ local entity_mapping = { ["mcl_fishing:bobber"] = "mcl_fishing:bobber_entity", } -local go_fishing = function(itemstack, user, pointed_thing) - if pointed_thing and pointed_thing.under then - -- Use pointed node's on_rightclick function first, if present - local node = minetest.get_node(pointed_thing.under) - if user and not user:get_player_control().sneak then - if minetest.registered_nodes[node.name] and minetest.registered_nodes[node.name].on_rightclick then - return minetest.registered_nodes[node.name].on_rightclick(pointed_thing.under, node, user, itemstack) or itemstack - end - end - - if string.find(node.name, "mcl_core:water") then - local itemname - local itemcount = 1 - local itemwear = 0 - -- FIXME: Maybe use a better seeding - local pr = PseudoRandom(os.time() * math.random(1, 100)) - local r = pr:next(1, 100) - if r <= 85 then - -- Fish - items = mcl_loot.get_loot({ - items = { - { itemstring = "mcl_fishing:fish_raw", weight = 60 }, - { itemstring = "mcl_fishing:salmon_raw", weight = 25 }, - { itemstring = "mcl_fishing:clownfish_raw", weight = 2 }, - { itemstring = "mcl_fishing:pufferfish_raw", weight = 13 }, - } - }, pr) - elseif r <= 95 then - -- Junk - items = mcl_loot.get_loot({ - items = { - { itemstring = "mcl_core:bowl", weight = 10 }, - { itemstring = "mcl_fishing:fishing_rod", weight = 2, wear_min = 6554, wear_max = 65535 }, -- 10%-100% damage - { itemstring = "mcl_mobitems:leather", weight = 10 }, - { itemstring = "3d_armor:boots_leather", weight = 10, wear_min = 6554, wear_max = 65535 }, -- 10%-100% damage - { itemstring = "mcl_mobitems:rotten_flesh", weight = 10 }, - { itemstring = "mcl_core:stick", weight = 5 }, - { itemstring = "mcl_mobitems:string", weight = 5 }, - { itemstring = "mcl_potions:potion_water", weight = 10 }, - { itemstring = "mcl_mobitems:bone", weight = 10 }, - { itemstring = "mcl_dye:black", weight = 1, amount_min = 10, amount_max = 10 }, - { itemstring = "mcl_mobitems:string", weight = 10 }, -- TODO: Tripwire Hook - } - }, pr) - else - -- Treasure - items = mcl_loot.get_loot({ - items = { - -- TODO: Enchanted Bow - { itemstring = "mcl_bows:bow", wear_min = 49144, wear_max = 65535 }, -- 75%-100% damage - -- TODO: Enchanted Book - { itemstring = "mcl_books:book" }, - -- TODO: Enchanted Fishing Rod - { itemstring = "mcl_fishing:fishing_rod", wear_min = 49144, wear_max = 65535 }, -- 75%-100% damage - { itemstring = "mcl_mobs:nametag", }, - { itemstring = "mcl_mobitems:saddle", }, - { itemstring = "mcl_flowers:waterlily", }, - } - }, pr) - end - local item - if #items >= 1 then - item = ItemStack(items[1]) - else - item = ItemStack() - end - local inv = user:get_inventory() - if inv:room_for_item("main", item) then - inv:add_item("main", item) - end - if not minetest.settings:get_bool("creative_mode") then - local idef = itemstack:get_definition() - itemstack:add_wear(65535/65) -- 65 uses - if itemstack:get_count() == 0 and idef.sound and idef.sound.breaks then - minetest.sound_play(idef.sound.breaks, {pos=pointed_thing.above, gain=0.5}) - end - end - return itemstack - end - end - return nil -end - local bobber_ENTITY={ physical = false, timer=0, From 37af2dbba1b89945bce2ca51b923c65784924141 Mon Sep 17 00:00:00 2001 From: Rootyjr <41842051+Rootyjr@users.noreply.github.com> Date: Wed, 31 Jul 2019 22:34:53 -0500 Subject: [PATCH 5/7] Fix fishing allowed in lava. --- mods/ITEMS/mcl_fishing/init.lua | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mods/ITEMS/mcl_fishing/init.lua b/mods/ITEMS/mcl_fishing/init.lua index 65c2590e91..6b5554f165 100644 --- a/mods/ITEMS/mcl_fishing/init.lua +++ b/mods/ITEMS/mcl_fishing/init.lua @@ -15,8 +15,8 @@ local bobber_ENTITY={ collisionbox = {0.45,0.45,0.45,0.45,0.45,0.45}, pointable = false, - get_staticdata = get_staticdata, - on_activate = on_activate, + --get_staticdata = get_staticdata, + --on_activate = on_activate, _lastpos={}, _dive = false, @@ -191,7 +191,7 @@ local bobber_on_step = function(self, dtime) end --if in liquid then bob. - if def.liquidtype == "source" then + if def.liquidtype == "source" and def.name == "mcl_core:water" then if self._oldy == nil then self.object:set_pos({x=self.object:get_pos().x,y=math.floor(self.object:get_pos().y)+.5,z=self.object:get_pos().z}) self._oldy = self.object:get_pos().y From d11b089baca4005f8ff3941c2d00e257d43a4b68 Mon Sep 17 00:00:00 2001 From: Rootyjr <41842051+Rootyjr@users.noreply.github.com> Date: Fri, 2 Aug 2019 14:38:00 -0500 Subject: [PATCH 6/7] Split search distance in half. --- mods/ITEMS/mcl_fishing/init.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mods/ITEMS/mcl_fishing/init.lua b/mods/ITEMS/mcl_fishing/init.lua index 6b5554f165..c27012f344 100644 --- a/mods/ITEMS/mcl_fishing/init.lua +++ b/mods/ITEMS/mcl_fishing/init.lua @@ -30,7 +30,7 @@ local bobber_ENTITY={ local fish = function(itemstack, player) local pos = player:get_pos() - local objs = minetest.get_objects_inside_radius(pos, 250) + local objs = minetest.get_objects_inside_radius(pos, 125) local num = 0 local ent = nil local noent = true From a765d3dd4f37b74d4a3619384e8f5ada3870b27c Mon Sep 17 00:00:00 2001 From: Rootyjr <41842051+Rootyjr@users.noreply.github.com> Date: Sat, 3 Aug 2019 21:34:33 -0500 Subject: [PATCH 7/7] Update init.lua --- mods/ITEMS/mcl_fishing/init.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mods/ITEMS/mcl_fishing/init.lua b/mods/ITEMS/mcl_fishing/init.lua index c27012f344..c5e351e49b 100644 --- a/mods/ITEMS/mcl_fishing/init.lua +++ b/mods/ITEMS/mcl_fishing/init.lua @@ -191,7 +191,7 @@ local bobber_on_step = function(self, dtime) end --if in liquid then bob. - if def.liquidtype == "source" and def.name == "mcl_core:water" then + if def.liquidtype == "source" and def.name == "mcl_core:water_source" then if self._oldy == nil then self.object:set_pos({x=self.object:get_pos().x,y=math.floor(self.object:get_pos().y)+.5,z=self.object:get_pos().z}) self._oldy = self.object:get_pos().y