Crash in MineClonia #5

New Issue

pepebotella · 2024-03-26T21:08:43+01:00

pepebotella commented

2024-03-26 21:08:43 +01:00

Minetest version: 5.8.0

Mineclonia version: main branch commit 0c020c85f67786f9a7ed1306790d74063526b244 (latest)

industrialtest version: master branch commit c8be496afe

ModError: Failed to load and run script from minetest/bin/../mods/industrialtest/init.lua:
...est/bin/../games/mineclonia/mods/ITEMS/mcl_armor/api.lua:146: attempt to index field 'descriptions' (a nil value)
stack traceback:
	...est/bin/../games/mineclonia/mods/ITEMS/mcl_armor/api.lua:146: in function 'register_set'
	...minetest/bin/../mods/industrialtest/compatibility.lua:358: in function 'registerToolset'
	...minetest/bin/../mods/industrialtest/compatibility.lua:555: in main chunk
	[C]: in function 'dofile'
	...minetest/bin/../mods/industrialtest/init.lua:31: in main chunk

Minetest version: 5.8.0 Mineclonia version: main branch commit 0c020c85f67786f9a7ed1306790d74063526b244 (latest) industrialtest version: master branch commit c8be496afe6c12e6dd3f8f2e3a825474ff23255b ``` ModError: Failed to load and run script from minetest/bin/../mods/industrialtest/init.lua: ...est/bin/../games/mineclonia/mods/ITEMS/mcl_armor/api.lua:146: attempt to index field 'descriptions' (a nil value) stack traceback: ...est/bin/../games/mineclonia/mods/ITEMS/mcl_armor/api.lua:146: in function 'register_set' ...minetest/bin/../mods/industrialtest/compatibility.lua:358: in function 'registerToolset' ...minetest/bin/../mods/industrialtest/compatibility.lua:555: in main chunk [C]: in function 'dofile' ...minetest/bin/../mods/industrialtest/init.lua:31: in main chunk ```

cora commented

2024-03-26 23:16:21 +01:00

looks like this commit 27e216112e changed the relevant line not sure why, if it doesn't crash in mcl2 we could probably just go back to that as well.

looks like this commit https://codeberg.org/mineclonia/mineclonia/commit/27e216112ec70b2acbeb383d63c736e8650ad733 changed the relevant line not sure why, if it doesn't crash in mcl2 we could probably just go back to that as well.

cora commented

2024-03-27 00:36:56 +01:00

I made an issue in mcla since I think it should probably be fixed on our side, mcl2 does not appear to crash that way.

https://codeberg.org/mineclonia/mineclonia/issues/1253

I made an issue in mcla since I think it should probably be fixed on our side, mcl2 does not appear to crash that way. https://codeberg.org/mineclonia/mineclonia/issues/1253

mrkubax10 commented

2024-03-27 14:31:21 +01:00

Probably for now I should mention in README.md that mod works only with MineClone2 (no derivatives). Or adapt it to support Mineclonia too, however adding too much compatibility will result in unreadable code.

mrkubax10 added the

crash

compat-mode:mineclone2

labels 2024-03-27 14:36:02 +01:00

cora commented

2024-03-27 16:11:22 +01:00

We'll probably be adding a couple fixes that will make it work