From 98cf3b7f7a27733f5672d1349c37d3a02621e625 Mon Sep 17 00:00:00 2001
From: seventeenthShulker <c545d588-7ff2-49b9-b537-0b3f769083ad@anonaddy.me>
Date: Tue, 4 Jul 2023 18:22:05 +0200
Subject: [PATCH] Check node_replaceable after dig_by_piston Allows tallgrass,
 nether vines etc to drop

---
 mods/ITEMS/REDSTONE/mesecons_mvps/init.lua | 65 +++++++++++-----------
 1 file changed, 32 insertions(+), 33 deletions(-)

diff --git a/mods/ITEMS/REDSTONE/mesecons_mvps/init.lua b/mods/ITEMS/REDSTONE/mesecons_mvps/init.lua
index 12bfd0ca8..b36721e78 100644
--- a/mods/ITEMS/REDSTONE/mesecons_mvps/init.lua
+++ b/mods/ITEMS/REDSTONE/mesecons_mvps/init.lua
@@ -141,44 +141,43 @@ function mesecon.mvps_get_stack(pos, dir, maximum, piston_pos)
 			return
 		end
 
-		if not node_replaceable(nn.name) then
-			if minetest.get_item_group(nn.name, "dig_by_piston") == 1 then
-				-- if we want the node to drop, e.g. sugar cane, do not count towards push limit
-				table.insert(dig_nodes, {node = nn, pos = {x=np.x, y=np.y, z=np.z}})
-			else
+		if minetest.get_item_group(nn.name, "dig_by_piston") == 1 then
+			-- if we want the node to drop, e.g. sugar cane, do not count towards push limit
+			table.insert(dig_nodes, {node = nn, pos = {x=np.x, y=np.y, z=np.z}})
+		else
+			if not node_replaceable(nn.name) then
 				table.insert(nodes, {node = nn, pos = {x=np.x, y=np.y, z=np.z}})
 				if #nodes > maximum then return nil, nil, false, true end
-			end
-
-			-- add connected nodes to frontiers, connected is a vector list
-			-- the vectors must be absolute positions
-			local connected = {}
-            local has_loop
-			if minetest.registered_nodes[nn.name]
-			and minetest.registered_nodes[nn.name].mvps_sticky then
-				connected, has_loop = minetest.registered_nodes[nn.name].mvps_sticky(np, nn, piston_pos)
-				if has_loop then
-					return {}, {}, true, false
-				end
-			end
-			table.insert(connected, vector.add(np, dir))
-
-			-- Make sure there are no duplicates in frontiers / nodes before
-			-- adding nodes in "connected" to frontiers
-			for _, cp in ipairs(connected) do
-				local duplicate = false
-				for _, rp in ipairs(nodes) do
-					if vector.equals(cp, rp.pos) then
-						duplicate = true
+				
+				-- add connected nodes to frontiers, connected is a vector list
+				-- the vectors must be absolute positions
+				local connected = {}
+				local has_loop
+				if minetest.registered_nodes[nn.name] and minetest.registered_nodes[nn.name].mvps_sticky then
+					connected, has_loop = minetest.registered_nodes[nn.name].mvps_sticky(np, nn, piston_pos)
+					if has_loop then
+						return {}, {}, true, false
 					end
 				end
-				for _, fp in ipairs(frontiers) do
-					if vector.equals(cp, fp) then
-						duplicate = true
+				table.insert(connected, vector.add(np, dir))
+				
+				-- Make sure there are no duplicates in frontiers / nodes before
+				-- adding nodes in "connected" to frontiers
+				for _, cp in ipairs(connected) do
+					local duplicate = false
+					for _, rp in ipairs(nodes) do
+						if vector.equals(cp, rp.pos) then
+							duplicate = true
+						end
+					end
+					for _, fp in ipairs(frontiers) do
+						if vector.equals(cp, fp) then
+							duplicate = true
+						end
+					end
+					if not duplicate and not mesecon.is_mvps_stopper(minetest.get_node(cp)) and minetest.get_item_group(nn.name, "dig_by_piston") == 0 then
+						table.insert(frontiers, cp)
 					end
-				end
-				if not duplicate and not mesecon.is_mvps_stopper(minetest.get_node(cp)) and minetest.get_item_group(nn.name, "dig_by_piston") == 0 then
-					table.insert(frontiers, cp)
 				end
 			end
 		end