From adee1a49afc306f48554c82f3fa0f24a7dbfc74f Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Tue, 30 May 2023 13:14:02 +0000 Subject: [PATCH 1/3] Add max_hear_distance flag to composter sounds --- mods/ITEMS/mcl_composters/init.lua | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mods/ITEMS/mcl_composters/init.lua b/mods/ITEMS/mcl_composters/init.lua index 51c887531..08125cbbe 100644 --- a/mods/ITEMS/mcl_composters/init.lua +++ b/mods/ITEMS/mcl_composters/init.lua @@ -76,7 +76,7 @@ local function composter_add_item(pos, node, player, itemstack, pointed_thing) if chance > 0 then if not is_creative_enabled(player:get_player_name()) then itemstack:take_item() - minetest.sound_play({name="default_gravel_dug", pos=pos, gain=1}, true) + minetest.sound_play({name="default_gravel_dug", pos=pos, gain=1, max_hear_distance=16}, true) end -- calculate leveling up chance local rand = math.random(0,100) @@ -92,7 +92,7 @@ local function composter_add_item(pos, node, player, itemstack, pointed_thing) level = "ready" end swap_node(pos, {name = "mcl_composters:composter_" .. level}) - minetest.sound_play({name="default_grass_footstep", pos=pos, gain=0.4}, true) + minetest.sound_play({name="default_grass_footstep", pos=pos, gain=0.4, max_hear_distance=16}, true) -- a full composter becomes ready for harvest after one second -- the block will get updated by the node timer callback set in node reg def if level == 7 then @@ -115,7 +115,7 @@ end local function composter_ready(pos) swap_node(pos, {name = "mcl_composters:composter_ready"}) -- maybe spawn particles again? - minetest.sound_play({name="default_dig_snappy", pos=above, gain=1}, true) + minetest.sound_play({name="default_dig_snappy", pos=above, gain=1, max_hear_distance=16}, true) return false end From 428ae9ac0db1bbdd26ca99d5f7beb775a311ddfa Mon Sep 17 00:00:00 2001 From: ancientmarinerdev Date: Wed, 31 May 2023 23:08:31 +0100 Subject: [PATCH 2/3] Fix positional sounds based on mt docs. --- mods/ITEMS/mcl_composters/init.lua | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/mods/ITEMS/mcl_composters/init.lua b/mods/ITEMS/mcl_composters/init.lua index 08125cbbe..223771148 100644 --- a/mods/ITEMS/mcl_composters/init.lua +++ b/mods/ITEMS/mcl_composters/init.lua @@ -76,7 +76,10 @@ local function composter_add_item(pos, node, player, itemstack, pointed_thing) if chance > 0 then if not is_creative_enabled(player:get_player_name()) then itemstack:take_item() - minetest.sound_play({name="default_gravel_dug", pos=pos, gain=1, max_hear_distance=16}, true) + minetest.sound_play({name="default_gravel_dug", gain=1, max_hear_distance=16}, { + pos = pos, + max_hear_distance = 32, + }, true) end -- calculate leveling up chance local rand = math.random(0,100) @@ -92,7 +95,11 @@ local function composter_add_item(pos, node, player, itemstack, pointed_thing) level = "ready" end swap_node(pos, {name = "mcl_composters:composter_" .. level}) - minetest.sound_play({name="default_grass_footstep", pos=pos, gain=0.4, max_hear_distance=16}, true) + minetest.sound_play({name="default_grass_footstep", gain=0.4}, { + pos = pos, + gain= 0.4, + max_hear_distance = 16, + }, true) -- a full composter becomes ready for harvest after one second -- the block will get updated by the node timer callback set in node reg def if level == 7 then @@ -115,7 +122,10 @@ end local function composter_ready(pos) swap_node(pos, {name = "mcl_composters:composter_ready"}) -- maybe spawn particles again? - minetest.sound_play({name="default_dig_snappy", pos=above, gain=1, max_hear_distance=16}, true) + minetest.sound_play({name="default_dig_snappy", gain=1}, { + pos = pos, + max_hear_distance = 16, + }, true) return false end From 90842c5f251943a4bf21ff64c63317b6a728c39c Mon Sep 17 00:00:00 2001 From: ancientmarinerdev Date: Wed, 31 May 2023 23:18:15 +0100 Subject: [PATCH 3/3] Fixed slight error. --- mods/ITEMS/mcl_composters/init.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mods/ITEMS/mcl_composters/init.lua b/mods/ITEMS/mcl_composters/init.lua index 223771148..d60422afd 100644 --- a/mods/ITEMS/mcl_composters/init.lua +++ b/mods/ITEMS/mcl_composters/init.lua @@ -76,9 +76,9 @@ local function composter_add_item(pos, node, player, itemstack, pointed_thing) if chance > 0 then if not is_creative_enabled(player:get_player_name()) then itemstack:take_item() - minetest.sound_play({name="default_gravel_dug", gain=1, max_hear_distance=16}, { + minetest.sound_play({name="default_gravel_dug", gain=1}, { pos = pos, - max_hear_distance = 32, + max_hear_distance = 16, }, true) end -- calculate leveling up chance