Fix seeds not being subtracted on_place #2

Closed

cora wants to merge 1 commits from (deleted):fix_seed_dupe into master

pull from: (deleted):fix_seed_dupe

merge into: erlehmann:master

erlehmann:master

Conversation 5 Commits 1 Files Changed 1 +1

cora commented 2022-10-09 00:59:51 +02:00

First-time contributor

Copy Link

The overwritten on_place's of this mod neglect to return the itemstack (or anything for that matter) hence nothing is removed on_place in the overwritten functions.

Testing

• rightclick tilled soil with a seed, notice no item is taken from the stack
• observe it is fixed in this branch

The overwritten on_place's of this mod neglect to return the itemstack (or anything for that matter) hence nothing is removed on_place in the overwritten functions. ### Testing * rightclick tilled soil with a seed, notice no item is taken from the stack * observe it is fixed in this branch

cora added 1 commit 2022-10-09 00:59:51 +02:00

89476bcf51 Fix seeds not being subtracted on_place

erlehmann commented 2023-09-08 20:03:44 +02:00

Owner

Copy Link

I have tested this and confirmed that:

• Without this patch no seeds are reduced when right-clicking tilled soil or (fully grown) red beets or wheat.
• With this patch seeds are reduced by one when right-clicking tilled soil or (fully grown) red beets or wheat.

I have tested this and confirmed that: * Without this patch no seeds are reduced when right-clicking tilled soil or (fully grown) red beets or wheat. * With this patch seeds are reduced by one when right-clicking tilled soil or (fully grown) red beets or wheat.

erlehmann commented 2023-09-08 20:09:54 +02:00

Owner

Copy Link

@cora looking at the code after all this time, I am confused why your solution works.

Can you explain what is happening to itemstack here? If so, please do so.

Should the code maybe return what old_on_place() returns?

@cora looking at the code after all this time, I am confused why your solution works. Can you explain what is happening to `itemstack` here? If so, please do so. Should the code maybe return what `old_on_place()` returns?

cora commented 2023-09-08 21:43:37 +02:00

Author

First-time contributor

Copy Link

on_place = function(itemstack, placer, pointed_thing),
[...]
-- Shall place item and return the leftover itemstack

https://github.com/minetest/minetest/blob/master/doc/lua_api.md?plain=1#L8815

return old on place would probably work too but since that will also juts modify itemstack returning itemstack should result in the same if i am not mistaken

> on_place = function(itemstack, placer, pointed_thing), > [...] > -- Shall place item and return the leftover itemstack > https://github.com/minetest/minetest/blob/master/doc/lua_api.md?plain=1#L8815 return old on place would probably work too but since that will also juts modify itemstack returning itemstack should result in the same if i am not mistaken

cora commented 2023-09-11 03:10:17 +02:00

Author

First-time contributor

Copy Link

appears to have been fixed by 92d1671079

appears to have been fixed by https://git.minetest.land/erlehmann/mcl_quick_harvest_replant/commit/92d16710799a6508977f14df1f241a7d84fdf265

cora closed this pull request 2023-09-11 03:10:17 +02:00

erlehmann commented 2023-09-11 12:21:46 +02:00

Owner

Copy Link

Yes. Sorry, I forgot to close this PR. Thank you for your help!

Yes. Sorry, I forgot to close this PR. Thank you for your help!

👍 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No Label

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: erlehmann/mcl_quick_harvest_replant#2

No description provided.