chmodsayshello
  • Joined on 2021-12-08
chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3938 2023-09-29 17:52:48 +02:00
Update trapdoor climbable behavior

This needs no change, but you could simply say { y = 1 }

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3938 2023-09-29 17:52:48 +02:00
Update trapdoor climbable behavior

Unless you have some special case where this should not be executes when the value = false (which it can't in this case, please use not

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3938 2023-09-29 17:52:47 +02:00
Update trapdoor climbable behavior

Please out the hardcoded values in the array directly, like

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3784 2023-09-29 17:02:11 +02:00
add 1.20 armor trims

Force pushed as there were still some issues related to the cherry pick, made cora's change myself at 4046a68fbf in MineClone2 history

chmodsayshello pushed to armor_trims at VoxeLibre/VoxeLibre 2023-09-29 17:00:16 +02:00
8936313fb3 proper itemslot background
chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3784 2023-09-26 22:31:43 +02:00
add 1.20 armor trims

License clarification needed

It is CC, the textures used in mcl2 have all been made Aeonix_Aeon

chmodsayshello pushed to armor_trims at VoxeLibre/VoxeLibre 2023-09-26 22:23:27 +02:00
3cd98a0c1e minor fixup after cherry pick
chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3784 2023-09-26 22:12:52 +02:00
add 1.20 armor trims

force pushed to remove the "b" I added by accidient while resolving the merge conflict

chmodsayshello pushed to armor_trims at VoxeLibre/VoxeLibre 2023-09-26 22:11:57 +02:00
d5522111c7 Add smithing table formspec itemslot bg image for armor trims
chmodsayshello pushed to armor_trims at VoxeLibre/VoxeLibre 2023-09-26 22:09:35 +02:00
cb196c5076 Add smithing table formspec itemslot bg image for armor trims
chmodsayshello pushed to armor_trims at VoxeLibre/VoxeLibre 2023-09-26 20:25:36 +02:00
4046a68fbf Add trim snippet
chmodsayshello suggested changes for VoxeLibre/VoxeLibre#3878 2023-09-22 20:50:57 +02:00
Wither finishing, effect fixes

I don't think I am the right person to review this as I never really touched mob related stuff, but here are some minor things I've found after skimming through the code...

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3878 2023-09-22 20:50:56 +02:00
Wither finishing, effect fixes

just a question (as i sometime also tend to go with string.find).

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3878 2023-09-22 20:50:55 +02:00
Wither finishing, effect fixes

shouldn't it be an exception when the entity is not present?

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3878 2023-09-22 20:50:54 +02:00
Wither finishing, effect fixes

Any reason why you are checking this every step?

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3878 2023-09-22 20:50:53 +02:00
Wither finishing, effect fixes

These settings are really dangerous in my opinion.

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3878 2023-09-22 20:50:52 +02:00
Wither finishing, effect fixes

this is very nitpicky, but for consistency you might consider putting this in an global array called mcl_mobs

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3878 2023-09-22 20:50:51 +02:00
Wither finishing, effect fixes

basically the same as with the ghasts

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3878 2023-09-22 20:50:51 +02:00
Wither finishing, effect fixes

unreachable