chmodsayshello
  • Joined on 2021-12-08
chmodsayshello pushed to master at VoxeLibre/VoxeLibre 2023-10-03 23:46:14 +02:00
712a6d6c66 Merge pull request 'add 1.20 armor trims' (#3784) from armor_trims into master
8936313fb3 proper itemslot background
4046a68fbf Add trim snippet
49bd28e109 add/remove comments
6c107ce990 fix for enchanted items
Compare 40 commits »
chmodsayshello merged pull request VoxeLibre/VoxeLibre#3784 2023-10-03 23:46:07 +02:00
add 1.20 armor trims
chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3878 2023-09-29 18:02:24 +02:00
Wither finishing, effect fixes

Like I said, I am not familiar enoght with mob stuff

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3878 2023-09-29 18:01:27 +02:00
Wither finishing, effect fixes

There still should be some logic so that nametagged withers don't despawn and don't add onto the counter itself, and still, 3 withers for the overworld still seems not enoght for me...

Like, I…

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3878 2023-09-29 17:58:18 +02:00
Wither finishing, effect fixes

Fair point, but did you measure it?

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3878 2023-09-29 17:55:09 +02:00
Wither finishing, effect fixes

see wither conversation below

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3878 2023-09-29 17:54:36 +02:00
Wither finishing, effect fixes

Then they should be in a group though that doesn't rely on some string logic, right?

chmodsayshello suggested changes for VoxeLibre/VoxeLibre#3938 2023-09-29 17:52:52 +02:00
Update trapdoor climbable behavior

Some feedback I have after reading the code for the first time and testing for a few minutes

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3938 2023-09-29 17:52:51 +02:00
Update trapdoor climbable behavior

This one is nitpicky, but please fix the indention here

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3938 2023-09-29 17:52:51 +02:00
Update trapdoor climbable behavior

Isn't this always true no matter what?

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3938 2023-09-29 17:52:50 +02:00
Update trapdoor climbable behavior

This seems like code duplication to me...

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3938 2023-09-29 17:52:49 +02:00
Update trapdoor climbable behavior

You may check if it's a trapdoor RIGHT here, and return if not, as otherwise, this won't do anything

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3938 2023-09-29 17:52:48 +02:00
Update trapdoor climbable behavior

This needs no change, but you could simply say { y = 1 }

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3938 2023-09-29 17:52:48 +02:00
Update trapdoor climbable behavior

Unless you have some special case where this should not be executes when the value = false (which it can't in this case, please use not

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3938 2023-09-29 17:52:47 +02:00
Update trapdoor climbable behavior

Please out the hardcoded values in the array directly, like

chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3784 2023-09-29 17:02:11 +02:00
add 1.20 armor trims

Force pushed as there were still some issues related to the cherry pick, made cora's change myself at 4046a68fbf in MineClone2 history

chmodsayshello pushed to armor_trims at VoxeLibre/VoxeLibre 2023-09-29 17:00:16 +02:00
8936313fb3 proper itemslot background
chmodsayshello commented on pull request VoxeLibre/VoxeLibre#3784 2023-09-26 22:31:43 +02:00
add 1.20 armor trims

License clarification needed

It is CC, the textures used in mcl2 have all been made Aeonix_Aeon

chmodsayshello pushed to armor_trims at VoxeLibre/VoxeLibre 2023-09-26 22:23:27 +02:00
3cd98a0c1e minor fixup after cherry pick