chmodsayshello
/
mcl_sus_stew
1
0
Fork 1
Code Issues Pull Requests Projects Releases 4 Wiki Activity

Add alliums with fire_resistance, and fix eating issue. #2

Merged
chmodsayshello merged 1 commits from MysticTempest/mcl_sus_stew:fire_resistance_and_fix into master 2022-10-04 19:26:37 +02:00
Conversation 3 Commits 1 Files Changed 1 +12
MysticTempest commented 2022-06-23 15:34:12 +02:00
Contributor
Copy Link

Just a quick patch to add a sus_stew for fire_resistance which uses alliums.
Source: https://minecraft.fandom.com/wiki/Suspicious_Stew#Food

And, a bug fix where you could only eat the sus_stews if you were looking at a node. Because, it only had an "on_place" for eating.
I added a "on_secondary_use" to fix this.

Testing:
At current Version -
Attempt to make a sus_stew out of alliums; note that it doesn't work.
Make another sus_stew using, dandelions for example. Look to the sky, and try to eat it; note it doesn't work.
Finally, aim at the ground, and eat it.

With this patch -
Make a sus_stew using alliums, then look toward the sky, and eat it. Verify that works, and that you also have 4 seconds of fire_resistance.

Just a quick patch to add a sus_stew for fire_resistance which uses alliums. Source: https://minecraft.fandom.com/wiki/Suspicious_Stew#Food And, a bug fix where you could only eat the sus_stews if you were looking at a node. Because, it only had an "on_place" for eating. I added a "on_secondary_use" to fix this. **Testing: At current Version** - Attempt to make a sus_stew out of alliums; note that it doesn't work. Make another sus_stew using, dandelions for example. Look to the sky, and try to eat it; note it doesn't work. Finally, aim at the ground, and eat it. **With this patch** - Make a sus_stew using alliums, then look toward the sky, and eat it. Verify that works, and that you also have 4 seconds of fire_resistance.
👍 3
MysticTempest added 1 commit 2022-06-23 15:34:13 +02:00
cora approved these changes 2022-06-24 04:36:51 +02:00
cora left a comment
Contributor
Copy Link

Works as advertised.

Works as advertised.
cora commented 2022-06-24 04:37:23 +02:00
Contributor
Copy Link

remember to turn off sus_stews from mcl to test.

remember to turn off sus_stews from mcl to test.
MysticTempest commented 2022-07-24 20:34:21 +02:00
Author
Contributor
Copy Link

@chmodsayshello since you're active again. Can you take a look at this?

@chmodsayshello since you're active again. Can you take a look at this?
chmodsayshello commented 2022-10-04 19:26:26 +02:00
Owner
Copy Link

@MysticTempest sorry, just saw this pr for the pr for the first time, looks good to me

@MysticTempest sorry, just saw this pr for the pr for the first time, looks good to me
🎉 1
chmodsayshello approved these changes 2022-10-04 19:26:32 +02:00
chmodsayshello merged commit 0e3bfa42b8 into master 2022-10-04 19:26:37 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
cora
chmodsayshello
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: chmodsayshello/mcl_sus_stew#2
No description provided.
Delete Branch "MysticTempest/mcl_sus_stew:fire_resistance_and_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?