forked from LizzyFleckenstein03/Memeclone
Split developer responsibilities into a list
This commit is contained in:
parent
70425e9f30
commit
ea0f52763c
|
@ -274,22 +274,27 @@ end
|
||||||
|
|
||||||
### Developer status
|
### Developer status
|
||||||
Active and trusted contributors are often granted write access to the
|
Active and trusted contributors are often granted write access to the
|
||||||
MineClone2 repository. However you should not push things directly to
|
MineClone2 repository.
|
||||||
|
|
||||||
|
#### Developer responsibilities
|
||||||
|
- You should not push things directly to
|
||||||
MineClone2 master - rather, do your work on a branch on your private
|
MineClone2 master - rather, do your work on a branch on your private
|
||||||
repo, then create a pull request. This way other people can review your
|
repo, then create a pull request. This way other people can review your
|
||||||
changes and make sure they work before they get merged. You are allowed
|
changes and make sure they work before they get merged.
|
||||||
to merge PRs if they have recieved the necessary feedback and have been
|
- Merge PRs if they have recieved the necessary feedback and have been
|
||||||
tested to not lead to any crashes and do what they claim to do by at
|
tested to not lead to any crashes and do what they claim to do by at
|
||||||
least two different people. You may also be assigned to issues or pull
|
least two different people.
|
||||||
|
- You may also be assigned to issues or pull
|
||||||
requests as a developer. In this case it is your responsibility to fix
|
requests as a developer. In this case it is your responsibility to fix
|
||||||
the issue / review and merge the pull request when it is ready. You can
|
the issue / review and merge the pull request when it is ready. You can
|
||||||
also unassign yourself from the issue / PR if you have no time or don't
|
also unassign yourself from the issue / PR if you have no time or don't
|
||||||
want to take care of it for some other reason (after all, everyone is a
|
want to take care of it for some other reason (after all, everyone is a
|
||||||
volunteer and we can't expect you to do work that you are not intrested
|
volunteer and we can't expect you to do work that you are not intrested
|
||||||
in) - the important thing is really that you make sure to inform us if
|
in) - **the important thing is that you make sure to inform us if you
|
||||||
you won't take care of something that has been assigned to you. Also,
|
won't take care of something that has been assigned to you.**
|
||||||
please assign yourself to something that you want to work on to avoid
|
- Please assign yourself to something that you want to work on to avoid
|
||||||
duplicate work. As a developer, it should be easy to reach you about
|
duplicate work.
|
||||||
|
- As a developer, it should be easy to reach you about
|
||||||
your code. You should be on the Discord (or, if you really don't like
|
your code. You should be on the Discord (or, if you really don't like
|
||||||
Discord, Matrix or IRC).
|
Discord, Matrix or IRC).
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue