VoxeLibre/mods
𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟 a620d24ec8 Fix a number of crashes involving unknown nodes, also fix fishbuckets on_place (#3914)
Fixes: #3913 #3915

~~You can reproduce the crash by placing a fish bucket on top snow above an unknown node.

I also noticed that the code always uses pointed_thing.above so I fixed that and also added a function to mcl_utils to figure out where a node should be placed (either above or below). Looks like the rest of the code could also use improvement but at least it does not crash now.~~

Cora fixed a bunch of related crashes in Mineclona so I am replacing my commit and cherry picking all her commits here.
https://codeberg.org/mineclonia/mineclonia/pulls/549

Here is the list of fixes from that PR:
- Crash when placing snow layer on unknown nodes
- Crash when snow layers on unknown nodes are flooded
- Crash when placing fishbucket on snow on top of unknown nodes
- Crash when placing chorus flower and stem on unknown
- Crash when placing mob spawners on unknown
- The fishbucket on place to actually replace buildable_to

Co-authored-by: cora <coradelamouche@gmx.ch>
Reviewed-on: MineClone2/MineClone2#3914
Reviewed-by: ancientmarinerdev <ancientmariner_dev@proton.me>
Co-authored-by: 𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟 <mrrar@noreply.git.minetest.land>
Co-committed-by: 𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟 <mrrar@noreply.git.minetest.land>
2023-09-29 18:47:07 +00:00
..
CORE mcl_oxidation: typo in README. 2023-09-02 15:18:30 +02:00
ENTITIES Reduced the creeper explosion timer reset radius from 6 to 3 2023-09-29 18:35:21 +00:00
ENVIRONMENT Update russian translation 2023-08-31 14:16:42 +08:00
HELP Update Russian translation. Fix 1. 2023-09-02 15:51:49 +08:00
HUD Update Russian translation. Fix 1. 2023-09-02 15:51:49 +08:00
ITEMS Fix a number of crashes involving unknown nodes, also fix fishbuckets on_place (#3914) 2023-09-29 18:47:07 +00:00
MAPGEN Merge pull request 'Update Russian translation' (#3896) from Nanashi_Mumei/MineClone2:master into master 2023-09-02 08:25:43 +00:00
MISC Update russian translation 2023-08-31 14:16:42 +08:00
PLAYER Merge pull request 'Add Setting to keep respawn location set if bed is destroyed.' (#3933) from Eliy21/MineClone2:no_bed_respawn_setting into master 2023-09-29 18:29:31 +00:00