VoxeLibre/VoxeLibre
VoxeLibre
/
VoxeLibre
62
134
Fork 181
Code Issues 954 Pull Requests 91 Projects 4 Releases Wiki Activity

Crash in mcl_experience #954

New Issue
Closed
opened 2021-01-04 20:03:26 +01:00 by LizzyFleckenstein03 · 9 comments
LizzyFleckenstein03 commented 2021-01-04 20:03:26 +01:00
Member
Copy Link
2021-01-04 20:08:05: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '??' in callback luaentity_Step(): /usr/share/minetest/builtin/common/vector.lua:98: attempt to perform arithmetic on local 'b' (a nil value)
2021-01-04 20:08:05: ERROR[Main]: stack traceback:
2021-01-04 20:08:05: ERROR[Main]:       /usr/share/minetest/builtin/common/vector.lua:98: in function 'add'
2021-01-04 20:08:05: ERROR[Main]:       ...netest/games/MineClone2/mods/HUD/mcl_experience/init.lua:334: in function 'xp_step'
2021-01-04 20:08:05: ERROR[Main]:       ...netest/games/MineClone2/mods/HUD/mcl_experience/init.lua:552: in function 'func'
2021-01-04 20:08:05: ERROR[Main]:       /usr/share/minetest/builtin/profiler/instrumentation.lua:106: in function 'on_step_old'
2021-01-04 20:08:05: ERROR[Main]:       ...mes/MineClone2/mods/ENVIRONMENT/mcl_void_damage/init.lua:17: in function 'func'
2021-01-04 20:08:05: ERROR[Main]:       /usr/share/minetest/builtin/profiler/instrumentation.lua:106: in function </usr/share/minetest/builtin/profiler/instrumentation.lua:100>
``` 2021-01-04 20:08:05: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '??' in callback luaentity_Step(): /usr/share/minetest/builtin/common/vector.lua:98: attempt to perform arithmetic on local 'b' (a nil value) 2021-01-04 20:08:05: ERROR[Main]: stack traceback: 2021-01-04 20:08:05: ERROR[Main]: /usr/share/minetest/builtin/common/vector.lua:98: in function 'add' 2021-01-04 20:08:05: ERROR[Main]: ...netest/games/MineClone2/mods/HUD/mcl_experience/init.lua:334: in function 'xp_step' 2021-01-04 20:08:05: ERROR[Main]: ...netest/games/MineClone2/mods/HUD/mcl_experience/init.lua:552: in function 'func' 2021-01-04 20:08:05: ERROR[Main]: /usr/share/minetest/builtin/profiler/instrumentation.lua:106: in function 'on_step_old' 2021-01-04 20:08:05: ERROR[Main]: ...mes/MineClone2/mods/ENVIRONMENT/mcl_void_damage/init.lua:17: in function 'func' 2021-01-04 20:08:05: ERROR[Main]: /usr/share/minetest/builtin/profiler/instrumentation.lua:106: in function </usr/share/minetest/builtin/profiler/instrumentation.lua:100> ```
👍 2 ❤️ 1
LizzyFleckenstein03 added the
bug
#P1 CRITICAL
 labels 2021-01-04 20:03:26 +01:00
kneekoo commented 2021-01-04 20:17:34 +01:00
Contributor
Copy Link

Thanks, I didn't get to report that in time but I bumped into that issue about an hour ago when I wanted to try the latest commits. :)

My game crashed when I was mining coal, then I joined kay27's server and the server kept crashing when I killed a wolf or tried to pick up XP from fishing. And there was another player, so that was probably another "crash source".

Thanks, I didn't get to report that in time but I bumped into that issue about an hour ago when I wanted to try the latest commits. :) My game crashed when I was mining coal, then I joined kay27's server and the server kept crashing when I killed a wolf or tried to pick up XP from fishing. And there was another player, so that was probably another "crash source".
MysticTempest commented 2021-01-04 21:00:51 +01:00
Member
Copy Link
2021-01-04 20:08:05: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '??' in callback luaentity_Step(): /usr/share/minetest/builtin/common/vector.lua:98: attempt to perform arithmetic on local 'b' (a nil value)
2021-01-04 20:08:05: ERROR[Main]: stack traceback:
2021-01-04 20:08:05: ERROR[Main]:       /usr/share/minetest/builtin/common/vector.lua:98: in function 'add'
2021-01-04 20:08:05: ERROR[Main]:       ...netest/games/MineClone2/mods/HUD/mcl_experience/init.lua:334: in function 'xp_step'
2021-01-04 20:08:05: ERROR[Main]:       ...netest/games/MineClone2/mods/HUD/mcl_experience/init.lua:552: in function 'func'
2021-01-04 20:08:05: ERROR[Main]:       /usr/share/minetest/builtin/profiler/instrumentation.lua:106: in function 'on_step_old'
2021-01-04 20:08:05: ERROR[Main]:       ...mes/MineClone2/mods/ENVIRONMENT/mcl_void_damage/init.lua:17: in function 'func'
2021-01-04 20:08:05: ERROR[Main]:       /usr/share/minetest/builtin/profiler/instrumentation.lua:106: in function </usr/share/minetest/builtin/profiler/instrumentation.lua:100>

This is due to your earlier commit:
cfc86bcf3d

It also causes crashes when trying to sleep & eat; reverting your change fixes the crashes in all 3 mods as expected.

Attempting to sleep in beds crash:

2021-01-04 13:51:26: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'mcl_tools' in callback item_OnPlace(): /usr/share/minetest/builtin/common/vector.lua:22: attempt to index local 'v' (a nil value)
2021-01-04 13:51:26: ERROR[Main]: stack traceback:
2021-01-04 13:51:26: ERROR[Main]: 	/usr/share/minetest/builtin/common/vector.lua:22: in function 'length'
2021-01-04 13:51:26: ERROR[Main]: 	...etest/games/mineclone2/mods/ITEMS/mcl_beds/functions.lua:95: in function 'lay_down'
2021-01-04 13:51:26: ERROR[Main]: 	...etest/games/mineclone2/mods/ITEMS/mcl_beds/functions.lua:338: in function 'on_rightclick'
2021-01-04 13:51:26: ERROR[Main]: 	...c/.minetest/games/mineclone2/mods/ITEMS/mcl_beds/api.lua:148: in function 'on_rightclick'
2021-01-04 13:51:26: ERROR[Main]: 	/usr/share/minetest/builtin/game/item.lua:426: in function </usr/share/minetest/builtin/game/item.lua:419>

Trying to eat crash:

2021-01-04 13:52:55: ACTION[Server]: singleplayer activates mcl_core:apple
2021-01-04 13:52:55: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'mcl_core' in callback item_OnSecondaryUse(): /usr/share/minetest/builtin/common/vector.lua:94: attempt to index local 'a' (a nil value)
2021-01-04 13:52:55: ERROR[Main]: stack traceback:
2021-01-04 13:52:55: ERROR[Main]: 	/usr/share/minetest/builtin/common/vector.lua:94: in function 'add'
2021-01-04 13:52:55: ERROR[Main]: 	...etest/games/mineclone2/mods/PLAYER/mcl_hunger/hunger.lua:160: in function 'eat'
2021-01-04 13:52:55: ERROR[Main]: 	...etest/games/mineclone2/mods/PLAYER/mcl_hunger/hunger.lua:44: in function <...etest/games/mineclone2/mods/PLAYER/mcl_hunger/hunger.lua:6>
> ``` > 2021-01-04 20:08:05: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '??' in callback luaentity_Step(): /usr/share/minetest/builtin/common/vector.lua:98: attempt to perform arithmetic on local 'b' (a nil value) > 2021-01-04 20:08:05: ERROR[Main]: stack traceback: > 2021-01-04 20:08:05: ERROR[Main]: /usr/share/minetest/builtin/common/vector.lua:98: in function 'add' > 2021-01-04 20:08:05: ERROR[Main]: ...netest/games/MineClone2/mods/HUD/mcl_experience/init.lua:334: in function 'xp_step' > 2021-01-04 20:08:05: ERROR[Main]: ...netest/games/MineClone2/mods/HUD/mcl_experience/init.lua:552: in function 'func' > 2021-01-04 20:08:05: ERROR[Main]: /usr/share/minetest/builtin/profiler/instrumentation.lua:106: in function 'on_step_old' > 2021-01-04 20:08:05: ERROR[Main]: ...mes/MineClone2/mods/ENVIRONMENT/mcl_void_damage/init.lua:17: in function 'func' > 2021-01-04 20:08:05: ERROR[Main]: /usr/share/minetest/builtin/profiler/instrumentation.lua:106: in function </usr/share/minetest/builtin/profiler/instrumentation.lua:100> > ``` This is due to your earlier commit: https://git.minetest.land/Wuzzy/MineClone2/commit/cfc86bcf3dc273c217b1c26d935e12d5e682348f It also causes crashes when trying to sleep & eat; reverting your change fixes the crashes in all 3 mods as expected. Attempting to sleep in beds crash: ``` 2021-01-04 13:51:26: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'mcl_tools' in callback item_OnPlace(): /usr/share/minetest/builtin/common/vector.lua:22: attempt to index local 'v' (a nil value) 2021-01-04 13:51:26: ERROR[Main]: stack traceback: 2021-01-04 13:51:26: ERROR[Main]: /usr/share/minetest/builtin/common/vector.lua:22: in function 'length' 2021-01-04 13:51:26: ERROR[Main]: ...etest/games/mineclone2/mods/ITEMS/mcl_beds/functions.lua:95: in function 'lay_down' 2021-01-04 13:51:26: ERROR[Main]: ...etest/games/mineclone2/mods/ITEMS/mcl_beds/functions.lua:338: in function 'on_rightclick' 2021-01-04 13:51:26: ERROR[Main]: ...c/.minetest/games/mineclone2/mods/ITEMS/mcl_beds/api.lua:148: in function 'on_rightclick' 2021-01-04 13:51:26: ERROR[Main]: /usr/share/minetest/builtin/game/item.lua:426: in function </usr/share/minetest/builtin/game/item.lua:419> ``` Trying to eat crash: ``` 2021-01-04 13:52:55: ACTION[Server]: singleplayer activates mcl_core:apple 2021-01-04 13:52:55: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'mcl_core' in callback item_OnSecondaryUse(): /usr/share/minetest/builtin/common/vector.lua:94: attempt to index local 'a' (a nil value) 2021-01-04 13:52:55: ERROR[Main]: stack traceback: 2021-01-04 13:52:55: ERROR[Main]: /usr/share/minetest/builtin/common/vector.lua:94: in function 'add' 2021-01-04 13:52:55: ERROR[Main]: ...etest/games/mineclone2/mods/PLAYER/mcl_hunger/hunger.lua:160: in function 'eat' 2021-01-04 13:52:55: ERROR[Main]: ...etest/games/mineclone2/mods/PLAYER/mcl_hunger/hunger.lua:44: in function <...etest/games/mineclone2/mods/PLAYER/mcl_hunger/hunger.lua:6> ```
kay27 commented 2021-01-04 21:10:30 +01:00
Contributor
Copy Link

get_velocity() doesn't work in 5.3.
it should but...
i have a wrap for that but not sure whether it good or not: local velocity = player:get_velocity() or player:get_player_velocity() or {x=0,y=-10,z=0}

```get_velocity()``` doesn't work in 5.3. it should but... i have a wrap for that but not sure whether it good or not: [```local velocity = player:get_velocity() or player:get_player_velocity() or {x=0,y=-10,z=0}```](https://git.minetest.land/Wuzzy/MineClone2/issues/850)
kay27 commented 2021-01-04 21:30:23 +01:00
Contributor
Copy Link

trying to fix locally

00146c96e5

trying to fix locally https://git.minetest.land/kay27/MineClone2/commit/00146c96e5fa8eba5c1989a611b4eef45cf4f178
kay27 commented 2021-01-04 22:14:58 +01:00
Contributor
Copy Link

yep, the fix works as expected

yep, the fix works as expected
LizzyFleckenstein03 referenced this issue from a commit 2021-01-05 11:46:10 +01:00
Fix #954
LizzyFleckenstein03 commented 2021-01-05 11:50:12 +01:00
Author
Member
Copy Link

Ok, I did not expect minetest to be that broken. Do you currently have access rights to this repo or do I need to merge it for you? If so, I need to know how I can pick up a single commit.

Ok, I did not expect minetest to be that broken. Do you currently have access rights to this repo or do I need to merge it for you? If so, I need to know how I can pick up a single commit.
LizzyFleckenstein03 commented 2021-01-05 12:08:25 +01:00
Author
Member
Copy Link

Ok, git cherry-pick did the job.

Ok, `git cherry-pick` did the job.
kay27 commented 2021-01-05 13:34:54 +01:00
Contributor
Copy Link

Thanks. Wussy had revoked the rights, so you are the only one who can help him to fix critical bugs in master.

I don't know whether 5.3 broken or it must be so (?), minetest issue tracker keeps silence about that too...

Thanks. Wussy had revoked the rights, so you are the only one who can help him to fix critical bugs in master. I don't know whether 5.3 broken or it must be so (?), minetest issue tracker keeps silence about that too...
LizzyFleckenstein03 commented 2021-01-05 13:48:02 +01:00
Author
Member
Copy Link

I know what happened. You asked about MT 5.4 compability in the other issue, so I tried it out in MT 5.4 and noticed the warnings. In 5.3 there is get_player_velocity and get_velocity returns nil for players, and in 5.4 get_velocity and get_player_velocity both return the velocity, but get_player_velocity is deprecated.

I know what happened. You asked about MT 5.4 compability in the other issue, so I tried it out in MT 5.4 and noticed the warnings. In 5.3 there is get_player_velocity and get_velocity returns nil for players, and in 5.4 get_velocity and get_player_velocity both return the velocity, but get_player_velocity is deprecated.
👍 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
head-swivel2
doc-update-luanti
projectile-refactor
add-dynamic-rules
hammers_spears
optimize-lightning
mapgen-test-branch
observers-swap-node
dead-player-in-inventory
burning_in_thunder
limit-fire-spread
fake-player-hardening
environment-physics
hollow_logs_improvements
compressed-blocks
chests_api_expand
improve_planks
tree_growth_buildable_to
buildable_flowers
upstream/rewritable_maps
textureconverter-improvement
mapgen_update
pickblock
mob_ignore_fix
mcl_mobs_cleanup
fix-kelp
upstream/unbreaking_on_crossbows
slabs_block_light
redstone-update
add_shader_support
EE_armor
world_aligned_textures
zombie_texture_improvements
mcl_weathered_nodes
orb_of_exchange
patch_skins
hollow_logs_ref_recovery
copper-adaptation-refs-recovery
add_asset_attributions_1
fix_pumpkin_typo_pumkin
cherry_grove
lush_caves
release/0.86.1
mobile_bow_workaround
release/0.85.1
optimize_jukebox_sounds
optimize_theme_ogg
Optimize_backgrounds_jpg
archaeology
spanish-translations
fish_bucket_nametag
villager-golem-fixes
fix_beetroot_fortune_drops
fix_sliding
illager_banner_description
release_0.83.1
skelly_horse_thunder
mobs_armor
mobsarmorfix
smoother_biome_borders
jukebox_sound_distance
cobble_abm_height
callable-tool-rightclick-functions
effects_rewrite
respiration
make-new-music-louder
damage
texture_conversion_wool
dehardcoded_signs
mcl_oxidization
Texture-Rename2
Bamboo-Piston-Dig
hardcore_mode_test
update_german_translation_attempt2
test_mob_tweaks_branch
csm-enabled
move_physics_tweak
water_footstep
biome_skycolor
bambootoo
lower_ow_mapgen
release/0.81.1
revert_chest_models
mcl-craftguide-drop-sfinv
mcl-structures-fixes
turtlestriderbeefox
arrow_node_collision
pvp_knockback
icebergs
light_dump
testing
mobs-redo
wood_api
mobs_head_rotation
bonemeal
dyable-leather-armor
new_mapgen_api
newmobs-master
formspec_overhaul
mobs
mapgen
mineclone5
chat-command-builder-2
formspec-v4
doc-refactoring
production
objects
0.87.2
0.87.1
0.87.0
0.86.2
0.86.1
0.86.0
0.85.0
0.84.0
0.83.1
0.83.0
0.82.0
0.81.1
0.81.0
0.80.1
0.80.0
0.79.0
0.78.0
0.77.0
0.76.0
0.75.0
0.74.0
0.73.1
0.73.0
0.72.1
0.72.0
0.71.0
0.70.0
0.69.1
0.69.0
0.68.0
0.67.2
0.67.1
0.67.0
0.66.2
0.66.1
0.66.0
0.65.2
0.65.1
0.65.0
0.64.0
0.63.0
0.62.0
0.61.0
0.60.0
0.59.2
0.59.1
0.59.0
0.58.1
0.58.0
0.57.1
0.57.0
0.56.2
0.56.1
0.56.0
0.55.1
0.55.0
0.54.1
0.54.0
0.53.4
0.53.3
0.53.2
0.53.1
0.53.0
0.52.1
0.52.0
0.51.1
0.51.0
0.50.2
0.50.1
0.50.0
0.49.0
0.48.1
0.48.0
0.47.1
0.47.0
0.46.0
0.45.1
0.45.0
0.44.0
0.43.0
0.42.0
0.21.0
Labels
Clear labels   
#P1 CRITICAL

for crashes, catastrophic bugs, etc.

  
#P2: HIGH

highest priority level

  
#P3: elevated

2nd-highest priority level

  
#P4 priority: medium

for things that aren't elevated but have been prioritised

  
#P6: low

low priority level

  
#Review

Tickets that may improve or fix an issue but will need a review after a short period of time

  
annoying

non-bugs that annoys people

  
API

   
bug

   
code quality

   
combat

   
commands

   
compatibility

Label to cover migration issues from old worlds or mcl5

  
configurability

   
contribution inside

   
controls

   
core feature

   
creative mode

   
delayed for engine release

   
documentation

   
duplicate

   
enhancement

enhancement request/suggestion

  
environment

Issues that affect weather or light

  
feature request

   
gameplay

   
graphics

   
ground content conflict

mapgen gc-specific quirks

  
GUI/HUD

   
help wanted

   
incomplete feature

   
invalid / won't fix

Invalid, or will not fix

  
items

   
looking for contributor

   
mapgen

   
meta

Relating to VoxeLibre on Mesehub and elsewhere

  
mineclone2+

fit for MineClone2-Plus

  
Minecraft >= 1.13

   
Minecraft >= 1.17

   
missing feature

   
mobile

involving Minetest on mobile devices (android)

  
mobs

   
mod support

Issues related to mod support

  
model needed

A model is needed to be created or updated

  
multiplayer

Issues affecting multiplayer

  
Needs adoption

PR needs author action or to be adopted so changes can be implemented to get the PR closer to merge

  
needs discussion

   
needs engine change

   
needs more information

   
needs research

   
nodes

   
non-mob entities

   
performance

   
player

issues related to the player

  
possible close

   
redstone

   
release notes

This ticket will need information adding to release notes

  
schematics

   
Skyblock

   
sounds

   
Testing / Retest

This needs testing or retesting

  
tools

Related to the tools scripts, which aren't run in game

  
translation

   
unconfirmed
  
mcl5

Possibly relevant for MineClone5

  
mcla

Possibly relevant for Mineclonia

  
Media missing

media files for this feature are missing - contributions welcome

No Label
#P1 CRITICAL
#P2: HIGH
#P3: elevated
#P4 priority: medium
#P6: low
#Review
annoying
API
bug
code quality
combat
commands
compatibility
configurability
contribution inside
controls
core feature
creative mode
delayed for engine release
documentation
duplicate
enhancement
environment
feature request
gameplay
graphics
ground content conflict
GUI/HUD
help wanted
incomplete feature
invalid / won't fix
items
looking for contributor
mapgen
meta
mineclone2+
Minecraft >= 1.13
Minecraft >= 1.17
missing feature
mobile
mobs
mod support
model needed
multiplayer
Needs adoption
needs discussion
needs engine change
needs more information
needs research
nodes
non-mob entities
performance
player
possible close
redstone
release notes
schematics
Skyblock
sounds
Testing / Retest
tools
translation
unconfirmed
mcl5
mcla
Media missing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: VoxeLibre/VoxeLibre#954
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?