From 666fdf31f9cff37f6a6b1ca436ded978588cdc2e Mon Sep 17 00:00:00 2001 From: WillConker Date: Sat, 8 Jun 2024 09:59:19 +0100 Subject: [PATCH] Simplified stew on_craft function with table lookup --- mods/ITEMS/mcl_sus_stew/API.md | 1 + mods/ITEMS/mcl_sus_stew/init.lua | 11 +++++------ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/mods/ITEMS/mcl_sus_stew/API.md b/mods/ITEMS/mcl_sus_stew/API.md index af7cd64cc..5d912151c 100644 --- a/mods/ITEMS/mcl_sus_stew/API.md +++ b/mods/ITEMS/mcl_sus_stew/API.md @@ -17,4 +17,5 @@ Conveniently register a sus stew effect which gives the eater a status effect. ## mcl_sus_stew.register_sus_stew(secret_ingredient, effect_name) Register a suspicious stew crafted with a bowl, red mushroom, brown mushroom and . * secret_ingredient: itemstring of the fourth ingredient +DON'T use bowl or red/brown mushroom as this will mess up all sus stews * effect_name: the name of the sus stew effect to be activated when the sus stew is eaten diff --git a/mods/ITEMS/mcl_sus_stew/init.lua b/mods/ITEMS/mcl_sus_stew/init.lua index 28f6a1bea..bccfb3ec7 100644 --- a/mods/ITEMS/mcl_sus_stew/init.lua +++ b/mods/ITEMS/mcl_sus_stew/init.lua @@ -89,12 +89,11 @@ end minetest.register_on_craft(function(itemstack, player, old_craft_grid, craft_inv) if itemstack:get_name() ~= "mcl_sus_stew:stew" then return end - for f,e in pairs(ingredient_effect) do - for _,it in pairs(old_craft_grid) do - if it:get_name() == f then - itemstack:get_meta():set_string("effect",e) - return itemstack - end + for _,it in pairs(old_craft_grid) do + local effect = ingredient_effect[it:get_name()] + if effect ~= nil then + itemstack:get_meta():set_string("effect", effect) + return itemstack end end end)