Players can sit/lay in air #1

New Issue

rudzik8 · 2022-05-16T10:45:20+02:00

rudzik8 commented

2022-05-16 10:45:20 +02:00

~~Basically, we need to check somehow if player is standing on air currently (and if yes - just don't mount). That's fix of mounting while flying or in jump~~
But we'll be still able to sit/lay on solid node, destroy it anyhow and stay in the air. Need to check gravity somehow too

~~Tried to implement first fix via mcl_playerinfo, but no result sadly.~~
UPD: still need to check gravity somehow and make players fall even while mounted somehow (or dismound and fall if node below is air already?)

~~Basically, we need to check somehow if player is standing on air currently (and if yes - just don't mount). That's fix of mounting while flying or in jump~~ But we'll be still able to sit/lay on solid node, destroy it anyhow and stay in the air. Need to check gravity somehow too ~~Tried to implement first fix via `mcl_playerinfo`, but no result sadly.~~ UPD: still need to check gravity somehow and make players fall even while mounted somehow (or dismound and fall if node below is air already?)

rudzik8 added the

bug

help wanted

labels 2022-05-16 10:45:20 +02:00

cora commented

2022-05-16 12:13:42 +02:00

something like

if minetest.get_node(vector.offset(pos,0,-1,0)).name ~= "air" then return end

should probably get the worst of it

something like `if minetest.get_node(vector.offset(pos,0,-1,0)).name ~= "air" then return end` should probably get the worst of it

rudzik8 commented

2022-05-16 12:26:07 +02:00

if minetest.get_node(vector.offset(pos,0,-1,0)).name ~= "air" then return end

Added. Result is builtin vector error... I'm using 5.6.0-dev btw, dunno if it's the reason.

Added as:

func = function(name)
	local player = minetest.get_player_by_name(name)
	if minetest.get_node(vector.offset(pos,0,-1,0)).name ~= "air" then return end --this
	if mcl_player.player_attached[name] then

> `if minetest.get_node(vector.offset(pos,0,-1,0)).name ~= "air" then return end` Added. Result is builtin vector error... I'm using 5.6.0-dev btw, dunno if it's the reason. Added as: ``` func = function(name) local player = minetest.get_player_by_name(name) if minetest.get_node(vector.offset(pos,0,-1,0)).name ~= "air" then return end --this if mcl_player.player_attached[name] then ```

rudzik8 commented

2022-05-16 12:29:34 +02:00

Crash text (folder is called minetest-5.5.0-51cfb57, but it's 5.6.0-dev (like, not changing main folder but replacing bin, builtin and client with new ones XD)):

AsyncErr: Lua: Runtime error from mod 'mcl_cozy' in callback on_chat_message(): ...est-5.5.0-51cfb57-win64\bin\..\builtin\common\vector.lua:262: attempt to index local 'v' (a nil value)
stack traceback:
	...est-5.5.0-51cfb57-win64\bin\..\builtin\common\vector.lua:262: in function 'offset'
	...netest-5.5.0-51cfb57-win64\bin\..\mods\mcl_cozy\init.lua:54: in function 'func'
	...inetest-5.5.0-51cfb57-win64\bin\..\builtin\game\chat.lua:79: in function <...inetest-5.5.0-51cfb57-win64\bin\..\builtin\game\chat.lua:52>
	...est-5.5.0-51cfb57-win64\bin\..\builtin\game\register.lua:429: in function <...est-5.5.0-51cfb57-win64\bin\..\builtin\game\register.lua:415>

Crash text (folder is called minetest-5.5.0-51cfb57, but it's 5.6.0-dev (like, not changing main folder but replacing bin, builtin and client with new ones XD)): ``` AsyncErr: Lua: Runtime error from mod 'mcl_cozy' in callback on_chat_message(): ...est-5.5.0-51cfb57-win64\bin\..\builtin\common\vector.lua:262: attempt to index local 'v' (a nil value) stack traceback: ...est-5.5.0-51cfb57-win64\bin\..\builtin\common\vector.lua:262: in function 'offset' ...netest-5.5.0-51cfb57-win64\bin\..\mods\mcl_cozy\init.lua:54: in function 'func' ...inetest-5.5.0-51cfb57-win64\bin\..\builtin\game\chat.lua:79: in function <...inetest-5.5.0-51cfb57-win64\bin\..\builtin\game\chat.lua:52> ...est-5.5.0-51cfb57-win64\bin\..\builtin\game\register.lua:429: in function <...est-5.5.0-51cfb57-win64\bin\..\builtin\game\register.lua:415> ```

cora commented

2022-05-16 13:16:10 +02:00

uh yes ... you obv need to replace the pos with a position .. player:get_pos() in your example should work

cora commented

2022-05-16 13:17:43 +02:00

also it needs to be == "air" hehe

func = function(name)
	local player = minetest.get_player_by_name(name)
	if minetest.get_node(vector.offset(player:get_pos(),0,-1,0)).name == "air" then return end

this should work as is

also it needs to be == "air" hehe ``` func = function(name) local player = minetest.get_player_by_name(name) if minetest.get_node(vector.offset(player:get_pos(),0,-1,0)).name == "air" then return end ``` this should work as is

rudzik8 commented

2022-05-16 13:28:48 +02:00

Thanks! But we'll still have the bug with flying in air after destroying node below player, sadly.