From b39deed14df51f83f7c0c1c6de1959aabb1a8daf Mon Sep 17 00:00:00 2001 From: James David Clarke Date: Sun, 14 Jan 2024 13:09:32 +0000 Subject: [PATCH 1/3] Change function call of set_physics_override to a more modern syntax so we dont get the deprecation warnings. --- init.lua | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/init.lua b/init.lua index 438464a..ab88d24 100644 --- a/init.lua +++ b/init.lua @@ -41,14 +41,14 @@ minetest.register_globalstep(function(dtime) players[i]:get_player_control().jump == true or players[i]:get_player_control().sneak == true) then players[i]:set_eye_offset({x=0, y=0, z=0}, {x=0, y=0, z=0}) - players[i]:set_physics_override(1, 1, 1) + players[i]:set_physics_override({speed=1, jump=1, gravity=1}) mcl_player.player_attached[name] = false mcl_player.player_set_animation(players[i], "stand", 30) end -- check the node below player (and if it's air, just unmount) if minetest.get_node(vector.offset(players[i]:get_pos(),0,-1,0)).name == "air" then players[i]:set_eye_offset({x=0, y=0, z=0}, {x=0, y=0, z=0}) - players[i]:set_physics_override(1, 1, 1) + players[i]:set_physics_override({speed=1, jump=1, gravity=1}) mcl_player.player_attached[name] = false end end @@ -62,13 +62,13 @@ minetest.register_chatcommand("sit", { if minetest.get_node(vector.offset(player:get_pos(),0,-1,0)).name == "air" then return end if mcl_player.player_attached[name] then player:set_eye_offset({x=0, y=0, z=0}, {x=0, y=0, z=0}) - player:set_physics_override(1, 1, 1) + player:set_physics_override({speed=1, jump=1, gravity=1}) mcl_player.player_attached[name] = false mcl_player.player_set_animation(player, "stand", 30) print_action_stand(name) else player:set_eye_offset({x=0, y=-7, z=2}, {x=0, y=0, z=0}) - player:set_physics_override(0, 0, 0) + player:set_physics_override({speed=0, jump=0, gravity=0}) mcl_player.player_attached[name] = true mcl_player.player_set_animation(player, "sit", 30) print_action_sit(name) @@ -84,13 +84,13 @@ minetest.register_chatcommand("lay", { if minetest.get_node(vector.offset(player:get_pos(),0,-1,0)).name == "air" then return end if mcl_player.player_attached[name] then player:set_eye_offset({x=0, y=0, z=0}, {x=0, y=0, z=0}) - player:set_physics_override(1, 1, 1) + player:set_physics_override({speed=1, jump=1, gravity=1}) mcl_player.player_attached[name] = false mcl_player.player_set_animation(player, "stand", 30) print_action_stand(name) else player:set_eye_offset({x=0, y=-13, z=0}, {x=0, y=0, z=0}) - player:set_physics_override(0, 0, 0) + player:set_physics_override({speed=0, jump=0, gravity=0}) mcl_player.player_attached[name] = true mcl_player.player_set_animation(player, "lay", 0) print_action_lay(name) From 28bf2612fd084a3d8aa8a2c6da48991f5ac96877 Mon Sep 17 00:00:00 2001 From: James David Clarke Date: Sun, 14 Jan 2024 13:20:30 +0000 Subject: [PATCH 2/3] Added .luacheckrc for linting. --- .luacheckrc | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 .luacheckrc diff --git a/.luacheckrc b/.luacheckrc new file mode 100644 index 0000000..7fabb76 --- /dev/null +++ b/.luacheckrc @@ -0,0 +1,50 @@ +unused_args = false +allow_defined_top = true + +globals = { + "minetest", +} + +read_globals = { + string = {fields = {"split"}}, + table = {fields = {"copy", "getn"}}, + -- My mod + "mcl_cozy", + + -- Builtin + "vector", "ItemStack", + "dump", "DIR_DELIM", "VoxelArea", "Settings", + + -- MTG + "default", "sfinv", "creative", + + -- Mineclone + "mcl_loot", "tga_encoder", "mcl_util", "flowlib", "mcl_sounds", "mcl_autogroup", + "mcl_events", "biomeinfo", "mcl_damage", "mcl_particles", "mcl_worlds", "mcl_colors", + "mcl_explosions", "mcl_vars", "controls", "walkover", "mcl_meshhand", "mcl_fovapi", + "playerphysics", "mcl_hunger", "mcl_death_drop", "mcl_player", "mcl_playerplus", + "mcl_gamemode", "mcl_spawn", "mcl_skins", "mcl_sprint", "mcl_playerinfo", + "mcl_item_id", "tt", "mcl_craftguide", "doc", "mcl_dripping", + "mcl_entity_invs", "mcl_item_entity", "mcl_burning", + "mcl_minecarts", "pillager", "mobs_mc", "sounds", + "textures", "mcl_mobs", "mcl_paintings", + "mcl_grindstone", "mcl_walls", "mcl_bamboo", + "mcl_maps", "mcl_clock", "mcl_end", "mcl_starting_inventory", + "mcl_bows", "mcl_bows_s", "mcl_dye", "mcl_copper", + "mcl_flowerpots", "mcl_furnaces", "mcl_farming", + "mcl_campfires", "mcl_crafting_table", "mcl_doors", + "mcl_jukebox", "screwdriver", "mcl_itemframes", + "mcl_heads", "mcl_beacons", "xpanes", "mcl_enchanting", + "mcl_beds", "mcl_throwing", "mcl_banners", "mcl_mobspawners", + "mcl_cocoas", "mcl_smithing_table", "mcl_flowers", + "mcl_core", "mcl_torches", "mcl_target", "mesecon", "mcl_observers", + "mcl_sculk", "mcl_armor", "mcl_lanterns", "mcl_stairs", "mcl_bells", + "mcl_hamburger", "mcl_signs", "mcl_honey", "mcl_stonecutter", "mcl_fire", + "mcl_compass", "mcl_ocean", "mcl_fences", "mcl_buckets", "mcl_potions", + "tnt", "mcl_cherry_blossom", "mcl_portals", "mcl_chests", "mcl_shields", + "mcl_wip", "mcl_raids", "mcl_moon", "lightning", "mcl_weather", + "mcl_formspec", "mcl_death_messages", "mcl_bossbars", "awards", + "mcl_inventory", "mcl_title", "mcl_offhand", "hb", "mcl_experience", + "mcl_info", "mcl_credits", "tsm_railcorridors", "mcl_mapgen_core", + "mcl_structures", "settlements", "mcl_dungeons", "mcl_colors_official" +} From 626b12c0cb48cb0bde65ff36855db5a0b4264789 Mon Sep 17 00:00:00 2001 From: James David Clarke Date: Sun, 14 Jan 2024 13:42:45 +0000 Subject: [PATCH 3/3] Added luachechrc --- .luacheckrc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.luacheckrc b/.luacheckrc index 7fabb76..7cd82a9 100644 --- a/.luacheckrc +++ b/.luacheckrc @@ -2,7 +2,7 @@ unused_args = false allow_defined_top = true globals = { - "minetest", + "minetest","mcl_tmp_message","mcl_player" } read_globals = { @@ -22,7 +22,7 @@ read_globals = { "mcl_loot", "tga_encoder", "mcl_util", "flowlib", "mcl_sounds", "mcl_autogroup", "mcl_events", "biomeinfo", "mcl_damage", "mcl_particles", "mcl_worlds", "mcl_colors", "mcl_explosions", "mcl_vars", "controls", "walkover", "mcl_meshhand", "mcl_fovapi", - "playerphysics", "mcl_hunger", "mcl_death_drop", "mcl_player", "mcl_playerplus", + "playerphysics", "mcl_hunger", "mcl_death_drop", "mcl_playerplus", "mcl_gamemode", "mcl_spawn", "mcl_skins", "mcl_sprint", "mcl_playerinfo", "mcl_item_id", "tt", "mcl_craftguide", "doc", "mcl_dripping", "mcl_entity_invs", "mcl_item_entity", "mcl_burning",