Inconsistent behaviour when taking 0 damage #4383

New Issue

WillConker · 2024-06-03T22:46:52+02:00

WillConker commented

2024-06-03 22:46:52 +02:00

VoxeLibre version: 0.87.1

What happened?

With resistance 5 (I think this also happens with good armour), fall damage costs 0hp but it still plays the damage sound ~~and flashes screen red~~.
On the other hand, damage from mobs (e.g. look at a rover), lava, drowning and harming potions is also 0hp but the damage sound is not played and the screen does not flash red.

What should happen:

The behaviour should be consistent for all damage sources.
Personally I think that damage sound should always be played when the player takes damage, otherwise the knockback from mobs without any damage noise is confusing, and I think this is what MC does.

VoxeLibre version: 0.87.1 ### What happened? With resistance 5 (I think this also happens with good armour), fall damage costs 0hp but it still plays the damage sound ~~and flashes screen red~~. On the other hand, damage from mobs (e.g. look at a rover), lava, drowning and harming potions is also 0hp but the damage sound is not played and the screen does not flash red. ### What should happen: The behaviour should be consistent for all damage sources. Personally I think that damage sound should always be played when the player takes damage, otherwise the knockback from mobs without any damage noise is confusing, and I think this is what MC does.

WillConker added the

bug

unconfirmed

labels 2024-06-03 22:46:52 +02:00

kneekoo commented

2024-06-04 17:52:16 +02:00

I agree, we really need consistency. The red flash, though, is something that comes from the engine. The only time when it doesn't apply is when the player/mob actually doesn't take damage. This can happen under certain circumstances even by falling from huge heights. I've seen this even in Minetest Game, so it's probably an engine issue.

WillConker commented

2024-06-04 18:47:35 +02:00

I was wrong, I tested and even when taking fall damage the screen does not flash red if 0 damage was taken. The only inconsistent part is the damage sound.

Sign in to join this conversation.