Mineshafts spawn blue dye in chests #4215

New Issue

Eyalonsky · 2024-03-11T22:11:19+01:00

Eyalonsky commented

2024-03-11 22:11:19 +01:00

Mineshafts spawn blue dye instead of lapis lazuli in chests
Inconsistency with minecraft

Mineshafts spawn blue dye instead of lapis lazuli in chests Inconsistency with minecraft

Eyalonsky added the

bug

unconfirmed

labels 2024-03-11 22:11:19 +01:00

teknomunk referenced this issue

2024-03-18 19:57:27 +01:00

Proposal: improve bonemeal API. #2152

teknomunk commented

2024-03-19 12:37:10 +01:00

What version of MineClone are you using? A fix for this was merged into master 2 years ago as part of d2edc75407.

What version of MineClone are you using? A fix for this was merged into master 2 years ago as part of https://git.minetest.land/MineClone2/MineClone2/commit/d2edc75407ba18c3648b33adbc9f95f23fffeb2e.

erlehmann commented

2024-03-19 14:42:32 +01:00

The reason for this is that the developers who separated dye and lapis did not know about item aliases and simply replaced the item string turning all lapis in existing chests into blue dye. This was done despite my warnings and explanations how to avoid that outcome (i.e. never reuse item strings for different items). Despite the obvious turning-a-rare-gem-into-a-common-dye bug being at least slightly annoying it was never reverted.

@Eyalonsky does that still happen when you load your world in Mineclonia? (Make a backup of the world folder first.)

The reason for this is that the developers who separated dye and lapis did not know about item aliases and simply replaced the item string turning all lapis in existing chests into blue dye. This was done despite my warnings and explanations how to avoid that outcome (i.e. never reuse item strings for different items). Despite the obvious turning-a-rare-gem-into-a-common-dye bug being at least slightly annoying it was never reverted. @Eyalonsky does that still happen when you load your world in Mineclonia? (Make a backup of the world folder first.)

ancientmarinerdev commented

2024-03-19 16:15:29 +01:00

The reason for this is that the developers who separated dye and lapis did not know about item aliases and simply replaced the item string turning all lapis in existing chests into blue dye. This was done despite my warnings and explanations how to avoid that outcome (i.e. never reuse item strings for different items). Despite the obvious turning-a-rare-gem-into-a-common-dye bug being at least slightly annoying it was never reverted.

@Eyalonsky does that still happen when you load your world in Mineclonia? (Make a backup of the world folder first.)

The change was made and merged before you warned. It was done, not by developers plural, but by Kabou, a close friend of a Mineclonia maintainer.

The issue has been discussed to death, and the change in there is not being reverted.

For this, we just need to update the logic that adds loot to chests and change it to Lapis from blue dye.

As a workaround, a player should be still able to craft blue dye to Lapis. So they have still gained their Lapis from the chest. Just needs converting.

> The reason for this is that the developers who separated dye and lapis did not know about item aliases and simply replaced the item string turning all lapis in existing chests into blue dye. This was done despite my warnings and explanations how to avoid that outcome (i.e. never reuse item strings for different items). Despite the obvious turning-a-rare-gem-into-a-common-dye bug being at least slightly annoying it was never reverted. > > @Eyalonsky does that still happen when you load your world in Mineclonia? (Make a backup of the world folder first.) The change was made and merged before you warned. It was done, not by developers plural, but by Kabou, a close friend of a Mineclonia maintainer. The issue has been discussed to death, and the change in there is not being reverted. For this, we just need to update the logic that adds loot to chests and change it to Lapis from blue dye. As a workaround, a player should be still able to craft blue dye to Lapis. So they have still gained their Lapis from the chest. Just needs converting.

teknomunk commented

2024-03-19 16:52:28 +01:00

For this, we just need to update the logic that adds loot to chests and change it to Lapis from blue dye.

Best as I can tell, the chest loot tables have already been updated and have been for about 2 years. I checked as part of the bone meal API branch made by that same Kabou I am trying to revive.

Chests that generated before that couldn't have used the updated table.

Really, lapis should never have been named mcl_dye:blue in the first place, but the past can't be changed and we are 2 years late for a non-breaking change to correct that initial mistake.

> For this, we just need to update the logic that adds loot to chests and change it to Lapis from blue dye. Best as I can tell, the chest loot tables have already been updated and have been for about 2 years. I checked as part of the bone meal API branch made by that same Kabou I am trying to revive. Chests that generated before that couldn't have used the updated table. Really, lapis should never have been named mcl_dye:blue in the first place, but the past can't be changed and we are 2 years late for a non-breaking change to correct that initial mistake.

erlehmann commented

2024-03-19 18:34:09 +01:00

The change was made and merged before you warned.

Irrelevant. The PR description actually warned that this would happen: “being autoconverted into a dye on the next upgrade of mineclone is a bit of an surprise inconvenience to the users” – this was clearly user-hostile and still got mergged.

Really, lapis should never have been named mcl_dye:blue in the first place

Changing the item name could have been easily solved with item aliases.

All problems come from item string mcl_dye:blue being re-used.

the past can't be changed and we are 2 years late for a non-breaking change to correct that initial mistake.

I did actually warn about it being an unfixable mistake. I suggested immediately reverting it. Which was not done.

It has also not been 2 years, but that is besides the point.

> The change was made and merged before you warned. Irrelevant. [The PR description actually warned that this would happen:](https://git.minetest.land/MineClone2/MineClone2/pulls/3176) “being autoconverted into a dye on the next upgrade of mineclone is a bit of an surprise inconvenience to the users” – this was clearly user-hostile and still got mergged. > Really, lapis should never have been named mcl_dye:blue in the first place Changing the item name could have been easily solved with item aliases. All problems come from item string `mcl_dye:blue` being re-used. > the past can't be changed and we are 2 years late for a non-breaking change to correct that initial mistake. I did actually warn about it being an unfixable mistake. I suggested immediately reverting it. Which was not done. It has also not been 2 years, but that is besides the point.

ancientmarinerdev commented

2024-03-19 19:37:22 +01:00

The change was made and merged before you warned.

Irrelevant. The PR description actually warned that this would happen: “being autoconverted into a dye on the next upgrade of mineclone is a bit of an surprise inconvenience to the users” – this was clearly user-hostile and still got mergged.

Really, lapis should never have been named mcl_dye:blue in the first place

Changing the item name could have been easily solved with item aliases.

All problems come from item string mcl_dye:blue being re-used.

the past can't be changed and we are 2 years late for a non-breaking change to correct that initial mistake.

I did actually warn about it being an unfixable mistake. I suggested immediately reverting it. Which was not done.

It has also not been 2 years, but that is besides the point.

1 year 3 months ago. And this is the first issue raised. A mitigation has been in placed for over a year and still in, so very low impact.

I agree with teknomunk it should never have been named that.

The only thing I'm curious about is if this is still happening with current versions (dungeons spawning with lapis), so we can plan to fix it if it is.

> > The change was made and merged before you warned. > > Irrelevant. [The PR description actually warned that this would happen:](https://git.minetest.land/MineClone2/MineClone2/pulls/3176) “being autoconverted into a dye on the next upgrade of mineclone is a bit of an surprise inconvenience to the users” – this was clearly user-hostile and still got mergged. > > > Really, lapis should never have been named mcl_dye:blue in the first place > > Changing the item name could have been easily solved with item aliases. > > All problems come from item string `mcl_dye:blue` being re-used. > > > the past can't be changed and we are 2 years late for a non-breaking change to correct that initial mistake. > > I did actually warn about it being an unfixable mistake. I suggested immediately reverting it. Which was not done. > > It has also not been 2 years, but that is besides the point. 1 year 3 months ago. And this is the first issue raised. A mitigation has been in placed for over a year and still in, so very low impact. I agree with teknomunk it should never have been named that. The only thing I'm curious about is if this is still happening with current versions (dungeons spawning with lapis), so we can plan to fix it if it is.

Eyalonsky changed title from ~~Mineshafts spawn blue dye instead of lapis lazuli in chests~~ to Mineshafts spawn blue dye in chests

2024-03-19 20:22:59 +01:00

Eyalonsky commented

2024-03-19 20:25:49 +01:00

correction: its not instead of lapis
mc2 ver 0.86.2
the original seed i had is lost so i cannot reproduce the bug exactly
ill try finding a new seed

correction: its not instead of lapis mc2 ver 0.86.2 the original seed i had is lost so i cannot reproduce the bug exactly ill try finding a new seed

teknomunk commented

2024-03-20 02:06:32 +01:00

I lost the seed

If you still have the world, pressing F5 will show you the world seed. Press F5 a few times and the information will disappear.

> I lost the seed If you still have the world, pressing F5 will show you the world seed. Press F5 a few times and the information will disappear.

Screenshot_2024-03-19_20-03-34.png

53 KiB

Eyalonsky commented

2024-03-20 02:48:04 +01:00

I lost the seed

If you still have the world, pressing F5 will show you the world seed. Press F5 a few times and the information will disappear.

what i meant by lost the seed is that i deleted the world
tbh im not sure if i saw that bug before or after i upgraded to mt 5.8 and updated mc2

i think its safe to close this issue because i cannot reproduce it until i can find evidence that i saw blue dye on mt 5.8 and mc2 ver 0.86.2
on the other hand might still be worth looking a little longer

> > I lost the seed > > If you still have the world, pressing F5 will show you the world seed. Press F5 a few times and the information will disappear. what i meant by lost the seed is that i deleted the world tbh im not sure if i saw that bug before or after i upgraded to mt 5.8 and updated mc2 i think its safe to close this issue because i cannot reproduce it until i can find evidence that i saw blue dye on mt 5.8 and mc2 ver 0.86.2 on the other hand might still be worth looking a little longer

the-real-herowl added the

possible close

label 2024-03-20 03:58:54 +01:00

Sign in to join this conversation.